[INFO] updating cached repository drakeor/guildsim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/drakeor/guildsim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/drakeor/guildsim" "work/ex/clippy-test-run/sources/stable/gh/drakeor/guildsim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/drakeor/guildsim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/drakeor/guildsim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drakeor/guildsim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drakeor/guildsim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 510f0207de21ea5a0942d23d945a4d32ed19ad1f [INFO] sha for GitHub repo drakeor/guildsim: 510f0207de21ea5a0942d23d945a4d32ed19ad1f [INFO] validating manifest of drakeor/guildsim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of drakeor/guildsim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing drakeor/guildsim [INFO] finished frobbing drakeor/guildsim [INFO] frobbed toml for drakeor/guildsim written to work/ex/clippy-test-run/sources/stable/gh/drakeor/guildsim/Cargo.toml [INFO] started frobbing drakeor/guildsim [INFO] finished frobbing drakeor/guildsim [INFO] frobbed toml for drakeor/guildsim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drakeor/guildsim/Cargo.toml [INFO] crate drakeor/guildsim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting drakeor/guildsim against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drakeor/guildsim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 29c0e53ab54ec53387503768fcc29d7e6a9b88fff2c08a8c5792a5a6b9bc8be1 [INFO] running `"docker" "start" "-a" "29c0e53ab54ec53387503768fcc29d7e6a9b88fff2c08a8c5792a5a6b9bc8be1"` [INFO] [stderr] Checking rand v0.5.2 [INFO] [stderr] Checking guildsim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | ai_type: ai_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ai_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:301:5 [INFO] [stderr] | [INFO] [stderr] 301 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:304:5 [INFO] [stderr] | [INFO] [stderr] 304 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | ai_type: ai_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ai_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:301:5 [INFO] [stderr] | [INFO] [stderr] 301 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:304:5 [INFO] [stderr] | [INFO] [stderr] 304 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | player [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | let player = Player { [INFO] [stderr] | __________________^ [INFO] [stderr] 76 | | health: MAXHEALTH, [INFO] [stderr] 77 | | //money: (250 + rand::thread_rng().gen_range(0_i32, 801_i32) as i32), [INFO] [stderr] 78 | | money: 250, [INFO] [stderr] ... | [INFO] [stderr] 88 | | relationships: Vec::new() [INFO] [stderr] 89 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | player [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | let player = Player { [INFO] [stderr] | __________________^ [INFO] [stderr] 76 | | health: MAXHEALTH, [INFO] [stderr] 77 | | //money: (250 + rand::thread_rng().gen_range(0_i32, 801_i32) as i32), [INFO] [stderr] 78 | | money: 250, [INFO] [stderr] ... | [INFO] [stderr] 88 | | relationships: Vec::new() [INFO] [stderr] 89 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `player` [INFO] [stderr] --> src/main.rs:143:19 [INFO] [stderr] | [INFO] [stderr] 143 | fn calc_socialize(player: &Player) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider using `_player` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c_player` [INFO] [stderr] --> src/main.rs:270:16 [INFO] [stderr] | [INFO] [stderr] 270 | fn do_ai_basic(c_player: usize, players: &Vec) -> VecDeque { [INFO] [stderr] | ^^^^^^^^ help: consider using `_c_player` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `players` [INFO] [stderr] --> src/main.rs:270:33 [INFO] [stderr] | [INFO] [stderr] 270 | fn do_ai_basic(c_player: usize, players: &Vec) -> VecDeque { [INFO] [stderr] | ^^^^^^^ help: consider using `_players` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `task_buf` [INFO] [stderr] --> src/main.rs:307:17 [INFO] [stderr] | [INFO] [stderr] 307 | let mut task_buf : VecDeque = VecDeque::new(); [INFO] [stderr] | ^^^^^^^^ help: consider using `_task_buf` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | let mut is_running = true; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:307:13 [INFO] [stderr] | [INFO] [stderr] 307 | let mut task_buf : VecDeque = VecDeque::new(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BASE_ENTERTAIN_FAVOR_INCREASE` [INFO] [stderr] --> src/main.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | const BASE_ENTERTAIN_FAVOR_INCREASE: i32 = 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Office` [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | Office, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Office` [INFO] [stderr] --> src/main.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | struct Office { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `action_exists` [INFO] [stderr] --> src/main.rs:95:1 [INFO] [stderr] | [INFO] [stderr] 95 | fn action_exists(l_task: TurnTask, queue: &VecDeque) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:149:40 [INFO] [stderr] | [INFO] [stderr] 149 | fn do_player(c_player: usize, players: &Vec) -> VecDeque { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Player]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `players` [INFO] [stderr] --> src/main.rs:243:26 [INFO] [stderr] | [INFO] [stderr] 243 | for i in 0..players.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 243 | for (i, ) in players.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:270:42 [INFO] [stderr] | [INFO] [stderr] 270 | fn do_ai_basic(c_player: usize, players: &Vec) -> VecDeque { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Player]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/main.rs:306:11 [INFO] [stderr] | [INFO] [stderr] 306 | while is_running { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `guildsim`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `player` [INFO] [stderr] --> src/main.rs:143:19 [INFO] [stderr] | [INFO] [stderr] 143 | fn calc_socialize(player: &Player) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider using `_player` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c_player` [INFO] [stderr] --> src/main.rs:270:16 [INFO] [stderr] | [INFO] [stderr] 270 | fn do_ai_basic(c_player: usize, players: &Vec) -> VecDeque { [INFO] [stderr] | ^^^^^^^^ help: consider using `_c_player` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `players` [INFO] [stderr] --> src/main.rs:270:33 [INFO] [stderr] | [INFO] [stderr] 270 | fn do_ai_basic(c_player: usize, players: &Vec) -> VecDeque { [INFO] [stderr] | ^^^^^^^ help: consider using `_players` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `task_buf` [INFO] [stderr] --> src/main.rs:307:17 [INFO] [stderr] | [INFO] [stderr] 307 | let mut task_buf : VecDeque = VecDeque::new(); [INFO] [stderr] | ^^^^^^^^ help: consider using `_task_buf` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | let mut is_running = true; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:307:13 [INFO] [stderr] | [INFO] [stderr] 307 | let mut task_buf : VecDeque = VecDeque::new(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BASE_ENTERTAIN_FAVOR_INCREASE` [INFO] [stderr] --> src/main.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | const BASE_ENTERTAIN_FAVOR_INCREASE: i32 = 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Office` [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | Office, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Office` [INFO] [stderr] --> src/main.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | struct Office { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `action_exists` [INFO] [stderr] --> src/main.rs:95:1 [INFO] [stderr] | [INFO] [stderr] 95 | fn action_exists(l_task: TurnTask, queue: &VecDeque) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:149:40 [INFO] [stderr] | [INFO] [stderr] 149 | fn do_player(c_player: usize, players: &Vec) -> VecDeque { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Player]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `players` [INFO] [stderr] --> src/main.rs:243:26 [INFO] [stderr] | [INFO] [stderr] 243 | for i in 0..players.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 243 | for (i, ) in players.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:270:42 [INFO] [stderr] | [INFO] [stderr] 270 | fn do_ai_basic(c_player: usize, players: &Vec) -> VecDeque { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Player]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/main.rs:306:11 [INFO] [stderr] | [INFO] [stderr] 306 | while is_running { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `guildsim`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "29c0e53ab54ec53387503768fcc29d7e6a9b88fff2c08a8c5792a5a6b9bc8be1"` [INFO] running `"docker" "rm" "-f" "29c0e53ab54ec53387503768fcc29d7e6a9b88fff2c08a8c5792a5a6b9bc8be1"` [INFO] [stdout] 29c0e53ab54ec53387503768fcc29d7e6a9b88fff2c08a8c5792a5a6b9bc8be1