[INFO] updating cached repository dputtick/protobuf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dputtick/protobuf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dputtick/protobuf" "work/ex/clippy-test-run/sources/stable/gh/dputtick/protobuf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dputtick/protobuf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dputtick/protobuf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dputtick/protobuf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dputtick/protobuf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1a1b2d63afe7a8bea3ed779683353427dd57deae [INFO] sha for GitHub repo dputtick/protobuf: 1a1b2d63afe7a8bea3ed779683353427dd57deae [INFO] validating manifest of dputtick/protobuf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dputtick/protobuf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dputtick/protobuf [INFO] finished frobbing dputtick/protobuf [INFO] frobbed toml for dputtick/protobuf written to work/ex/clippy-test-run/sources/stable/gh/dputtick/protobuf/Cargo.toml [INFO] started frobbing dputtick/protobuf [INFO] finished frobbing dputtick/protobuf [INFO] frobbed toml for dputtick/protobuf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dputtick/protobuf/Cargo.toml [INFO] crate dputtick/protobuf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dputtick/protobuf against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dputtick/protobuf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 38ccee740d77b2928d1e508386aa4bcacabfa122e7958f4cca851f19bc7ad252 [INFO] running `"docker" "start" "-a" "38ccee740d77b2928d1e508386aa4bcacabfa122e7958f4cca851f19bc7ad252"` [INFO] [stderr] Checking protobuf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | Key{wire_type: wire_type, tag: decoded_key >> 3} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wire_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | Key{wire_type: wire_type, tag: decoded_key >> 3} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wire_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / if key.wire_type == WireType::Varint { [INFO] [stderr] 12 | | if key.tag == 1 { [INFO] [stderr] 13 | | res.a = varint_decode(&slice_bytes[(next_pos as usize)..]); [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 11 | if key.wire_type == WireType::Varint && key.tag == 1 { [INFO] [stderr] 12 | res.a = varint_decode(&slice_bytes[(next_pos as usize)..]); [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | if byte & 0b10000000 == 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | let value = next & 0b01111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | if next & 0b10000000 == 0b10000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:44:33 [INFO] [stderr] | [INFO] [stderr] 44 | if next & 0b10000000 == 0b10000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:60:49 [INFO] [stderr] | [INFO] [stderr] 60 | let wire_type = match (decoded_key as u8) & 0b00000111 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | let bottommask = 0b01111111 as u64; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / if key.wire_type == WireType::Varint { [INFO] [stderr] 12 | | if key.tag == 1 { [INFO] [stderr] 13 | | res.a = varint_decode(&slice_bytes[(next_pos as usize)..]); [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 11 | if key.wire_type == WireType::Varint && key.tag == 1 { [INFO] [stderr] 12 | res.a = varint_decode(&slice_bytes[(next_pos as usize)..]); [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | if byte & 0b10000000 == 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | let value = next & 0b01111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | if next & 0b10000000 == 0b10000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:44:33 [INFO] [stderr] | [INFO] [stderr] 44 | if next & 0b10000000 == 0b10000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:60:49 [INFO] [stderr] | [INFO] [stderr] 60 | let wire_type = match (decoded_key as u8) & 0b00000111 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | let bottommask = 0b01111111 as u64; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:99:32 [INFO] [stderr] | [INFO] [stderr] 99 | assert_eq!(varint_decode(&[0b10101100, 0b00000010]), 300); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:99:44 [INFO] [stderr] | [INFO] [stderr] 99 | assert_eq!(varint_decode(&[0b10101100, 0b00000010]), 300); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:100:32 [INFO] [stderr] | [INFO] [stderr] 100 | assert_eq!(varint_decode(&[0b00000001]), 1); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:101:32 [INFO] [stderr] | [INFO] [stderr] 101 | assert_eq!(varint_decode(&[0b00000000]), 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:106:38 [INFO] [stderr] | [INFO] [stderr] 106 | assert_eq!(*varint_encode(300), [0b10101100, 0b00000010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:106:50 [INFO] [stderr] | [INFO] [stderr] 106 | assert_eq!(*varint_encode(300), [0b10101100, 0b00000010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:107:37 [INFO] [stderr] | [INFO] [stderr] 107 | assert_eq!(*varint_encode(42), [0b00101010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:108:36 [INFO] [stderr] | [INFO] [stderr] 108 | assert_eq!(*varint_encode(1), [0b00000001]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:109:36 [INFO] [stderr] | [INFO] [stderr] 109 | assert_eq!(*varint_encode(0), [0b00000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:114:32 [INFO] [stderr] | [INFO] [stderr] 114 | let input: &[u64] = &[150, 1500000, 0, 2340239420394]; [INFO] [stderr] | ^^^^^^^ help: consider: `1_500_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:114:44 [INFO] [stderr] | [INFO] [stderr] 114 | let input: &[u64] = &[150, 1500000, 0, 2340239420394]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `2_340_239_420_394` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_bytes` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | fn from_bytes(slice_bytes: &[u8]) -> IntMessage { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `next_varint_pos` [INFO] [stderr] --> src/main.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | fn next_varint_pos(slice: &[u8], start: u64) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `varint_decode` [INFO] [stderr] --> src/main.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | fn varint_decode(bytes: &[u8]) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Varint` [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | Varint, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `unpack_key` [INFO] [stderr] --> src/main.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | fn unpack_key(varint_key: &[u8]) -> Key { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | while let Some(& next) = bytes_iter.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `for & next in bytes_iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:43:19 [INFO] [stderr] | [INFO] [stderr] 43 | retval += (value as u64) << shift_width; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | temp = temp >> 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `temp >>= 7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1 << 3` [INFO] [stderr] --> src/main.rs:92:45 [INFO] [stderr] | [INFO] [stderr] 92 | slice.extend_from_slice(&*varint_encode(1 << 3 | 0)); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | while let Some(& next) = bytes_iter.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `for & next in bytes_iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:43:19 [INFO] [stderr] | [INFO] [stderr] 43 | retval += (value as u64) << shift_width; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | temp = temp >> 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `temp >>= 7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1 << 3` [INFO] [stderr] --> src/main.rs:92:45 [INFO] [stderr] | [INFO] [stderr] 92 | slice.extend_from_slice(&*varint_encode(1 << 3 | 0)); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1 << 3` [INFO] [stderr] --> src/main.rs:122:43 [INFO] [stderr] | [INFO] [stderr] 122 | assert_eq!(unpack_key(&*varint_encode(1 << 3 | 0)), Key{wire_type: WireType::Varint, tag: 1}); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1 << 3` [INFO] [stderr] --> src/main.rs:128:53 [INFO] [stderr] | [INFO] [stderr] 128 | message_bytes.extend_from_slice(&*varint_encode(1 << 3 | 0)); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.95s [INFO] running `"docker" "inspect" "38ccee740d77b2928d1e508386aa4bcacabfa122e7958f4cca851f19bc7ad252"` [INFO] running `"docker" "rm" "-f" "38ccee740d77b2928d1e508386aa4bcacabfa122e7958f4cca851f19bc7ad252"` [INFO] [stdout] 38ccee740d77b2928d1e508386aa4bcacabfa122e7958f4cca851f19bc7ad252