[INFO] updating cached repository dougli1sqrd/rustship [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dougli1sqrd/rustship [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dougli1sqrd/rustship" "work/ex/clippy-test-run/sources/stable/gh/dougli1sqrd/rustship"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dougli1sqrd/rustship'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dougli1sqrd/rustship" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dougli1sqrd/rustship"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dougli1sqrd/rustship'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a05705123fb3459213ee90de466d8b4867a031d9 [INFO] sha for GitHub repo dougli1sqrd/rustship: a05705123fb3459213ee90de466d8b4867a031d9 [INFO] validating manifest of dougli1sqrd/rustship on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dougli1sqrd/rustship on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dougli1sqrd/rustship [INFO] finished frobbing dougli1sqrd/rustship [INFO] frobbed toml for dougli1sqrd/rustship written to work/ex/clippy-test-run/sources/stable/gh/dougli1sqrd/rustship/Cargo.toml [INFO] started frobbing dougli1sqrd/rustship [INFO] finished frobbing dougli1sqrd/rustship [INFO] frobbed toml for dougli1sqrd/rustship written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dougli1sqrd/rustship/Cargo.toml [INFO] crate dougli1sqrd/rustship has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dougli1sqrd/rustship against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dougli1sqrd/rustship:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 723b921686a9368ba422fc75a399a8da50bb6c1fd6c7a1470e2f01af376d1cea [INFO] running `"docker" "start" "-a" "723b921686a9368ba422fc75a399a8da50bb6c1fd6c7a1470e2f01af376d1cea"` [INFO] [stderr] Checking rustship v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board/orientation.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board/orientation.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | row: row [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board/orientation.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board/orientation.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | row: row [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/grid/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub mod grid; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/grid/grid.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return f.write_str(&boardstring); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `f.write_str(&boardstring)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/board/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod board; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/board.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return self.place_ship(ship); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.place_ship(ship)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/board.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return Err(outside); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(outside)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/board.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return HitStatus::Miss; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HitStatus::Miss` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/board.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/board.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return HitStatus::Miss; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HitStatus::Miss` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/shot.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return hit_status; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hit_status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pieces/ship.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return coordinates; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `coordinates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pieces/ship.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pieces/ship.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pieces/ship.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return self.position; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `coordinate` [INFO] [stderr] --> src/board/board.rs:95:32 [INFO] [stderr] | [INFO] [stderr] 95 | fn resolve_hit(& mut self, coordinate: Coordinate) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_coordinate` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Horizontal` [INFO] [stderr] --> src/board/orientation.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | Horizontal, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Vertical` [INFO] [stderr] --> src/board/orientation.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Vertical [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rotate` [INFO] [stderr] --> src/board/orientation.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn rotate(self) -> Orientation { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `place` [INFO] [stderr] --> src/board/board.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn place(& mut self, ship_type: ShipType, position: Coordinate, direction: Orientation) -> Result<(), Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `place_ship` [INFO] [stderr] --> src/board/board.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn place_ship(& mut self, ship: Ship<'a>) -> Result<(), Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `receive_shot` [INFO] [stderr] --> src/board/board.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn receive_shot(& mut self, coordinate: Coordinate) -> HitStatus { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update_grid` [INFO] [stderr] --> src/board/board.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | fn update_grid(& mut self, coordinates: &[Coordinate], ship: Ship<'a>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `ShipType` [INFO] [stderr] --> src/pieces/ship.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub enum ShipType { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `symbol` [INFO] [stderr] --> src/pieces/ship.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | symbol: char, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/pieces/ship.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | name: & 'a str, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/pieces/ship.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn new(ship_type: ShipType) -> ShipTypeData<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/pieces/ship.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn new(ship_type: ShipType) -> Ship<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `symbol` [INFO] [stderr] --> src/pieces/ship.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn symbol(&self) -> char { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rotate` [INFO] [stderr] --> src/pieces/ship.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn rotate(& mut self) -> & Ship { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `change_pos` [INFO] [stderr] --> src/pieces/ship.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn change_pos(& mut self, position: Coordinate) -> & Ship { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_position` [INFO] [stderr] --> src/pieces/ship.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn get_position(&self) -> Coordinate { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/board/orientation.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | let orientation_name = match self { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 31 | | &Orientation::Horizontal => "Horizontal", [INFO] [stderr] 32 | | &Orientation::Vertical => "Vertical" [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | let orientation_name = match *self { [INFO] [stderr] 31 | Orientation::Horizontal => "Horizontal", [INFO] [stderr] 32 | Orientation::Vertical => "Vertical" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/board/shot.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match self { [INFO] [stderr] 14 | | &HitStatus::Hit => write!(f, "Hit"), [INFO] [stderr] 15 | | &HitStatus::Miss => write!(f, "Miss") [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *self { [INFO] [stderr] 14 | HitStatus::Hit => write!(f, "Hit"), [INFO] [stderr] 15 | HitStatus::Miss => write!(f, "Miss") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/pieces/ship.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / match self.coordinates().contains(&coordinate) { [INFO] [stderr] 105 | | true => HitStatus::Hit, [INFO] [stderr] 106 | | false => HitStatus::Miss [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.coordinates().contains(&coordinate) { HitStatus::Hit } else { HitStatus::Miss }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/grid/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub mod grid; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/grid/grid.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return f.write_str(&boardstring); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `f.write_str(&boardstring)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/board/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod board; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/board.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return self.place_ship(ship); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.place_ship(ship)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/board.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return Err(outside); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(outside)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/board.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return HitStatus::Miss; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HitStatus::Miss` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/board.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/board.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return HitStatus::Miss; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HitStatus::Miss` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/shot.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return hit_status; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hit_status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pieces/ship.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return coordinates; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `coordinates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pieces/ship.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pieces/ship.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pieces/ship.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return self.position; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `coordinate` [INFO] [stderr] --> src/board/board.rs:95:32 [INFO] [stderr] | [INFO] [stderr] 95 | fn resolve_hit(& mut self, coordinate: Coordinate) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_coordinate` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/pieces/ship.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | name: & 'a str, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/board/orientation.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | let orientation_name = match self { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 31 | | &Orientation::Horizontal => "Horizontal", [INFO] [stderr] 32 | | &Orientation::Vertical => "Vertical" [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | let orientation_name = match *self { [INFO] [stderr] 31 | Orientation::Horizontal => "Horizontal", [INFO] [stderr] 32 | Orientation::Vertical => "Vertical" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/board/shot.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match self { [INFO] [stderr] 14 | | &HitStatus::Hit => write!(f, "Hit"), [INFO] [stderr] 15 | | &HitStatus::Miss => write!(f, "Miss") [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *self { [INFO] [stderr] 14 | HitStatus::Hit => write!(f, "Hit"), [INFO] [stderr] 15 | HitStatus::Miss => write!(f, "Miss") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/pieces/ship.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / match self.coordinates().contains(&coordinate) { [INFO] [stderr] 105 | | true => HitStatus::Hit, [INFO] [stderr] 106 | | false => HitStatus::Miss [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.coordinates().contains(&coordinate) { HitStatus::Hit } else { HitStatus::Miss }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "723b921686a9368ba422fc75a399a8da50bb6c1fd6c7a1470e2f01af376d1cea"` [INFO] running `"docker" "rm" "-f" "723b921686a9368ba422fc75a399a8da50bb6c1fd6c7a1470e2f01af376d1cea"` [INFO] [stdout] 723b921686a9368ba422fc75a399a8da50bb6c1fd6c7a1470e2f01af376d1cea