[INFO] updating cached repository dmolokanov/tictactoe [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dmolokanov/tictactoe [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dmolokanov/tictactoe" "work/ex/clippy-test-run/sources/stable/gh/dmolokanov/tictactoe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dmolokanov/tictactoe'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dmolokanov/tictactoe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmolokanov/tictactoe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmolokanov/tictactoe'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f8412a739baa31cfa420ca5b9c4969b0a9882b25 [INFO] sha for GitHub repo dmolokanov/tictactoe: f8412a739baa31cfa420ca5b9c4969b0a9882b25 [INFO] validating manifest of dmolokanov/tictactoe on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dmolokanov/tictactoe on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dmolokanov/tictactoe [INFO] finished frobbing dmolokanov/tictactoe [INFO] frobbed toml for dmolokanov/tictactoe written to work/ex/clippy-test-run/sources/stable/gh/dmolokanov/tictactoe/Cargo.toml [INFO] started frobbing dmolokanov/tictactoe [INFO] finished frobbing dmolokanov/tictactoe [INFO] frobbed toml for dmolokanov/tictactoe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmolokanov/tictactoe/Cargo.toml [INFO] crate dmolokanov/tictactoe has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dmolokanov/tictactoe against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmolokanov/tictactoe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 759bec72301cbe165ae70e29a626034ac839f6bef8ad90256bb5d8008a5e7cb9 [INFO] running `"docker" "start" "-a" "759bec72301cbe165ae70e29a626034ac839f6bef8ad90256bb5d8008a5e7cb9"` [INFO] [stderr] Checking tictactoe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Game { [INFO] [stderr] 10 | | Game { [INFO] [stderr] 11 | | board: Board::new() [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | impl Default for game::Game { [INFO] [stderr] 9 | fn default() -> Self { [INFO] [stderr] 10 | Self::new() [INFO] [stderr] 11 | } [INFO] [stderr] 12 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:15:39 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn place(&mut self, position: &Position, player: Player) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Game { [INFO] [stderr] 10 | | Game { [INFO] [stderr] 11 | | board: Board::new() [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | impl Default for game::Game { [INFO] [stderr] 9 | fn default() -> Self { [INFO] [stderr] 10 | Self::new() [INFO] [stderr] 11 | } [INFO] [stderr] 12 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `board::Board` [INFO] [stderr] --> src/board/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Board { [INFO] [stderr] 16 | | Board { [INFO] [stderr] 17 | | cells: HashMap::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:15:39 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn place(&mut self, position: &Position, player: Player) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board/mod.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn place(&mut self, position: &Position, player: Player) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `board::Board` [INFO] [stderr] --> src/board/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Board { [INFO] [stderr] 16 | | Board { [INFO] [stderr] 17 | | cells: HashMap::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board/mod.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn place(&mut self, position: &Position, player: Player) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.43s [INFO] running `"docker" "inspect" "759bec72301cbe165ae70e29a626034ac839f6bef8ad90256bb5d8008a5e7cb9"` [INFO] running `"docker" "rm" "-f" "759bec72301cbe165ae70e29a626034ac839f6bef8ad90256bb5d8008a5e7cb9"` [INFO] [stdout] 759bec72301cbe165ae70e29a626034ac839f6bef8ad90256bb5d8008a5e7cb9