[INFO] updating cached repository dmitryvk/js-lex-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dmitryvk/js-lex-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dmitryvk/js-lex-rs" "work/ex/clippy-test-run/sources/stable/gh/dmitryvk/js-lex-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dmitryvk/js-lex-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dmitryvk/js-lex-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmitryvk/js-lex-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmitryvk/js-lex-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 91f22cb542948424819d6d3f22f0d1426630ebf0 [INFO] sha for GitHub repo dmitryvk/js-lex-rs: 91f22cb542948424819d6d3f22f0d1426630ebf0 [INFO] validating manifest of dmitryvk/js-lex-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dmitryvk/js-lex-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dmitryvk/js-lex-rs [INFO] finished frobbing dmitryvk/js-lex-rs [INFO] frobbed toml for dmitryvk/js-lex-rs written to work/ex/clippy-test-run/sources/stable/gh/dmitryvk/js-lex-rs/Cargo.toml [INFO] started frobbing dmitryvk/js-lex-rs [INFO] finished frobbing dmitryvk/js-lex-rs [INFO] frobbed toml for dmitryvk/js-lex-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmitryvk/js-lex-rs/Cargo.toml [INFO] crate dmitryvk/js-lex-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dmitryvk/js-lex-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmitryvk/js-lex-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 13b8b43cd040182afdcc10e6a1a40824829cf29036934bb18eca6bb215d0db0e [INFO] running `"docker" "start" "-a" "13b8b43cd040182afdcc10e6a1a40824829cf29036934bb18eca6bb215d0db0e"` [INFO] [stderr] Checking js-lex-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex_stream.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | iterator: iterator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `iterator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lex_stream.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | iterator: iterator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `iterator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lex_stream.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lex_stream.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | let result = self.iterator.next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | let result = tokenizer.collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lex_stream.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lex_stream.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | let result = self.iterator.next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | let result = tokenizer.collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lex_stream.rs:15:12 [INFO] [stderr] | [INFO] [stderr] 15 | if self.lookahead_buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.lookahead_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lex_stream.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | if self.lookahead_buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.lookahead_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:158:21 [INFO] [stderr] | [INFO] [stderr] 158 | / match self.char_iter.lookahead(0) { [INFO] [stderr] 159 | | Some('-') => { [INFO] [stderr] 160 | | r.push('-'); [INFO] [stderr] 161 | | self.char_iter.skip(1); [INFO] [stderr] 162 | | }, [INFO] [stderr] 163 | | _ => { } [INFO] [stderr] 164 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 158 | if let Some('-') = self.char_iter.lookahead(0) { [INFO] [stderr] 159 | r.push('-'); [INFO] [stderr] 160 | self.char_iter.skip(1); [INFO] [stderr] 161 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lex_stream.rs:15:12 [INFO] [stderr] | [INFO] [stderr] 15 | if self.lookahead_buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.lookahead_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lex_stream.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | if self.lookahead_buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.lookahead_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/lib.rs:396:5 [INFO] [stderr] | [INFO] [stderr] 396 | / fn next(&mut self) -> Option { [INFO] [stderr] 397 | | match self.char_iter.lookahead(0) { [INFO] [stderr] 398 | | None => None, [INFO] [stderr] 399 | | Some(c) => { [INFO] [stderr] ... | [INFO] [stderr] 813 | | } [INFO] [stderr] 814 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:438:39 [INFO] [stderr] | [INFO] [stderr] 438 | self.in_for = if self.lexer_vars.last_token_for { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `self.lexer_vars.last_token_for` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:158:21 [INFO] [stderr] | [INFO] [stderr] 158 | / match self.char_iter.lookahead(0) { [INFO] [stderr] 159 | | Some('-') => { [INFO] [stderr] 160 | | r.push('-'); [INFO] [stderr] 161 | | self.char_iter.skip(1); [INFO] [stderr] 162 | | }, [INFO] [stderr] 163 | | _ => { } [INFO] [stderr] 164 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 158 | if let Some('-') = self.char_iter.lookahead(0) { [INFO] [stderr] 159 | r.push('-'); [INFO] [stderr] 160 | self.char_iter.skip(1); [INFO] [stderr] 161 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:745:68 [INFO] [stderr] | [INFO] [stderr] 745 | JsToken::MultilineComment(ref x) if x.contains("\n") => { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:763:68 [INFO] [stderr] | [INFO] [stderr] 763 | JsToken::MultilineComment(ref x) if x.contains("\n") => { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/lib.rs:396:5 [INFO] [stderr] | [INFO] [stderr] 396 | / fn next(&mut self) -> Option { [INFO] [stderr] 397 | | match self.char_iter.lookahead(0) { [INFO] [stderr] 398 | | None => None, [INFO] [stderr] 399 | | Some(c) => { [INFO] [stderr] ... | [INFO] [stderr] 813 | | } [INFO] [stderr] 814 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:438:39 [INFO] [stderr] | [INFO] [stderr] 438 | self.in_for = if self.lexer_vars.last_token_for { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `self.lexer_vars.last_token_for` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:745:68 [INFO] [stderr] | [INFO] [stderr] 745 | JsToken::MultilineComment(ref x) if x.contains("\n") => { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:763:68 [INFO] [stderr] | [INFO] [stderr] 763 | JsToken::MultilineComment(ref x) if x.contains("\n") => { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/tokens-tests.rs:444:20 [INFO] [stderr] | [INFO] [stderr] 444 | const JQUERY_SRC: &'static str = include_str!("jquery-1.12.4.js"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/tokens-tests.rs:445:24 [INFO] [stderr] | [INFO] [stderr] 445 | const JQUERY_MIN_SRC: &'static str = include_str!("jquery-1.12.4.min.js"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/tokens-tests.rs:451:9 [INFO] [stderr] | [INFO] [stderr] 451 | / if let &JsToken::Unknown(_) = token { [INFO] [stderr] 452 | | assert!(false, "Found unknown token: {:?}", token); [INFO] [stderr] 453 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 451 | if let JsToken::Unknown(_) = *token { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/tokens-tests.rs:462:9 [INFO] [stderr] | [INFO] [stderr] 462 | / if let &JsToken::Unknown(_) = token { [INFO] [stderr] 463 | | assert!(false, "Found unknown token: {:?}", token); [INFO] [stderr] 464 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 462 | if let JsToken::Unknown(_) = *token { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.72s [INFO] running `"docker" "inspect" "13b8b43cd040182afdcc10e6a1a40824829cf29036934bb18eca6bb215d0db0e"` [INFO] running `"docker" "rm" "-f" "13b8b43cd040182afdcc10e6a1a40824829cf29036934bb18eca6bb215d0db0e"` [INFO] [stdout] 13b8b43cd040182afdcc10e6a1a40824829cf29036934bb18eca6bb215d0db0e