[INFO] updating cached repository dittos/rust-aheui
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dittos/rust-aheui
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dittos/rust-aheui" "work/ex/clippy-test-run/sources/stable/gh/dittos/rust-aheui"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dittos/rust-aheui'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dittos/rust-aheui" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dittos/rust-aheui"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dittos/rust-aheui'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c807fdc035778c874d0ee35423405b351dc14d9f
[INFO] sha for GitHub repo dittos/rust-aheui: c807fdc035778c874d0ee35423405b351dc14d9f
[INFO] validating manifest of dittos/rust-aheui on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dittos/rust-aheui on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dittos/rust-aheui
[INFO] finished frobbing dittos/rust-aheui
[INFO] frobbed toml for dittos/rust-aheui written to work/ex/clippy-test-run/sources/stable/gh/dittos/rust-aheui/Cargo.toml
[INFO] started frobbing dittos/rust-aheui
[INFO] finished frobbing dittos/rust-aheui
[INFO] frobbed toml for dittos/rust-aheui written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dittos/rust-aheui/Cargo.toml
[INFO] crate dittos/rust-aheui has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dittos/rust-aheui against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dittos/rust-aheui:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0db3d60e0851f762cfde2f29abe2e00138dfee4346b7829a19f3bdc4902cdac1
[INFO] running `"docker" "start" "-a" "0db3d60e0851f762cfde2f29abe2e00138dfee4346b7829a19f3bdc4902cdac1"`
[INFO] [stderr]     Checking rust_aheui v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/space.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 |             width: width,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/space.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             height: height,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mem.rs:123:13
[INFO] [stderr]     |
[INFO] [stderr] 123 |             storages: storages,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `storages`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/space.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 |             width: width,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/space.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             height: height,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mem.rs:123:13
[INFO] [stderr]     |
[INFO] [stderr] 123 |             storages: storages,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `storages`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/mem.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |         return self.data.len();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.data.len()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/mem.rs:99:9
[INFO] [stderr]    |
[INFO] [stderr] 99 |         return self.data.len();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.data.len()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/mem.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |         return self.data.len();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.data.len()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/mem.rs:99:9
[INFO] [stderr]    |
[INFO] [stderr] 99 |         return self.data.len();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.data.len()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/mem.rs:136:34
[INFO] [stderr]     |
[INFO] [stderr] 136 |     fn current_storage(&self) -> &Box<Storage> {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^ help: try: `&Storage`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/mem.rs:140:42
[INFO] [stderr]     |
[INFO] [stderr] 140 |     fn current_storage_mut(&mut self) -> &mut Box<Storage> {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^ help: try: `&mut Storage`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/exec.rs:89:34
[INFO] [stderr]    |
[INFO] [stderr] 89 |             Dir::Set(sx, sy) => (sx as i32, sy as i32),
[INFO] [stderr]    |                                  ^^^^^^^^^ help: try: `i32::from(sx)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/exec.rs:89:45
[INFO] [stderr]    |
[INFO] [stderr] 89 |             Dir::Set(sx, sy) => (sx as i32, sy as i32),
[INFO] [stderr]    |                                             ^^^^^^^^^ help: try: `i32::from(sy)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/mem.rs:136:34
[INFO] [stderr]     |
[INFO] [stderr] 136 |     fn current_storage(&self) -> &Box<Storage> {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^ help: try: `&Storage`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/mem.rs:140:42
[INFO] [stderr]     |
[INFO] [stderr] 140 |     fn current_storage_mut(&mut self) -> &mut Box<Storage> {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^ help: try: `&mut Storage`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/exec.rs:89:34
[INFO] [stderr]    |
[INFO] [stderr] 89 |             Dir::Set(sx, sy) => (sx as i32, sy as i32),
[INFO] [stderr]    |                                  ^^^^^^^^^ help: try: `i32::from(sx)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/exec.rs:89:45
[INFO] [stderr]    |
[INFO] [stderr] 89 |             Dir::Set(sx, sy) => (sx as i32, sy as i32),
[INFO] [stderr]    |                                             ^^^^^^^^^ help: try: `i32::from(sy)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.90s
[INFO] running `"docker" "inspect" "0db3d60e0851f762cfde2f29abe2e00138dfee4346b7829a19f3bdc4902cdac1"`
[INFO] running `"docker" "rm" "-f" "0db3d60e0851f762cfde2f29abe2e00138dfee4346b7829a19f3bdc4902cdac1"`
[INFO] [stdout] 0db3d60e0851f762cfde2f29abe2e00138dfee4346b7829a19f3bdc4902cdac1