[INFO] updating cached repository dholroyd/bungling-mutant-lisp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dholroyd/bungling-mutant-lisp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dholroyd/bungling-mutant-lisp" "work/ex/clippy-test-run/sources/stable/gh/dholroyd/bungling-mutant-lisp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dholroyd/bungling-mutant-lisp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dholroyd/bungling-mutant-lisp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dholroyd/bungling-mutant-lisp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dholroyd/bungling-mutant-lisp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9e925d04ab225fd6e33f452eddb73fcba91aad67 [INFO] sha for GitHub repo dholroyd/bungling-mutant-lisp: 9e925d04ab225fd6e33f452eddb73fcba91aad67 [INFO] validating manifest of dholroyd/bungling-mutant-lisp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dholroyd/bungling-mutant-lisp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dholroyd/bungling-mutant-lisp [INFO] finished frobbing dholroyd/bungling-mutant-lisp [INFO] frobbed toml for dholroyd/bungling-mutant-lisp written to work/ex/clippy-test-run/sources/stable/gh/dholroyd/bungling-mutant-lisp/Cargo.toml [INFO] started frobbing dholroyd/bungling-mutant-lisp [INFO] finished frobbing dholroyd/bungling-mutant-lisp [INFO] frobbed toml for dholroyd/bungling-mutant-lisp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dholroyd/bungling-mutant-lisp/Cargo.toml [INFO] crate dholroyd/bungling-mutant-lisp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dholroyd/bungling-mutant-lisp against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dholroyd/bungling-mutant-lisp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba6bbf074957983d96fc66ca70af20a72bfcfbe2ea3859e46a3ab08f098d6a6b [INFO] running `"docker" "start" "-a" "ba6bbf074957983d96fc66ca70af20a72bfcfbe2ea3859e46a3ab08f098d6a6b"` [INFO] [stderr] Checking bml v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | st: st, [INFO] [stderr] | ^^^^^^ help: replace it with: `st` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpret.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | parent: parent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpret.rs:244:75 [INFO] [stderr] | [INFO] [stderr] 244 | env.vars.borrow_mut().insert(name.clone(), Data::DFun(Fun::Native{name: name, code: Rc::new(Box::new(c))})); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | st: st, [INFO] [stderr] | ^^^^^^ help: replace it with: `st` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpret.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | parent: parent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpret.rs:244:75 [INFO] [stderr] | [INFO] [stderr] 244 | env.vars.borrow_mut().insert(name.clone(), Data::DFun(Fun::Native{name: name, code: Rc::new(Box::new(c))})); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: private type `interpret::Fun` in public interface (error E0446) [INFO] [stderr] --> src/interpret.rs:55:10 [INFO] [stderr] | [INFO] [stderr] 55 | DFun(Fun), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/parse.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | let c = self.next().unwrap(); [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/interpret.rs:28:31 [INFO] [stderr] | [INFO] [stderr] 28 | (&Fun::Native{ref name, ref code}, &Fun::Native{name:ref othername, code:ref othercode}) => { [INFO] [stderr] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `othername` [INFO] [stderr] --> src/interpret.rs:28:70 [INFO] [stderr] | [INFO] [stderr] 28 | (&Fun::Native{ref name, ref code}, &Fun::Native{name:ref othername, code:ref othercode}) => { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_othername` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/interpret.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | Fun::Native{ref name, ref code} => (code)(args), [INFO] [stderr] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stderr] [INFO] [stderr] warning: private type `interpret::Fun` in public interface (error E0446) [INFO] [stderr] --> src/interpret.rs:55:10 [INFO] [stderr] | [INFO] [stderr] 55 | DFun(Fun), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/parse.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | let c = self.next().unwrap(); [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/interpret.rs:28:31 [INFO] [stderr] | [INFO] [stderr] 28 | (&Fun::Native{ref name, ref code}, &Fun::Native{name:ref othername, code:ref othercode}) => { [INFO] [stderr] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `othername` [INFO] [stderr] --> src/interpret.rs:28:70 [INFO] [stderr] | [INFO] [stderr] 28 | (&Fun::Native{ref name, ref code}, &Fun::Native{name:ref othername, code:ref othercode}) => { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_othername` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/interpret.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | Fun::Native{ref name, ref code} => (code)(args), [INFO] [stderr] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parse.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | let mut p = Parser::new(st, text.chars().peekable()); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `skip_comment` [INFO] [stderr] --> src/parse.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | fn skip_comment(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/parse.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | self.i.borrow_mut().peek().map(|c| *c) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.i.borrow_mut().peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/symtable.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | self.name_to_sym.borrow().get(name).map(|s| s.clone() ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.name_to_sym.borrow().get(name).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpret.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match self { [INFO] [stderr] 19 | | &Fun::Native{ref name, ..} => write!(f, "Fun::Native {{ name: {:?}, code: .. }}", name), [INFO] [stderr] 20 | | &Fun::User{..} => write!(f, "Fun::User {{ .. }}"), [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *self { [INFO] [stderr] 19 | Fun::Native{ref name, ..} => write!(f, "Fun::Native {{ name: {:?}, code: .. }}", name), [INFO] [stderr] 20 | Fun::User{..} => write!(f, "Fun::User {{ .. }}"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpret.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | / match s { [INFO] [stderr] 91 | | &Data::DExp(ref s) => self.eval_sexp(s), [INFO] [stderr] 92 | | _ => panic!("not able to evaluate {:?}", s) [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 90 | match *s { [INFO] [stderr] 91 | Data::DExp(ref s) => self.eval_sexp(s), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/interpret.rs:96:38 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn eval_expressions(&self, l:&Vec) -> Data { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[SExp]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpret.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | / match s { [INFO] [stderr] 102 | | &SExp::List(ref l) => self.list(l), [INFO] [stderr] 103 | | &SExp::Num(ref n) => Data::DExp(SExp::Num(*n)), [INFO] [stderr] 104 | | &SExp::LString(ref s) => Data::DExp(SExp::LString(s.clone())), [INFO] [stderr] ... | [INFO] [stderr] 107 | | _ => panic!("not able to evaluate {:?}", s) [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 101 | match *s { [INFO] [stderr] 102 | SExp::List(ref l) => self.list(l), [INFO] [stderr] 103 | SExp::Num(ref n) => Data::DExp(SExp::Num(*n)), [INFO] [stderr] 104 | SExp::LString(ref s) => Data::DExp(SExp::LString(s.clone())), [INFO] [stderr] 105 | SExp::Boolean(ref b) => Data::DExp(SExp::Boolean(*b)), [INFO] [stderr] 106 | SExp::Sym(ref b) => self.lookup(b), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/interpret.rs:111:22 [INFO] [stderr] | [INFO] [stderr] 111 | fn list(&self, l:&Vec) -> Data { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[SExp]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the `other @ _` pattern can be written as just `other` [INFO] [stderr] --> src/interpret.rs:126:18 [INFO] [stderr] | [INFO] [stderr] 126 | Some(other @ _) => panic!("expected symbol, found {:?}", other) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: method is never used: `skip_comment` [INFO] [stderr] --> src/parse.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | fn skip_comment(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/parse.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | self.i.borrow_mut().peek().map(|c| *c) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.i.borrow_mut().peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/builtin.rs:103:12 [INFO] [stderr] | [INFO] [stderr] 103 | if args.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/builtin.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / match &args[0] { [INFO] [stderr] 107 | | &Data::DExp(SExp::Boolean(a)) => Data::DExp(SExp::Boolean(!a)), [INFO] [stderr] 108 | | _ => panic!("invalid arguments for 'not'") [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 106 | match args[0] { [INFO] [stderr] 107 | Data::DExp(SExp::Boolean(a)) => Data::DExp(SExp::Boolean(!a)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/symtable.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | self.name_to_sym.borrow().get(name).map(|s| s.clone() ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.name_to_sym.borrow().get(name).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/symtable.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | let foo = st.sym_for("foo"); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/symtable.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | let bar = st.sym_for("bar"); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpret.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match self { [INFO] [stderr] 19 | | &Fun::Native{ref name, ..} => write!(f, "Fun::Native {{ name: {:?}, code: .. }}", name), [INFO] [stderr] 20 | | &Fun::User{..} => write!(f, "Fun::User {{ .. }}"), [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *self { [INFO] [stderr] 19 | Fun::Native{ref name, ..} => write!(f, "Fun::Native {{ name: {:?}, code: .. }}", name), [INFO] [stderr] 20 | Fun::User{..} => write!(f, "Fun::User {{ .. }}"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpret.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | / match s { [INFO] [stderr] 91 | | &Data::DExp(ref s) => self.eval_sexp(s), [INFO] [stderr] 92 | | _ => panic!("not able to evaluate {:?}", s) [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 90 | match *s { [INFO] [stderr] 91 | Data::DExp(ref s) => self.eval_sexp(s), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/interpret.rs:96:38 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn eval_expressions(&self, l:&Vec) -> Data { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[SExp]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpret.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | / match s { [INFO] [stderr] 102 | | &SExp::List(ref l) => self.list(l), [INFO] [stderr] 103 | | &SExp::Num(ref n) => Data::DExp(SExp::Num(*n)), [INFO] [stderr] 104 | | &SExp::LString(ref s) => Data::DExp(SExp::LString(s.clone())), [INFO] [stderr] ... | [INFO] [stderr] 107 | | _ => panic!("not able to evaluate {:?}", s) [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 101 | match *s { [INFO] [stderr] 102 | SExp::List(ref l) => self.list(l), [INFO] [stderr] 103 | SExp::Num(ref n) => Data::DExp(SExp::Num(*n)), [INFO] [stderr] 104 | SExp::LString(ref s) => Data::DExp(SExp::LString(s.clone())), [INFO] [stderr] 105 | SExp::Boolean(ref b) => Data::DExp(SExp::Boolean(*b)), [INFO] [stderr] 106 | SExp::Sym(ref b) => self.lookup(b), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/interpret.rs:111:22 [INFO] [stderr] | [INFO] [stderr] 111 | fn list(&self, l:&Vec) -> Data { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[SExp]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the `other @ _` pattern can be written as just `other` [INFO] [stderr] --> src/interpret.rs:126:18 [INFO] [stderr] | [INFO] [stderr] 126 | Some(other @ _) => panic!("expected symbol, found {:?}", other) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/builtin.rs:103:12 [INFO] [stderr] | [INFO] [stderr] 103 | if args.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/builtin.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / match &args[0] { [INFO] [stderr] 107 | | &Data::DExp(SExp::Boolean(a)) => Data::DExp(SExp::Boolean(!a)), [INFO] [stderr] 108 | | _ => panic!("invalid arguments for 'not'") [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 106 | match args[0] { [INFO] [stderr] 107 | Data::DExp(SExp::Boolean(a)) => Data::DExp(SExp::Boolean(!a)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.74s [INFO] running `"docker" "inspect" "ba6bbf074957983d96fc66ca70af20a72bfcfbe2ea3859e46a3ab08f098d6a6b"` [INFO] running `"docker" "rm" "-f" "ba6bbf074957983d96fc66ca70af20a72bfcfbe2ea3859e46a3ab08f098d6a6b"` [INFO] [stdout] ba6bbf074957983d96fc66ca70af20a72bfcfbe2ea3859e46a3ab08f098d6a6b