[INFO] updating cached repository dhartunian/advent-of-code-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dhartunian/advent-of-code-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dhartunian/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/dhartunian/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dhartunian/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dhartunian/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dhartunian/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dhartunian/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d363a0f1893e363a84667c3dcea32459954dfbfb [INFO] sha for GitHub repo dhartunian/advent-of-code-2018: d363a0f1893e363a84667c3dcea32459954dfbfb [INFO] validating manifest of dhartunian/advent-of-code-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dhartunian/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dhartunian/advent-of-code-2018 [INFO] finished frobbing dhartunian/advent-of-code-2018 [INFO] frobbed toml for dhartunian/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/dhartunian/advent-of-code-2018/Cargo.toml [INFO] started frobbing dhartunian/advent-of-code-2018 [INFO] finished frobbing dhartunian/advent-of-code-2018 [INFO] frobbed toml for dhartunian/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dhartunian/advent-of-code-2018/Cargo.toml [INFO] crate dhartunian/advent-of-code-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dhartunian/advent-of-code-2018 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dhartunian/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f624489142b7eb6c89f11db40d1d4c05259b442950ab246f751fbc4e4800c600 [INFO] running `"docker" "start" "-a" "f624489142b7eb6c89f11db40d1d4c05259b442950ab246f751fbc4e4800c600"` [INFO] [stderr] Checking advent-of-code-2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | / return word1.chars() [INFO] [stderr] 120 | | .zip(word2.chars()) [INFO] [stderr] 121 | | .filter(|x| { [INFO] [stderr] 122 | | match x { [INFO] [stderr] ... | [INFO] [stderr] 127 | | }) [INFO] [stderr] 128 | | .count() == 1; [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 119 | word1.chars() [INFO] [stderr] 120 | .zip(word2.chars()) [INFO] [stderr] 121 | .filter(|x| { [INFO] [stderr] 122 | match x { [INFO] [stderr] 123 | (y,z) => { [INFO] [stderr] 124 | y != z [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | return counts; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `counts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | / return word1.chars() [INFO] [stderr] 120 | | .zip(word2.chars()) [INFO] [stderr] 121 | | .filter(|x| { [INFO] [stderr] 122 | | match x { [INFO] [stderr] ... | [INFO] [stderr] 127 | | }) [INFO] [stderr] 128 | | .count() == 1; [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 119 | word1.chars() [INFO] [stderr] 120 | .zip(word2.chars()) [INFO] [stderr] 121 | .filter(|x| { [INFO] [stderr] 122 | match x { [INFO] [stderr] 123 | (y,z) => { [INFO] [stderr] 124 | y != z [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | return counts; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `counts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `char_difference` [INFO] [stderr] --> src/main.rs:118:1 [INFO] [stderr] | [INFO] [stderr] 118 | fn char_difference(word1 : &String, word2 : &String) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_letter_counts` [INFO] [stderr] --> src/main.rs:158:1 [INFO] [stderr] | [INFO] [stderr] 158 | fn get_letter_counts(word: &str) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | / match hashy.get(&(x,y)) { [INFO] [stderr] 45 | | Some(x) => { [INFO] [stderr] 46 | | if *x > 1 { [INFO] [stderr] 47 | | is_overlapping = true; [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(x) = hashy.get(&(x,y)) { [INFO] [stderr] 45 | if *x > 1 { [INFO] [stderr] 46 | is_overlapping = true; [INFO] [stderr] 47 | } [INFO] [stderr] 48 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | if is_overlapping == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!is_overlapping` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:118:28 [INFO] [stderr] | [INFO] [stderr] 118 | fn char_difference(word1 : &String, word2 : &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:118:45 [INFO] [stderr] | [INFO] [stderr] 118 | fn char_difference(word1 : &String, word2 : &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function is never used: `char_difference` [INFO] [stderr] --> src/main.rs:118:1 [INFO] [stderr] | [INFO] [stderr] 118 | fn char_difference(word1 : &String, word2 : &String) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_letter_counts` [INFO] [stderr] --> src/main.rs:158:1 [INFO] [stderr] | [INFO] [stderr] 158 | fn get_letter_counts(word: &str) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | / match hashy.get(&(x,y)) { [INFO] [stderr] 45 | | Some(x) => { [INFO] [stderr] 46 | | if *x > 1 { [INFO] [stderr] 47 | | is_overlapping = true; [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(x) = hashy.get(&(x,y)) { [INFO] [stderr] 45 | if *x > 1 { [INFO] [stderr] 46 | is_overlapping = true; [INFO] [stderr] 47 | } [INFO] [stderr] 48 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | if is_overlapping == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!is_overlapping` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:118:28 [INFO] [stderr] | [INFO] [stderr] 118 | fn char_difference(word1 : &String, word2 : &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:118:45 [INFO] [stderr] | [INFO] [stderr] 118 | fn char_difference(word1 : &String, word2 : &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.93s [INFO] running `"docker" "inspect" "f624489142b7eb6c89f11db40d1d4c05259b442950ab246f751fbc4e4800c600"` [INFO] running `"docker" "rm" "-f" "f624489142b7eb6c89f11db40d1d4c05259b442950ab246f751fbc4e4800c600"` [INFO] [stdout] f624489142b7eb6c89f11db40d1d4c05259b442950ab246f751fbc4e4800c600