[INFO] updating cached repository dgoetsch/glutton [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dgoetsch/glutton [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dgoetsch/glutton" "work/ex/clippy-test-run/sources/stable/gh/dgoetsch/glutton"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dgoetsch/glutton'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dgoetsch/glutton" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgoetsch/glutton"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgoetsch/glutton'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b1bc70e964c18f6818a90b4e4ff98afa54c907a9 [INFO] sha for GitHub repo dgoetsch/glutton: b1bc70e964c18f6818a90b4e4ff98afa54c907a9 [INFO] validating manifest of dgoetsch/glutton on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dgoetsch/glutton on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dgoetsch/glutton [INFO] finished frobbing dgoetsch/glutton [INFO] frobbed toml for dgoetsch/glutton written to work/ex/clippy-test-run/sources/stable/gh/dgoetsch/glutton/Cargo.toml [INFO] started frobbing dgoetsch/glutton [INFO] finished frobbing dgoetsch/glutton [INFO] frobbed toml for dgoetsch/glutton written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgoetsch/glutton/Cargo.toml [INFO] crate dgoetsch/glutton has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dgoetsch/glutton against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgoetsch/glutton:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2ad4c1fa43c928997056073f1250eb8f949d87f212f27d9f5adc9bbae2adaf86 [INFO] running `"docker" "start" "-a" "2ad4c1fa43c928997056073f1250eb8f949d87f212f27d9f5adc9bbae2adaf86"` [INFO] [stderr] Checking rust-by-ex v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:62:38 [INFO] [stderr] | [INFO] [stderr] 62 | Glutton { dir: new_path, at_a_time: at_a_time}.consume() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `at_a_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:62:38 [INFO] [stderr] | [INFO] [stderr] 62 | Glutton { dir: new_path, at_a_time: at_a_time}.consume() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `at_a_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::Map` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::iter::Map; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/main.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | for idx in (0..self.at_a_time) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return handler [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `handler` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::Rng::gen_ascii_chars': use sample_iter(&Alphanumeric) instead [INFO] [stderr] --> src/main.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | let name = thread_rng().gen_ascii_chars().take(10) .collect::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::Map` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::iter::Map; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/main.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | for idx in (0..self.at_a_time) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return handler [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `handler` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/main.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | for idx in (0..self.at_a_time) { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cd_res` [INFO] [stderr] --> src/main.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | let cd_res = std::fs::create_dir_all(sub_dir.as_str()); [INFO] [stderr] | ^^^^^^ help: consider using `_cd_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cf_res` [INFO] [stderr] --> src/main.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | let cf_res = std::fs::File::create(file_name.as_str()) [INFO] [stderr] | ^^^^^^ help: consider using `_cf_res` instead [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::Rng::gen_ascii_chars': use sample_iter(&Alphanumeric) instead [INFO] [stderr] --> src/main.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | let name = thread_rng().gen_ascii_chars().take(10) .collect::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | handler.join(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/main.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | for idx in (0..self.at_a_time) { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cd_res` [INFO] [stderr] --> src/main.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | let cd_res = std::fs::create_dir_all(sub_dir.as_str()); [INFO] [stderr] | ^^^^^^ help: consider using `_cd_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cf_res` [INFO] [stderr] --> src/main.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | let cf_res = std::fs::File::create(file_name.as_str()) [INFO] [stderr] | ^^^^^^ help: consider using `_cf_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | handler.join(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `"docker" "inspect" "2ad4c1fa43c928997056073f1250eb8f949d87f212f27d9f5adc9bbae2adaf86"` [INFO] running `"docker" "rm" "-f" "2ad4c1fa43c928997056073f1250eb8f949d87f212f27d9f5adc9bbae2adaf86"` [INFO] [stdout] 2ad4c1fa43c928997056073f1250eb8f949d87f212f27d9f5adc9bbae2adaf86