[INFO] updating cached repository devonhollowood/brainstorm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/devonhollowood/brainstorm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/devonhollowood/brainstorm" "work/ex/clippy-test-run/sources/stable/gh/devonhollowood/brainstorm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/devonhollowood/brainstorm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/devonhollowood/brainstorm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/devonhollowood/brainstorm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/devonhollowood/brainstorm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6c2b089901d19c94ab35d9f29537d9dc3846b569 [INFO] sha for GitHub repo devonhollowood/brainstorm: 6c2b089901d19c94ab35d9f29537d9dc3846b569 [INFO] validating manifest of devonhollowood/brainstorm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of devonhollowood/brainstorm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing devonhollowood/brainstorm [INFO] finished frobbing devonhollowood/brainstorm [INFO] frobbed toml for devonhollowood/brainstorm written to work/ex/clippy-test-run/sources/stable/gh/devonhollowood/brainstorm/Cargo.toml [INFO] started frobbing devonhollowood/brainstorm [INFO] finished frobbing devonhollowood/brainstorm [INFO] frobbed toml for devonhollowood/brainstorm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/devonhollowood/brainstorm/Cargo.toml [INFO] crate devonhollowood/brainstorm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting devonhollowood/brainstorm against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/devonhollowood/brainstorm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3c5fcac50cf33f4bdda4134283dded0d6155221b46400b19d2fdf36ecb8c73b5 [INFO] running `"docker" "start" "-a" "3c5fcac50cf33f4bdda4134283dded0d6155221b46400b19d2fdf36ecb8c73b5"` [INFO] [stderr] Checking brainstorm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainstorm/lexer/mod.rs:9:15 [INFO] [stderr] | [INFO] [stderr] 9 | Token{token_type: token_type, position: position} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainstorm/lexer/mod.rs:9:39 [INFO] [stderr] | [INFO] [stderr] 9 | Token{token_type: token_type, position: position} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainstorm/lexer/mod.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | Position {line: line, column: column} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainstorm/lexer/mod.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | Position {line: line, column: column} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainstorm/lexer/mod.rs:103:31 [INFO] [stderr] | [INFO] [stderr] 103 | return Some(Token{token_type: token_type, position: position}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainstorm/lexer/mod.rs:103:55 [INFO] [stderr] | [INFO] [stderr] 103 | return Some(Token{token_type: token_type, position: position}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainstorm/lexer/mod.rs:9:15 [INFO] [stderr] | [INFO] [stderr] 9 | Token{token_type: token_type, position: position} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainstorm/lexer/mod.rs:9:39 [INFO] [stderr] | [INFO] [stderr] 9 | Token{token_type: token_type, position: position} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainstorm/lexer/mod.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | Position {line: line, column: column} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainstorm/lexer/mod.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | Position {line: line, column: column} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainstorm/lexer/mod.rs:103:31 [INFO] [stderr] | [INFO] [stderr] 103 | return Some(Token{token_type: token_type, position: position}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainstorm/lexer/mod.rs:103:55 [INFO] [stderr] | [INFO] [stderr] 103 | return Some(Token{token_type: token_type, position: position}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/brainstorm/lexer/mod.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | self.token_type.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.token_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/brainstorm/lexer/mod.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | self.token_type.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.token_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.78s [INFO] running `"docker" "inspect" "3c5fcac50cf33f4bdda4134283dded0d6155221b46400b19d2fdf36ecb8c73b5"` [INFO] running `"docker" "rm" "-f" "3c5fcac50cf33f4bdda4134283dded0d6155221b46400b19d2fdf36ecb8c73b5"` [INFO] [stdout] 3c5fcac50cf33f4bdda4134283dded0d6155221b46400b19d2fdf36ecb8c73b5