[INFO] updating cached repository devoidfury/rust-shell
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/devoidfury/rust-shell
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/devoidfury/rust-shell" "work/ex/clippy-test-run/sources/stable/gh/devoidfury/rust-shell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/devoidfury/rust-shell'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/devoidfury/rust-shell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/devoidfury/rust-shell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/devoidfury/rust-shell'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] da457708afa5a77f4d85c8154c77d3dfaf2ffda6
[INFO] sha for GitHub repo devoidfury/rust-shell: da457708afa5a77f4d85c8154c77d3dfaf2ffda6
[INFO] validating manifest of devoidfury/rust-shell on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of devoidfury/rust-shell on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing devoidfury/rust-shell
[INFO] finished frobbing devoidfury/rust-shell
[INFO] frobbed toml for devoidfury/rust-shell written to work/ex/clippy-test-run/sources/stable/gh/devoidfury/rust-shell/Cargo.toml
[INFO] started frobbing devoidfury/rust-shell
[INFO] finished frobbing devoidfury/rust-shell
[INFO] frobbed toml for devoidfury/rust-shell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/devoidfury/rust-shell/Cargo.toml
[INFO] crate devoidfury/rust-shell has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting devoidfury/rust-shell against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/devoidfury/rust-shell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e41a0d7753da3c7e2487c09c17db12130e91db4faf8528dc4f118c86fcad28e3
[INFO] running `"docker" "start" "-a" "e41a0d7753da3c7e2487c09c17db12130e91db4faf8528dc4f118c86fcad28e3"`
[INFO] [stderr]     Checking rash v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rash.rs:31:4
[INFO] [stderr]    |
[INFO] [stderr] 31 |             context: context,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `context`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rash.rs:33:4
[INFO] [stderr]    |
[INFO] [stderr] 33 |             interactive: interactive
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interactive`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rash.rs:31:4
[INFO] [stderr]    |
[INFO] [stderr] 31 |             context: context,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `context`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rash.rs:33:4
[INFO] [stderr]    |
[INFO] [stderr] 33 |             interactive: interactive
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interactive`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/rash.rs:14:20
[INFO] [stderr]    |
[INFO] [stderr] 14 | const SHELL_NAME: &'static str = "rash";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/rash.rs:14:20
[INFO] [stderr]    |
[INFO] [stderr] 14 | const SHELL_NAME: &'static str = "rash";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `rash::Rash`
[INFO] [stderr]   --> src/rash.rs:27:2
[INFO] [stderr]    |
[INFO] [stderr] 27 |       pub fn new() -> Rash {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 28 | |         let context = HashMap::new();
[INFO] [stderr] 29 | |         let interactive = isatty(libc::STDIN_FILENO);
[INFO] [stderr] 30 | |         Rash {
[INFO] [stderr] ...  |
[INFO] [stderr] 34 | |         }
[INFO] [stderr] 35 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 20 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `rash::Rash`
[INFO] [stderr]   --> src/rash.rs:27:2
[INFO] [stderr]    |
[INFO] [stderr] 27 |       pub fn new() -> Rash {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 28 | |         let context = HashMap::new();
[INFO] [stderr] 29 | |         let interactive = isatty(libc::STDIN_FILENO);
[INFO] [stderr] 30 | |         Rash {
[INFO] [stderr] ...  |
[INFO] [stderr] 34 | |         }
[INFO] [stderr] 35 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 20 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/rash.rs:97:29
[INFO] [stderr]    |
[INFO] [stderr] 97 |         while let Some(nextarg) = args.next() {
[INFO] [stderr]    |                                   ^^^^^^^^^^^ help: try: `for nextarg in args { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/rash.rs:97:29
[INFO] [stderr]    |
[INFO] [stderr] 97 |         while let Some(nextarg) = args.next() {
[INFO] [stderr]    |                                   ^^^^^^^^^^^ help: try: `for nextarg in args { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/rash.rs:211:52
[INFO] [stderr]     |
[INFO] [stderr] 211 |         let mut raw_args: Vec<&str> = input.trim().split(" ").collect();
[INFO] [stderr]     |                                                          ^^^ help: try using a char instead: `' '`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/rash.rs:211:52
[INFO] [stderr]     |
[INFO] [stderr] 211 |         let mut raw_args: Vec<&str> = input.trim().split(" ").collect();
[INFO] [stderr]     |                                                          ^^^ help: try using a char instead: `' '`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/rash.rs:215:6
[INFO] [stderr]     |
[INFO] [stderr] 215 |         if raw_args.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!raw_args.is_empty()`
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/rash.rs:215:6
[INFO] [stderr]     |
[INFO] [stderr] 215 |         if raw_args.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!raw_args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/main.rs:28:6
[INFO] [stderr]    |
[INFO] [stderr] 28 |         if input.len() < 1 { continue }
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/main.rs:28:6
[INFO] [stderr]    |
[INFO] [stderr] 28 |         if input.len() < 1 { continue }
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.34s
[INFO] running `"docker" "inspect" "e41a0d7753da3c7e2487c09c17db12130e91db4faf8528dc4f118c86fcad28e3"`
[INFO] running `"docker" "rm" "-f" "e41a0d7753da3c7e2487c09c17db12130e91db4faf8528dc4f118c86fcad28e3"`
[INFO] [stdout] e41a0d7753da3c7e2487c09c17db12130e91db4faf8528dc4f118c86fcad28e3