[INFO] updating cached repository devkmsg/logpush [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/devkmsg/logpush [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/devkmsg/logpush" "work/ex/clippy-test-run/sources/stable/gh/devkmsg/logpush"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/devkmsg/logpush'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/devkmsg/logpush" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/devkmsg/logpush"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/devkmsg/logpush'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d48543b165ae07ac0cb50c92677d16b4e5c85c68 [INFO] sha for GitHub repo devkmsg/logpush: d48543b165ae07ac0cb50c92677d16b4e5c85c68 [INFO] validating manifest of devkmsg/logpush on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of devkmsg/logpush on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing devkmsg/logpush [INFO] finished frobbing devkmsg/logpush [INFO] frobbed toml for devkmsg/logpush written to work/ex/clippy-test-run/sources/stable/gh/devkmsg/logpush/Cargo.toml [INFO] started frobbing devkmsg/logpush [INFO] finished frobbing devkmsg/logpush [INFO] frobbed toml for devkmsg/logpush written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/devkmsg/logpush/Cargo.toml [INFO] crate devkmsg/logpush has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting devkmsg/logpush against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/devkmsg/logpush:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 344a681badb6dcd8150742ac8867af4f6d97983497a12f5afe36292f4adda417 [INFO] running `"docker" "start" "-a" "344a681badb6dcd8150742ac8867af4f6d97983497a12f5afe36292f4adda417"` [INFO] [stderr] Checking term_size v0.2.3 [INFO] [stderr] Checking sha1 v0.1.1 [INFO] [stderr] Checking idna v0.1.2 [INFO] [stderr] Checking clap v2.19.3 [INFO] [stderr] Checking url v1.5.1 [INFO] [stderr] Checking redis v0.5.4 [INFO] [stderr] Checking logpush v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | max_bulk_size: max_bulk_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_bulk_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | max_bulk_interval_secs: max_bulk_interval_secs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_bulk_interval_secs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redis.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | key: key [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | max_bulk_size: max_bulk_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_bulk_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | max_bulk_interval_secs: max_bulk_interval_secs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_bulk_interval_secs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redis.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | key: key [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:29:12 [INFO] [stderr] | [INFO] [stderr] 29 | if con.key_exists() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `con.key_exists()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:29:12 [INFO] [stderr] | [INFO] [stderr] 29 | if con.key_exists() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `con.key_exists()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.50s [INFO] running `"docker" "inspect" "344a681badb6dcd8150742ac8867af4f6d97983497a12f5afe36292f4adda417"` [INFO] running `"docker" "rm" "-f" "344a681badb6dcd8150742ac8867af4f6d97983497a12f5afe36292f4adda417"` [INFO] [stdout] 344a681badb6dcd8150742ac8867af4f6d97983497a12f5afe36292f4adda417