[INFO] updating cached repository ddrmanxbxfr/rustynes
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ddrmanxbxfr/rustynes
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ddrmanxbxfr/rustynes" "work/ex/clippy-test-run/sources/stable/gh/ddrmanxbxfr/rustynes"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ddrmanxbxfr/rustynes'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ddrmanxbxfr/rustynes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ddrmanxbxfr/rustynes"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ddrmanxbxfr/rustynes'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6bf51e6c33837ef846fb82eecec0fb7b300c996a
[INFO] sha for GitHub repo ddrmanxbxfr/rustynes: 6bf51e6c33837ef846fb82eecec0fb7b300c996a
[INFO] validating manifest of ddrmanxbxfr/rustynes on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ddrmanxbxfr/rustynes on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ddrmanxbxfr/rustynes
[INFO] finished frobbing ddrmanxbxfr/rustynes
[INFO] frobbed toml for ddrmanxbxfr/rustynes written to work/ex/clippy-test-run/sources/stable/gh/ddrmanxbxfr/rustynes/Cargo.toml
[INFO] started frobbing ddrmanxbxfr/rustynes
[INFO] finished frobbing ddrmanxbxfr/rustynes
[INFO] frobbed toml for ddrmanxbxfr/rustynes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ddrmanxbxfr/rustynes/Cargo.toml
[INFO] crate ddrmanxbxfr/rustynes has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ddrmanxbxfr/rustynes against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ddrmanxbxfr/rustynes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cc576d6950389fc9f156f530533367ed5b5f693bbc19b886393c2b71d7a85010
[INFO] running `"docker" "start" "-a" "cc576d6950389fc9f156f530533367ed5b5f693bbc19b886393c2b71d7a85010"`
[INFO] [stderr]     Checking rustynes v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/console/flag_6.rs:90:13
[INFO] [stderr]     |
[INFO] [stderr] 90  | /             return Flag6 {
[INFO] [stderr] 91  | |                 nes_mapper: mapper,
[INFO] [stderr] 92  | |                 four_screen_mode: byte::extract_bit(flag_value, Flag6BitPosition::FourScreenMode.value()) == 1,
[INFO] [stderr] 93  | |                 trainer_mode: byte::extract_bit(flag_value, Flag6BitPosition::TrainerMode.value()) == 1,
[INFO] [stderr] ...   |
[INFO] [stderr] 99  | |                 }
[INFO] [stderr] 100 | |             }        
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 90  |             Flag6 {
[INFO] [stderr] 91  |                 nes_mapper: mapper,
[INFO] [stderr] 92  |                 four_screen_mode: byte::extract_bit(flag_value, Flag6BitPosition::FourScreenMode.value()) == 1,
[INFO] [stderr] 93  |                 trainer_mode: byte::extract_bit(flag_value, Flag6BitPosition::TrainerMode.value()) == 1,
[INFO] [stderr] 94  |                 sram_battery_backed: byte::extract_bit(flag_value, Flag6BitPosition::SramBatteryBacked.value()) == 1,
[INFO] [stderr] 95  |                 mirroring: match byte::extract_bit(flag_value, Flag6BitPosition::Mirroring.value()) {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::str`
[INFO] [stderr]  --> src/console/cartridge.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::str;
[INFO] [stderr]   |     ^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `console::flag_6`
[INFO] [stderr]  --> src/console/cartridge.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | use console::flag_6;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/console/cartridge.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |     return Ok(buffer);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/console/cartridge.rs:48:13
[INFO] [stderr]    |
[INFO] [stderr] 48 |             return rom_data;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rom_data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/console/cartridge.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return CartridgeData { header: headers, prg_bank: Vec::from(prg_data), chr_bank: Vec::from(chr_data) };
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CartridgeData { header: headers, prg_bank: Vec::from(prg_data), chr_bank: Vec::from(chr_data) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/console/rom_header.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | /     return RomHeader {
[INFO] [stderr] 49 | |         authenticity_header: Vec::from(nes_header),
[INFO] [stderr] 50 | |         prg_rom_size: u32::from(rom_data[HeaderPosition::PrgRomSize.position()]) * BASE_PRG_BANK_SIZE,
[INFO] [stderr] 51 | |         chr_rom_size: u32::from(rom_data[HeaderPosition::ChrRomSize.position()]) * BASE_CHR_BANK_SIZE,
[INFO] [stderr] ...  |
[INFO] [stderr] 57 | |         flag_10: rom_data[HeaderPosition::Flag10.position()]
[INFO] [stderr] 58 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 48 |     RomHeader {
[INFO] [stderr] 49 |         authenticity_header: Vec::from(nes_header),
[INFO] [stderr] 50 |         prg_rom_size: u32::from(rom_data[HeaderPosition::PrgRomSize.position()]) * BASE_PRG_BANK_SIZE,
[INFO] [stderr] 51 |         chr_rom_size: u32::from(rom_data[HeaderPosition::ChrRomSize.position()]) * BASE_CHR_BANK_SIZE,
[INFO] [stderr] 52 |         flag_6: rom_data[HeaderPosition::Flag6.position()],
[INFO] [stderr] 53 |         parsed_flag_6: flag_6::parse_flag_6(&rom_data[HeaderPosition::Flag6.position()]),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/console/rom_header.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     return &nes_header[0..3];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&nes_header[0..3]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/utils/byte.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 |     return byte.clone() & (1<< (bit_to_extract - 1));
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `byte.clone() & (1<< (bit_to_extract - 1))`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::env`
[INFO] [stderr]  --> src/main.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::env;
[INFO] [stderr]   |     ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/console/flag_6.rs:90:13
[INFO] [stderr]     |
[INFO] [stderr] 90  | /             return Flag6 {
[INFO] [stderr] 91  | |                 nes_mapper: mapper,
[INFO] [stderr] 92  | |                 four_screen_mode: byte::extract_bit(flag_value, Flag6BitPosition::FourScreenMode.value()) == 1,
[INFO] [stderr] 93  | |                 trainer_mode: byte::extract_bit(flag_value, Flag6BitPosition::TrainerMode.value()) == 1,
[INFO] [stderr] ...   |
[INFO] [stderr] 99  | |                 }
[INFO] [stderr] 100 | |             }        
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 90  |             Flag6 {
[INFO] [stderr] 91  |                 nes_mapper: mapper,
[INFO] [stderr] 92  |                 four_screen_mode: byte::extract_bit(flag_value, Flag6BitPosition::FourScreenMode.value()) == 1,
[INFO] [stderr] 93  |                 trainer_mode: byte::extract_bit(flag_value, Flag6BitPosition::TrainerMode.value()) == 1,
[INFO] [stderr] 94  |                 sram_battery_backed: byte::extract_bit(flag_value, Flag6BitPosition::SramBatteryBacked.value()) == 1,
[INFO] [stderr] 95  |                 mirroring: match byte::extract_bit(flag_value, Flag6BitPosition::Mirroring.value()) {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::str`
[INFO] [stderr]  --> src/console/cartridge.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::str;
[INFO] [stderr]   |     ^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `console::flag_6`
[INFO] [stderr]  --> src/console/cartridge.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | use console::flag_6;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/console/cartridge.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |     return Ok(buffer);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/console/cartridge.rs:48:13
[INFO] [stderr]    |
[INFO] [stderr] 48 |             return rom_data;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rom_data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/console/cartridge.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return CartridgeData { header: headers, prg_bank: Vec::from(prg_data), chr_bank: Vec::from(chr_data) };
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CartridgeData { header: headers, prg_bank: Vec::from(prg_data), chr_bank: Vec::from(chr_data) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/console/rom_header.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | /     return RomHeader {
[INFO] [stderr] 49 | |         authenticity_header: Vec::from(nes_header),
[INFO] [stderr] 50 | |         prg_rom_size: u32::from(rom_data[HeaderPosition::PrgRomSize.position()]) * BASE_PRG_BANK_SIZE,
[INFO] [stderr] 51 | |         chr_rom_size: u32::from(rom_data[HeaderPosition::ChrRomSize.position()]) * BASE_CHR_BANK_SIZE,
[INFO] [stderr] ...  |
[INFO] [stderr] 57 | |         flag_10: rom_data[HeaderPosition::Flag10.position()]
[INFO] [stderr] 58 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 48 |     RomHeader {
[INFO] [stderr] 49 |         authenticity_header: Vec::from(nes_header),
[INFO] [stderr] 50 |         prg_rom_size: u32::from(rom_data[HeaderPosition::PrgRomSize.position()]) * BASE_PRG_BANK_SIZE,
[INFO] [stderr] 51 |         chr_rom_size: u32::from(rom_data[HeaderPosition::ChrRomSize.position()]) * BASE_CHR_BANK_SIZE,
[INFO] [stderr] 52 |         flag_6: rom_data[HeaderPosition::Flag6.position()],
[INFO] [stderr] 53 |         parsed_flag_6: flag_6::parse_flag_6(&rom_data[HeaderPosition::Flag6.position()]),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/console/rom_header.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     return &nes_header[0..3];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&nes_header[0..3]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/utils/byte.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 |     return byte.clone() & (1<< (bit_to_extract - 1));
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `byte.clone() & (1<< (bit_to_extract - 1))`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::env`
[INFO] [stderr]  --> src/main.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::env;
[INFO] [stderr]   |     ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `prg_rom_size`
[INFO] [stderr]   --> src/console/rom_header.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let prg_rom_size: u8 = rom_data[HeaderPosition::PrgRomSize.position()];
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: consider using `_prg_rom_size` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `cartridge`
[INFO] [stderr]   --> src/main.rs:13:17
[INFO] [stderr]    |
[INFO] [stderr] 13 |             let cartridge = cartridge::load_content(&value);
[INFO] [stderr]    |                 ^^^^^^^^^ help: consider using `_cartridge` instead
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `value`
[INFO] [stderr]   --> src/console/flag_6.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 |     fn value(&self) -> usize {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `header`
[INFO] [stderr]   --> src/console/cartridge.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     header: rom_header::RomHeader,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `prg_bank`
[INFO] [stderr]   --> src/console/cartridge.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     prg_bank: Vec<u8>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `chr_bank`
[INFO] [stderr]   --> src/console/cartridge.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 |     chr_bank: Vec<u8>
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/console/flag_6.rs:86:33
[INFO] [stderr]    |
[INFO] [stderr] 86 | pub fn parse_flag_6(flag_value: &u8) -> Flag6 {
[INFO] [stderr]    |                                 ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/console/flag_6.rs:87:51
[INFO] [stderr]    |
[INFO] [stderr] 87 |     let nes_mapper = nes_mapper_value_from_flag_6(flag_value.clone());
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*flag_value`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/console/cartridge.rs:33:23
[INFO] [stderr]    |
[INFO] [stderr] 33 | fn read_rom(filename: &String) -> Result<Vec<u8>, io::Error> {
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/console/cartridge.rs:43:31
[INFO] [stderr]    |
[INFO] [stderr] 43 | pub fn load_content(filename: &String) -> CartridgeData {
[INFO] [stderr]    |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/console/cartridge.rs:62:30
[INFO] [stderr]    |
[INFO] [stderr] 62 | pub fn prepare<'a>(rom_data: &Vec<u8>) -> CartridgeData {
[INFO] [stderr]    |                              ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/console/cartridge.rs:62:16
[INFO] [stderr]    |
[INFO] [stderr] 62 | pub fn prepare<'a>(rom_data: &Vec<u8>) -> CartridgeData {
[INFO] [stderr]    |                ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/console/rom_header.rs:44:34
[INFO] [stderr]    |
[INFO] [stderr] 44 | pub fn read_rom_header(rom_data: &Vec<u8>) -> RomHeader {
[INFO] [stderr]    |                                  ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/utils/byte.rs:1:26
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub fn extract_bit(byte: &u8, bit_to_extract: u8) -> u8 {
[INFO] [stderr]   |                          ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]  --> src/utils/byte.rs:2:12
[INFO] [stderr]   |
[INFO] [stderr] 2 |     return byte.clone() & (1<< (bit_to_extract - 1));
[INFO] [stderr]   |            ^^^^^^^^^^^^ help: try dereferencing it: `*byte`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `prg_rom_size`
[INFO] [stderr]   --> src/console/rom_header.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let prg_rom_size: u8 = rom_data[HeaderPosition::PrgRomSize.position()];
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: consider using `_prg_rom_size` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `cartridge`
[INFO] [stderr]   --> src/main.rs:13:17
[INFO] [stderr]    |
[INFO] [stderr] 13 |             let cartridge = cartridge::load_content(&value);
[INFO] [stderr]    |                 ^^^^^^^^^ help: consider using `_cartridge` instead
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `value`
[INFO] [stderr]   --> src/console/flag_6.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 |     fn value(&self) -> usize {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `header`
[INFO] [stderr]   --> src/console/cartridge.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     header: rom_header::RomHeader,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `prg_bank`
[INFO] [stderr]   --> src/console/cartridge.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     prg_bank: Vec<u8>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `chr_bank`
[INFO] [stderr]   --> src/console/cartridge.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 |     chr_bank: Vec<u8>
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/console/flag_6.rs:86:33
[INFO] [stderr]    |
[INFO] [stderr] 86 | pub fn parse_flag_6(flag_value: &u8) -> Flag6 {
[INFO] [stderr]    |                                 ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/console/flag_6.rs:87:51
[INFO] [stderr]    |
[INFO] [stderr] 87 |     let nes_mapper = nes_mapper_value_from_flag_6(flag_value.clone());
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*flag_value`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/console/cartridge.rs:33:23
[INFO] [stderr]    |
[INFO] [stderr] 33 | fn read_rom(filename: &String) -> Result<Vec<u8>, io::Error> {
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/console/cartridge.rs:43:31
[INFO] [stderr]    |
[INFO] [stderr] 43 | pub fn load_content(filename: &String) -> CartridgeData {
[INFO] [stderr]    |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/console/cartridge.rs:62:30
[INFO] [stderr]    |
[INFO] [stderr] 62 | pub fn prepare<'a>(rom_data: &Vec<u8>) -> CartridgeData {
[INFO] [stderr]    |                              ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/console/cartridge.rs:62:16
[INFO] [stderr]    |
[INFO] [stderr] 62 | pub fn prepare<'a>(rom_data: &Vec<u8>) -> CartridgeData {
[INFO] [stderr]    |                ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/console/rom_header.rs:44:34
[INFO] [stderr]    |
[INFO] [stderr] 44 | pub fn read_rom_header(rom_data: &Vec<u8>) -> RomHeader {
[INFO] [stderr]    |                                  ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/utils/byte.rs:1:26
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub fn extract_bit(byte: &u8, bit_to_extract: u8) -> u8 {
[INFO] [stderr]   |                          ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]  --> src/utils/byte.rs:2:12
[INFO] [stderr]   |
[INFO] [stderr] 2 |     return byte.clone() & (1<< (bit_to_extract - 1));
[INFO] [stderr]   |            ^^^^^^^^^^^^ help: try dereferencing it: `*byte`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.55s
[INFO] running `"docker" "inspect" "cc576d6950389fc9f156f530533367ed5b5f693bbc19b886393c2b71d7a85010"`
[INFO] running `"docker" "rm" "-f" "cc576d6950389fc9f156f530533367ed5b5f693bbc19b886393c2b71d7a85010"`
[INFO] [stdout] cc576d6950389fc9f156f530533367ed5b5f693bbc19b886393c2b71d7a85010