[INFO] updating cached repository ddohler/rust-feature-gen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ddohler/rust-feature-gen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ddohler/rust-feature-gen" "work/ex/clippy-test-run/sources/stable/gh/ddohler/rust-feature-gen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ddohler/rust-feature-gen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ddohler/rust-feature-gen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ddohler/rust-feature-gen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ddohler/rust-feature-gen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 41e9f92259616e761452926a5032804ab1e3f87f [INFO] sha for GitHub repo ddohler/rust-feature-gen: 41e9f92259616e761452926a5032804ab1e3f87f [INFO] validating manifest of ddohler/rust-feature-gen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ddohler/rust-feature-gen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ddohler/rust-feature-gen [INFO] finished frobbing ddohler/rust-feature-gen [INFO] frobbed toml for ddohler/rust-feature-gen written to work/ex/clippy-test-run/sources/stable/gh/ddohler/rust-feature-gen/Cargo.toml [INFO] started frobbing ddohler/rust-feature-gen [INFO] finished frobbing ddohler/rust-feature-gen [INFO] frobbed toml for ddohler/rust-feature-gen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ddohler/rust-feature-gen/Cargo.toml [INFO] crate ddohler/rust-feature-gen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ddohler/rust-feature-gen against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ddohler/rust-feature-gen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f0b98e320e77110aa972f366005a7bb65c9a12f5677db669889f2349c3ba8372 [INFO] running `"docker" "start" "-a" "f0b98e320e77110aa972f366005a7bb65c9a12f5677db669889f2349c3ba8372"` [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking rust-criml-features v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spacetime.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | bounds: bounds [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/feature.rs:49:47 [INFO] [stderr] | [INFO] [stderr] 49 | Some(cell) => Some(FeatureClose { cell: cell }), [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/feature.rs:83:51 [INFO] [stderr] | [INFO] [stderr] 83 | Some(cell) => Some(FeatureIncrement { cell: cell }), [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/feature.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spacetime.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | bounds: bounds [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/feature.rs:49:47 [INFO] [stderr] | [INFO] [stderr] 49 | Some(cell) => Some(FeatureClose { cell: cell }), [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/feature.rs:83:51 [INFO] [stderr] | [INFO] [stderr] 83 | Some(cell) => Some(FeatureIncrement { cell: cell }), [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/feature.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/event.rs:32:48 [INFO] [stderr] | [INFO] [stderr] 32 | let x_transform = |x: f32| 0.004 * x + 40137.388552; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `40_137.388_552` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/event.rs:33:48 [INFO] [stderr] | [INFO] [stderr] 33 | let y_transform = |y: f32| 0.004 * y - 13945.687388; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `13_945.687_388` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/feature.rs:117:68 [INFO] [stderr] | [INFO] [stderr] 117 | fn accumulate_and_close(&mut self, event: evt::QuantizedEvent) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/event.rs:32:48 [INFO] [stderr] | [INFO] [stderr] 32 | let x_transform = |x: f32| 0.004 * x + 40137.388552; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `40_137.388_552` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/event.rs:33:48 [INFO] [stderr] | [INFO] [stderr] 33 | let y_transform = |y: f32| 0.004 * y - 13945.687388; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `13_945.687_388` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/feature.rs:117:68 [INFO] [stderr] | [INFO] [stderr] 117 | fn accumulate_and_close(&mut self, event: evt::QuantizedEvent) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/feature.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | let value = match self.feature_map.get(&cell) { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SPAN_3_DAYS_HRS` [INFO] [stderr] --> src/main.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | const SPAN_3_DAYS_HRS: u32 = 3 * 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/event.rs:32:48 [INFO] [stderr] | [INFO] [stderr] 32 | let x_transform = |x: f32| 0.004 * x + 40137.388552; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider changing the type or truncating it to: `40_137.387` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/event.rs:33:48 [INFO] [stderr] | [INFO] [stderr] 33 | let y_transform = |y: f32| 0.004 * y - 13945.687388; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider changing the type or truncating it to: `13_945.687_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | Err(_) => panic!("Couldn't open file") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/feature.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | let value = match self.feature_map.get(&cell) { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SPAN_3_DAYS_HRS` [INFO] [stderr] --> src/main.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | const SPAN_3_DAYS_HRS: u32 = 3 * 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/event.rs:32:48 [INFO] [stderr] | [INFO] [stderr] 32 | let x_transform = |x: f32| 0.004 * x + 40137.388552; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider changing the type or truncating it to: `40_137.387` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/event.rs:33:48 [INFO] [stderr] | [INFO] [stderr] 33 | let y_transform = |y: f32| 0.004 * y - 13945.687388; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider changing the type or truncating it to: `13_945.687_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | Err(_) => panic!("Couldn't open file") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.20s [INFO] running `"docker" "inspect" "f0b98e320e77110aa972f366005a7bb65c9a12f5677db669889f2349c3ba8372"` [INFO] running `"docker" "rm" "-f" "f0b98e320e77110aa972f366005a7bb65c9a12f5677db669889f2349c3ba8372"` [INFO] [stdout] f0b98e320e77110aa972f366005a7bb65c9a12f5677db669889f2349c3ba8372