[INFO] updating cached repository dckc/snakes-ladders
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dckc/snakes-ladders
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dckc/snakes-ladders" "work/ex/clippy-test-run/sources/stable/gh/dckc/snakes-ladders"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dckc/snakes-ladders'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dckc/snakes-ladders" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dckc/snakes-ladders"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dckc/snakes-ladders'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] fea15b696ffd3eabcea308a679d6f857a29588f7
[INFO] sha for GitHub repo dckc/snakes-ladders: fea15b696ffd3eabcea308a679d6f857a29588f7
[INFO] validating manifest of dckc/snakes-ladders on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dckc/snakes-ladders on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dckc/snakes-ladders
[INFO] finished frobbing dckc/snakes-ladders
[INFO] frobbed toml for dckc/snakes-ladders written to work/ex/clippy-test-run/sources/stable/gh/dckc/snakes-ladders/Cargo.toml
[INFO] started frobbing dckc/snakes-ladders
[INFO] finished frobbing dckc/snakes-ladders
[INFO] frobbed toml for dckc/snakes-ladders written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dckc/snakes-ladders/Cargo.toml
[INFO] crate dckc/snakes-ladders has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dckc/snakes-ladders against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dckc/snakes-ladders:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 43a43736c7ceb434b647f8e78e6a63e7222ee1e663aecf1516bd552b77d453fc
[INFO] running `"docker" "start" "-a" "43a43736c7ceb434b647f8e78e6a63e7222ee1e663aecf1516bd552b77d453fc"`
[INFO] [stderr]     Checking assign4 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:17:22
[INFO] [stderr]    |
[INFO] [stderr] 17 | const SAMPLE_INPUT: &'static str = "
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:32:26
[INFO] [stderr]    |
[INFO] [stderr] 32 | const RESULTING_OUTPUT: &'static str = "
[INFO] [stderr]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:89:20
[INFO] [stderr]    |
[INFO] [stderr] 89 |         for row in 1..(self.board.rows + 1) {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.board.rows`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:92:27
[INFO] [stderr]    |
[INFO] [stderr] 92 |             for column in 1..(self.board.columns + 1) {
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.board.columns`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:237:17
[INFO] [stderr]     |
[INFO] [stderr] 237 |         assert!(self.dice.len() > 0);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.dice.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:324:48
[INFO] [stderr]     |
[INFO] [stderr] 324 |         "+---".repeat(self.columns as usize) + "+".into()
[INFO] [stderr]     |                                                ^^^^^^^^^^ help: consider removing `.into()`: `"+"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:89:20
[INFO] [stderr]    |
[INFO] [stderr] 89 |         for row in 1..(self.board.rows + 1) {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.board.rows`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:92:27
[INFO] [stderr]    |
[INFO] [stderr] 92 |             for column in 1..(self.board.columns + 1) {
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.board.columns`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:237:17
[INFO] [stderr]     |
[INFO] [stderr] 237 |         assert!(self.dice.len() > 0);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.dice.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:324:48
[INFO] [stderr]     |
[INFO] [stderr] 324 |         "+---".repeat(self.columns as usize) + "+".into()
[INFO] [stderr]     |                                                ^^^^^^^^^^ help: consider removing `.into()`: `"+"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.82s
[INFO] running `"docker" "inspect" "43a43736c7ceb434b647f8e78e6a63e7222ee1e663aecf1516bd552b77d453fc"`
[INFO] running `"docker" "rm" "-f" "43a43736c7ceb434b647f8e78e6a63e7222ee1e663aecf1516bd552b77d453fc"`
[INFO] [stdout] 43a43736c7ceb434b647f8e78e6a63e7222ee1e663aecf1516bd552b77d453fc