[INFO] updating cached repository davidsullins/AdventOfRust2016 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/davidsullins/AdventOfRust2016 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/davidsullins/AdventOfRust2016" "work/ex/clippy-test-run/sources/stable/gh/davidsullins/AdventOfRust2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davidsullins/AdventOfRust2016'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/davidsullins/AdventOfRust2016" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidsullins/AdventOfRust2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidsullins/AdventOfRust2016'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 28c0d8fa63c510afdd063df1c0034ea2507a068f [INFO] sha for GitHub repo davidsullins/AdventOfRust2016: 28c0d8fa63c510afdd063df1c0034ea2507a068f [INFO] validating manifest of davidsullins/AdventOfRust2016 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of davidsullins/AdventOfRust2016 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing davidsullins/AdventOfRust2016 [INFO] finished frobbing davidsullins/AdventOfRust2016 [INFO] frobbed toml for davidsullins/AdventOfRust2016 written to work/ex/clippy-test-run/sources/stable/gh/davidsullins/AdventOfRust2016/Cargo.toml [INFO] started frobbing davidsullins/AdventOfRust2016 [INFO] finished frobbing davidsullins/AdventOfRust2016 [INFO] frobbed toml for davidsullins/AdventOfRust2016 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidsullins/AdventOfRust2016/Cargo.toml [INFO] crate davidsullins/AdventOfRust2016 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting davidsullins/AdventOfRust2016 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidsullins/AdventOfRust2016:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dd5e84c6fa445d88dd99f561db3dc7020b47e1f9ad0d5183161ce8c868639cfd [INFO] running `"docker" "start" "-a" "dd5e84c6fa445d88dd99f561db3dc7020b47e1f9ad0d5183161ce8c868639cfd"` [INFO] [stderr] Checking log v0.3.6 [INFO] [stderr] Checking permutohedron v0.2.2 [INFO] [stderr] Checking num_cpus v1.2.0 [INFO] [stderr] Checking thread_local v0.3.2 [INFO] [stderr] Checking aho-corasick v0.6.1 [INFO] [stderr] Checking futures v0.1.7 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking futures-cpupool v0.1.2 [INFO] [stderr] Checking AdventOfRust2016 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/advent24.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | walls: walls, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `walls` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/advent24.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/advent24.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | distances: distances, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `distances` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/advent24.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | point_count: point_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `point_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bin/advent19.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | #[allow(needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/advent18.rs:13:20 [INFO] [stderr] | [INFO] [stderr] 13 | trap_room.grow(400000); [INFO] [stderr] | ^^^^^^ help: consider: `400_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bin/advent19.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | #[allow(needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bin/advent17.rs:138:20 [INFO] [stderr] | [INFO] [stderr] 138 | DIRECTIONS.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `AdventOfRust2016`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/advent19.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | let mut elves: Vec<_> = (1..elf_count as u32 + 1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=elf_count as u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/advent19.rs:41:29 [INFO] [stderr] | [INFO] [stderr] 41 | let mut elves: Vec<_> = (1..elf_count as u32 + 1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=elf_count as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/advent19.rs:62:29 [INFO] [stderr] | [INFO] [stderr] 62 | let mut elves: Vec<_> = (1..elf_count as u32 + 1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=elf_count as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/advent19.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | for remaining in (2..elf_count + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `(2..=elf_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: lint name `ptr_arg` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bin/advent16.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | #[allow(ptr_arg)] [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::ptr_arg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/advent16.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | rd.grow(35651584); [INFO] [stderr] | ^^^^^^^^ help: consider: `35_651_584` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `ptr_arg` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bin/advent16.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | #[allow(ptr_arg)] [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::ptr_arg` [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "dd5e84c6fa445d88dd99f561db3dc7020b47e1f9ad0d5183161ce8c868639cfd"` [INFO] running `"docker" "rm" "-f" "dd5e84c6fa445d88dd99f561db3dc7020b47e1f9ad0d5183161ce8c868639cfd"` [INFO] [stdout] dd5e84c6fa445d88dd99f561db3dc7020b47e1f9ad0d5183161ce8c868639cfd