[INFO] updating cached repository davideGiovannini/cryptochallenge_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/davideGiovannini/cryptochallenge_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/davideGiovannini/cryptochallenge_rust" "work/ex/clippy-test-run/sources/stable/gh/davideGiovannini/cryptochallenge_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davideGiovannini/cryptochallenge_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/davideGiovannini/cryptochallenge_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davideGiovannini/cryptochallenge_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davideGiovannini/cryptochallenge_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d292b3e9eb215d19759ea8ad15d48e91fd5a3006 [INFO] sha for GitHub repo davideGiovannini/cryptochallenge_rust: d292b3e9eb215d19759ea8ad15d48e91fd5a3006 [INFO] validating manifest of davideGiovannini/cryptochallenge_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of davideGiovannini/cryptochallenge_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing davideGiovannini/cryptochallenge_rust [INFO] finished frobbing davideGiovannini/cryptochallenge_rust [INFO] frobbed toml for davideGiovannini/cryptochallenge_rust written to work/ex/clippy-test-run/sources/stable/gh/davideGiovannini/cryptochallenge_rust/Cargo.toml [INFO] started frobbing davideGiovannini/cryptochallenge_rust [INFO] finished frobbing davideGiovannini/cryptochallenge_rust [INFO] frobbed toml for davideGiovannini/cryptochallenge_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davideGiovannini/cryptochallenge_rust/Cargo.toml [INFO] crate davideGiovannini/cryptochallenge_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting davideGiovannini/cryptochallenge_rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davideGiovannini/cryptochallenge_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 44ad8f9dd58db8c442e2e6dfe1fe762fdd7338ea8331e4447782dc709e92f6d3 [INFO] running `"docker" "start" "-a" "44ad8f9dd58db8c442e2e6dfe1fe762fdd7338ea8331e4447782dc709e92f6d3"` [INFO] [stderr] Checking set_1 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/base64/mod.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/base64/mod.rs:4:44 [INFO] [stderr] | [INFO] [stderr] 4 | let mut result = String::with_capacity((4 * (bytes.len() / 3))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/base64/mod.rs:4:44 [INFO] [stderr] | [INFO] [stderr] 4 | let mut result = String::with_capacity((4 * (bytes.len() / 3))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base64/mod.rs:19:33 [INFO] [stderr] | [INFO] [stderr] 19 | value = (byte & 0b00111111) as usize; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/base64/mod.rs:45:41 [INFO] [stderr] | [INFO] [stderr] 45 | let mut result = Vec::with_capacity((3 * (data.len() / 4))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/base64/mod.rs:45:41 [INFO] [stderr] | [INFO] [stderr] 45 | let mut result = Vec::with_capacity((3 * (data.len() / 4))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lang/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / return (most_likely.1, [INFO] [stderr] 20 | | char::from_u32(most_likely.1 as u32).unwrap_or(' '), [INFO] [stderr] 21 | | String::from_utf8(xor_byte(bytes, most_likely.1)) [INFO] [stderr] 22 | | .unwrap_or("Error while converting from bytes to utf8 string".to_string()), [INFO] [stderr] 23 | | most_likely.0); [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 19 | (most_likely.1, [INFO] [stderr] 20 | char::from_u32(most_likely.1 as u32).unwrap_or(' '), [INFO] [stderr] 21 | String::from_utf8(xor_byte(bytes, most_likely.1)) [INFO] [stderr] 22 | .unwrap_or("Error while converting from bytes to utf8 string".to_string()), [INFO] [stderr] 23 | most_likely.0) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | const C1_HEX_STR: &'static [u8] = b"49276d206b696c6c696e6720796f757220627261696e206c696b65206120706f69736f6e6f7573206d757368726f6f6d"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | const C1_BASE64_STR: &'static str = "SSdtIGtpbGxpbmcgeW91ciBicmFpbiBsaWtlIGEgcG9pc29ub3VzIG11c2hyb29t"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | const C2_HEX1: &'static [u8] = b"1c0111001f010100061a024b53535009181c"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | const C2_HEX2: &'static [u8] = b"686974207468652062756c6c277320657965"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | const C2_HEX_RES: &'static str = "746865206b696420646f6e277420706c6179"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | const C3_HEX: &'static [u8] = [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | const C5_KEY: &'static [u8] = b"ICE"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | const C5_STR: &'static [u8] = b"Burning 'em, if you ain't quick and nimble\nI go crazy when I \ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | const C5_CRYPTED: &'static str = "0b3637272a2b2e63622c2e69692a23693a2a3c6324202d623d63343c2a26226324272765272a282b2f20430a652e2c652a3124333a653e2b2027630c692b20283165286326302e27282f"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/base64/mod.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/base64/mod.rs:4:44 [INFO] [stderr] | [INFO] [stderr] 4 | let mut result = String::with_capacity((4 * (bytes.len() / 3))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/base64/mod.rs:4:44 [INFO] [stderr] | [INFO] [stderr] 4 | let mut result = String::with_capacity((4 * (bytes.len() / 3))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base64/mod.rs:19:33 [INFO] [stderr] | [INFO] [stderr] 19 | value = (byte & 0b00111111) as usize; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/base64/mod.rs:45:41 [INFO] [stderr] | [INFO] [stderr] 45 | let mut result = Vec::with_capacity((3 * (data.len() / 4))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/base64/mod.rs:45:41 [INFO] [stderr] | [INFO] [stderr] 45 | let mut result = Vec::with_capacity((3 * (data.len() / 4))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lang/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / return (most_likely.1, [INFO] [stderr] 20 | | char::from_u32(most_likely.1 as u32).unwrap_or(' '), [INFO] [stderr] 21 | | String::from_utf8(xor_byte(bytes, most_likely.1)) [INFO] [stderr] 22 | | .unwrap_or("Error while converting from bytes to utf8 string".to_string()), [INFO] [stderr] 23 | | most_likely.0); [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 19 | (most_likely.1, [INFO] [stderr] 20 | char::from_u32(most_likely.1 as u32).unwrap_or(' '), [INFO] [stderr] 21 | String::from_utf8(xor_byte(bytes, most_likely.1)) [INFO] [stderr] 22 | .unwrap_or("Error while converting from bytes to utf8 string".to_string()), [INFO] [stderr] 23 | most_likely.0) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | const C1_HEX_STR: &'static [u8] = b"49276d206b696c6c696e6720796f757220627261696e206c696b65206120706f69736f6e6f7573206d757368726f6f6d"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | const C1_BASE64_STR: &'static str = "SSdtIGtpbGxpbmcgeW91ciBicmFpbiBsaWtlIGEgcG9pc29ub3VzIG11c2hyb29t"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | const C2_HEX1: &'static [u8] = b"1c0111001f010100061a024b53535009181c"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | const C2_HEX2: &'static [u8] = b"686974207468652062756c6c277320657965"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | const C2_HEX_RES: &'static str = "746865206b696420646f6e277420706c6179"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | const C3_HEX: &'static [u8] = [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | const C5_KEY: &'static [u8] = b"ICE"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | const C5_STR: &'static [u8] = b"Burning 'em, if you ain't quick and nimble\nI go crazy when I \ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | const C5_CRYPTED: &'static str = "0b3637272a2b2e63622c2e69692a23693a2a3c6324202d623d63343c2a26226324272765272a282b2f20430a652e2c652a3124333a653e2b2027630c692b20283165286326302e27282f"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: function is never used: `from_base64` [INFO] [stderr] --> src/base64/mod.rs:44:1 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn from_base64(data: &str) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `decode_char` [INFO] [stderr] --> src/base64/mod.rs:96:1 [INFO] [stderr] | [INFO] [stderr] 96 | fn decode_char(c: &char) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `hamming_bit_distance` [INFO] [stderr] --> src/bytes/mod.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn hamming_bit_distance(bytesA: &[u8], bytesB: &[u8]) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/base64/mod.rs:96:19 [INFO] [stderr] | [INFO] [stderr] 96 | fn decode_char(c: &char) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variable `bytesA` should have a snake case name such as `bytes_a` [INFO] [stderr] --> src/bytes/mod.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn hamming_bit_distance(bytesA: &[u8], bytesB: &[u8]) -> usize { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `bytesB` should have a snake case name such as `bytes_b` [INFO] [stderr] --> src/bytes/mod.rs:30:44 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn hamming_bit_distance(bytesA: &[u8], bytesB: &[u8]) -> usize { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `byteA` should have a snake case name such as `byte_a` [INFO] [stderr] --> src/bytes/mod.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | for (byteA, byteB) in bytesA.iter().zip(bytesB) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `byteB` should have a snake case name such as `byte_b` [INFO] [stderr] --> src/bytes/mod.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | for (byteA, byteB) in bytesA.iter().zip(bytesB) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lang/mod.rs:20:28 [INFO] [stderr] | [INFO] [stderr] 20 | char::from_u32(most_likely.1 as u32).unwrap_or(' '), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(most_likely.1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lang/mod.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | .unwrap_or("Error while converting from bytes to utf8 string".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Error while converting from bytes to utf8 string".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lang/mod.rs:32:46 [INFO] [stderr] | [INFO] [stderr] 32 | value *= frequency_of(char::from_u32(*byte as u32).unwrap_or(' ')) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/base64/mod.rs:96:19 [INFO] [stderr] | [INFO] [stderr] 96 | fn decode_char(c: &char) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/base64/mod.rs:181:31 [INFO] [stderr] | [INFO] [stderr] 181 | assert_eq!(to_base64(&"".as_bytes()), "") [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: function `test_Man` should have a snake case name such as `test_man` [INFO] [stderr] --> src/base64/mod.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | / fn test_Man() { [INFO] [stderr] 186 | | assert_eq!(to_base64(&"Man".as_bytes()), "TWFu") [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/base64/mod.rs:186:31 [INFO] [stderr] | [INFO] [stderr] 186 | assert_eq!(to_base64(&"Man".as_bytes()), "TWFu") [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Man"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: function `test_M` should have a snake case name such as `test_m` [INFO] [stderr] --> src/base64/mod.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | / fn test_M() { [INFO] [stderr] 191 | | assert_eq!(to_base64(&"M".as_bytes()), "TQ==") [INFO] [stderr] 192 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/base64/mod.rs:191:31 [INFO] [stderr] | [INFO] [stderr] 191 | assert_eq!(to_base64(&"M".as_bytes()), "TQ==") [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"M"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: function `test_Horse` should have a snake case name such as `test_horse` [INFO] [stderr] --> src/base64/mod.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | / fn test_Horse() { [INFO] [stderr] 196 | | assert_eq!(to_base64(&"Horse".as_bytes()), "SG9yc2U=") [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/base64/mod.rs:196:31 [INFO] [stderr] | [INFO] [stderr] 196 | assert_eq!(to_base64(&"Horse".as_bytes()), "SG9yc2U=") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Horse"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/base64/mod.rs:200:31 [INFO] [stderr] | [INFO] [stderr] 200 | assert_eq!(to_base64(&"hurricane".as_bytes()), "aHVycmljYW5l") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hurricane"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/base64/mod.rs:205:31 [INFO] [stderr] | [INFO] [stderr] 205 | assert_eq!(to_base64(&"banana".as_bytes()), "YmFuYW5h") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"banana"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/base64/mod.rs:210:31 [INFO] [stderr] | [INFO] [stderr] 210 | assert_eq!(to_base64(&"banana nababa".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"banana nababa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/base64/mod.rs:216:31 [INFO] [stderr] | [INFO] [stderr] 216 | assert_eq!(to_base64(&"trololol".as_bytes()), "dHJvbG9sb2w=") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"trololol"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: function `test_TfS` should have a snake case name such as `test_tf_s` [INFO] [stderr] --> src/hex/mod.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / fn test_TfS() { [INFO] [stderr] 69 | | assert_eq!(parse_hex_str(b"546653"), b"TfS"); [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/hex/mod.rs:75:20 [INFO] [stderr] | [INFO] [stderr] 75 | "I'm killing your brain like a poisonous mushroom".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"I'm killing your brain like a poisonous mushroom"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: variable `bytesA` should have a snake case name such as `bytes_a` [INFO] [stderr] --> src/bytes/mod.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn hamming_bit_distance(bytesA: &[u8], bytesB: &[u8]) -> usize { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `bytesB` should have a snake case name such as `bytes_b` [INFO] [stderr] --> src/bytes/mod.rs:30:44 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn hamming_bit_distance(bytesA: &[u8], bytesB: &[u8]) -> usize { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `byteA` should have a snake case name such as `byte_a` [INFO] [stderr] --> src/bytes/mod.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | for (byteA, byteB) in bytesA.iter().zip(bytesB) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `byteB` should have a snake case name such as `byte_b` [INFO] [stderr] --> src/bytes/mod.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | for (byteA, byteB) in bytesA.iter().zip(bytesB) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/bytes/mod.rs:53:29 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(xor_seqs(&vec![0xF0, 0x0F], &vec![0x0F, 0x0F]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0xF0, 0x0F]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/bytes/mod.rs:53:48 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(xor_seqs(&vec![0xF0, 0x0F], &vec![0x0F, 0x0F]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0x0F, 0x0F]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lang/mod.rs:20:28 [INFO] [stderr] | [INFO] [stderr] 20 | char::from_u32(most_likely.1 as u32).unwrap_or(' '), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(most_likely.1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lang/mod.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | .unwrap_or("Error while converting from bytes to utf8 string".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Error while converting from bytes to utf8 string".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lang/mod.rs:32:46 [INFO] [stderr] | [INFO] [stderr] 32 | value *= frequency_of(char::from_u32(*byte as u32).unwrap_or(' ')) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `"docker" "inspect" "44ad8f9dd58db8c442e2e6dfe1fe762fdd7338ea8331e4447782dc709e92f6d3"` [INFO] running `"docker" "rm" "-f" "44ad8f9dd58db8c442e2e6dfe1fe762fdd7338ea8331e4447782dc709e92f6d3"` [INFO] [stdout] 44ad8f9dd58db8c442e2e6dfe1fe762fdd7338ea8331e4447782dc709e92f6d3