[INFO] updating cached repository davidbegin/messing-with-options [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/davidbegin/messing-with-options [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/davidbegin/messing-with-options" "work/ex/clippy-test-run/sources/stable/gh/davidbegin/messing-with-options"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davidbegin/messing-with-options'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/davidbegin/messing-with-options" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidbegin/messing-with-options"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidbegin/messing-with-options'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 65e12c190816a8c19eb50e5b7a8a4fad71203260 [INFO] sha for GitHub repo davidbegin/messing-with-options: 65e12c190816a8c19eb50e5b7a8a4fad71203260 [INFO] validating manifest of davidbegin/messing-with-options on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of davidbegin/messing-with-options on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing davidbegin/messing-with-options [INFO] finished frobbing davidbegin/messing-with-options [INFO] frobbed toml for davidbegin/messing-with-options written to work/ex/clippy-test-run/sources/stable/gh/davidbegin/messing-with-options/Cargo.toml [INFO] started frobbing davidbegin/messing-with-options [INFO] finished frobbing davidbegin/messing-with-options [INFO] frobbed toml for davidbegin/messing-with-options written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidbegin/messing-with-options/Cargo.toml [INFO] crate davidbegin/messing-with-options has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting davidbegin/messing-with-options against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidbegin/messing-with-options:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b89058ce60c6376bd2228dd87567356dc4177bf8c56ce3c57a7994cb363cfb6e [INFO] running `"docker" "start" "-a" "b89058ce60c6376bd2228dd87567356dc4177bf8c56ce3c57a7994cb363cfb6e"` [INFO] [stderr] Checking messin_with_options v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/active_vector.rs:7:12 [INFO] [stderr] | [INFO] [stderr] 7 | if vec.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/active_vector.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if names.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!names.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/active_vector.rs:7:12 [INFO] [stderr] | [INFO] [stderr] 7 | if vec.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/active_vector.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if names.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!names.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/active_vector.rs:7:12 [INFO] [stderr] | [INFO] [stderr] 7 | if vec.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/active_vector.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if names.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!names.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | / match option { [INFO] [stderr] 31 | | Some(x) => { print_thang(x) }, [INFO] [stderr] 32 | | None => {}, [INFO] [stderr] 33 | | } [INFO] [stderr] | |___^ help: try this: `if let Some(x) = option { print_thang(x) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/active_vector.rs:7:12 [INFO] [stderr] | [INFO] [stderr] 7 | if vec.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/active_vector.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if names.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!names.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | / match option { [INFO] [stderr] 31 | | Some(x) => { print_thang(x) }, [INFO] [stderr] 32 | | None => {}, [INFO] [stderr] 33 | | } [INFO] [stderr] | |___^ help: try this: `if let Some(x) = option { print_thang(x) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.06s [INFO] running `"docker" "inspect" "b89058ce60c6376bd2228dd87567356dc4177bf8c56ce3c57a7994cb363cfb6e"` [INFO] running `"docker" "rm" "-f" "b89058ce60c6376bd2228dd87567356dc4177bf8c56ce3c57a7994cb363cfb6e"` [INFO] [stdout] b89058ce60c6376bd2228dd87567356dc4177bf8c56ce3c57a7994cb363cfb6e