[INFO] updating cached repository davidarmstronglewis/do-you-like-cards [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/davidarmstronglewis/do-you-like-cards [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/davidarmstronglewis/do-you-like-cards" "work/ex/clippy-test-run/sources/stable/gh/davidarmstronglewis/do-you-like-cards"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davidarmstronglewis/do-you-like-cards'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/davidarmstronglewis/do-you-like-cards" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidarmstronglewis/do-you-like-cards"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidarmstronglewis/do-you-like-cards'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d91098df8835ba6f49b471ea825f7cba6ed014ac [INFO] sha for GitHub repo davidarmstronglewis/do-you-like-cards: d91098df8835ba6f49b471ea825f7cba6ed014ac [INFO] validating manifest of davidarmstronglewis/do-you-like-cards on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of davidarmstronglewis/do-you-like-cards on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing davidarmstronglewis/do-you-like-cards [INFO] finished frobbing davidarmstronglewis/do-you-like-cards [INFO] frobbed toml for davidarmstronglewis/do-you-like-cards written to work/ex/clippy-test-run/sources/stable/gh/davidarmstronglewis/do-you-like-cards/Cargo.toml [INFO] started frobbing davidarmstronglewis/do-you-like-cards [INFO] finished frobbing davidarmstronglewis/do-you-like-cards [INFO] frobbed toml for davidarmstronglewis/do-you-like-cards written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidarmstronglewis/do-you-like-cards/Cargo.toml [INFO] crate davidarmstronglewis/do-you-like-cards has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting davidarmstronglewis/do-you-like-cards against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidarmstronglewis/do-you-like-cards:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8a686c4a7940811fe15e25524f50200aaa38458d45f5bc81d38402ebcd3bd6df [INFO] running `"docker" "start" "-a" "8a686c4a7940811fe15e25524f50200aaa38458d45f5bc81d38402ebcd3bd6df"` [INFO] [stderr] Checking blackjack v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:74:21 [INFO] [stderr] | [INFO] [stderr] 74 | suit: suit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `suit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:74:21 [INFO] [stderr] | [INFO] [stderr] 74 | suit: suit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `suit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `deck::Deck` [INFO] [stderr] --> src/lib.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Deck { [INFO] [stderr] 14 | | let mut new_deck = Deck { cards: Vec::new() }; [INFO] [stderr] 15 | | [INFO] [stderr] 16 | | for i in 0..52 { [INFO] [stderr] ... | [INFO] [stderr] 30 | | new_deck [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] 9 | pub struct Deck { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | / self.cards [INFO] [stderr] 47 | | .iter() [INFO] [stderr] 48 | | .filter(|card| card.suit == suit) [INFO] [stderr] 49 | | .min_by(|a, b| a.value.cmp(&b.value)) [INFO] [stderr] 50 | | .map(|card| card.clone()) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 46 | self.cards [INFO] [stderr] 47 | .iter() [INFO] [stderr] 48 | .filter(|card| card.suit == suit) [INFO] [stderr] 49 | .min_by(|a, b| a.value.cmp(&b.value)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | .map(|card| card.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*card` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `deck::Deck` [INFO] [stderr] --> src/lib.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Deck { [INFO] [stderr] 14 | | let mut new_deck = Deck { cards: Vec::new() }; [INFO] [stderr] 15 | | [INFO] [stderr] 16 | | for i in 0..52 { [INFO] [stderr] ... | [INFO] [stderr] 30 | | new_deck [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] 9 | pub struct Deck { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | / self.cards [INFO] [stderr] 47 | | .iter() [INFO] [stderr] 48 | | .filter(|card| card.suit == suit) [INFO] [stderr] 49 | | .min_by(|a, b| a.value.cmp(&b.value)) [INFO] [stderr] 50 | | .map(|card| card.clone()) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 46 | self.cards [INFO] [stderr] 47 | .iter() [INFO] [stderr] 48 | .filter(|card| card.suit == suit) [INFO] [stderr] 49 | .min_by(|a, b| a.value.cmp(&b.value)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | .map(|card| card.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*card` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:74:21 [INFO] [stderr] | [INFO] [stderr] 74 | suit: suit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `suit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:74:21 [INFO] [stderr] | [INFO] [stderr] 74 | suit: suit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `suit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | avg [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:37:15 [INFO] [stderr] | [INFO] [stderr] 37 | let avg = total / num_cards; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | avg [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:37:15 [INFO] [stderr] | [INFO] [stderr] 37 | let avg = total / num_cards; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | / self.cards [INFO] [stderr] 47 | | .iter() [INFO] [stderr] 48 | | .filter(|card| card.suit == suit) [INFO] [stderr] 49 | | .min_by(|a, b| a.value.cmp(&b.value)) [INFO] [stderr] 50 | | .map(|card| card.clone()) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 46 | self.cards [INFO] [stderr] 47 | .iter() [INFO] [stderr] 48 | .filter(|card| card.suit == suit) [INFO] [stderr] 49 | .min_by(|a, b| a.value.cmp(&b.value)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | .map(|card| card.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*card` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let total = cards_for_status.iter().fold( [INFO] [stderr] | _________________^ [INFO] [stderr] 33 | | 0, [INFO] [stderr] 34 | | |acc, &card| acc + card.value, [INFO] [stderr] 35 | | ) as f64; [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 32 | let total = f64::from(cards_for_status.iter().fold( [INFO] [stderr] 33 | 0, [INFO] [stderr] 34 | |acc, &card| acc + card.value, [INFO] [stderr] 35 | )); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | / self.cards [INFO] [stderr] 47 | | .iter() [INFO] [stderr] 48 | | .filter(|card| card.suit == suit) [INFO] [stderr] 49 | | .min_by(|a, b| a.value.cmp(&b.value)) [INFO] [stderr] 50 | | .map(|card| card.clone()) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 46 | self.cards [INFO] [stderr] 47 | .iter() [INFO] [stderr] 48 | .filter(|card| card.suit == suit) [INFO] [stderr] 49 | .min_by(|a, b| a.value.cmp(&b.value)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | .map(|card| card.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*card` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let total = cards_for_status.iter().fold( [INFO] [stderr] | _________________^ [INFO] [stderr] 33 | | 0, [INFO] [stderr] 34 | | |acc, &card| acc + card.value, [INFO] [stderr] 35 | | ) as f64; [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 32 | let total = f64::from(cards_for_status.iter().fold( [INFO] [stderr] 33 | 0, [INFO] [stderr] 34 | |acc, &card| acc + card.value, [INFO] [stderr] 35 | )); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.45s [INFO] running `"docker" "inspect" "8a686c4a7940811fe15e25524f50200aaa38458d45f5bc81d38402ebcd3bd6df"` [INFO] running `"docker" "rm" "-f" "8a686c4a7940811fe15e25524f50200aaa38458d45f5bc81d38402ebcd3bd6df"` [INFO] [stdout] 8a686c4a7940811fe15e25524f50200aaa38458d45f5bc81d38402ebcd3bd6df