[INFO] updating cached repository davepacheco/rust-adif [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/davepacheco/rust-adif [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/davepacheco/rust-adif" "work/ex/clippy-test-run/sources/stable/gh/davepacheco/rust-adif"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davepacheco/rust-adif'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/davepacheco/rust-adif" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davepacheco/rust-adif"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davepacheco/rust-adif'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a627b17ea434b73d764f75b3b5e616966d4ee18c [INFO] sha for GitHub repo davepacheco/rust-adif: a627b17ea434b73d764f75b3b5e616966d4ee18c [INFO] validating manifest of davepacheco/rust-adif on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of davepacheco/rust-adif on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing davepacheco/rust-adif [INFO] finished frobbing davepacheco/rust-adif [INFO] frobbed toml for davepacheco/rust-adif written to work/ex/clippy-test-run/sources/stable/gh/davepacheco/rust-adif/Cargo.toml [INFO] started frobbing davepacheco/rust-adif [INFO] finished frobbing davepacheco/rust-adif [INFO] frobbed toml for davepacheco/rust-adif written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davepacheco/rust-adif/Cargo.toml [INFO] crate davepacheco/rust-adif has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting davepacheco/rust-adif against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davepacheco/rust-adif:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a6177eb0d27c92cdca07018078910b01e5b980d4570baae7c666d44d51be6c49 [INFO] running `"docker" "start" "-a" "a6177eb0d27c92cdca07018078910b01e5b980d4570baae7c666d44d51be6c49"` [INFO] [stderr] Checking adif v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | const ADI_STR_EOH : &'static str = "eoh"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:58:31 [INFO] [stderr] | [INFO] [stderr] 58 | const ADIF_HEADER_ADIF_VER : &'static str = "adif_ver"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:59:40 [INFO] [stderr] | [INFO] [stderr] 59 | const ADIF_HEADER_CREATED_TIMESTAMP : &'static str = "created_timestamp"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:60:32 [INFO] [stderr] | [INFO] [stderr] 60 | const ADIF_HEADER_PROGRAMID : &'static str = "programid"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:61:37 [INFO] [stderr] | [INFO] [stderr] 61 | const ADIF_HEADER_PROGRAMVERSION : &'static str = "programversion"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:62:30 [INFO] [stderr] | [INFO] [stderr] 62 | const ADIF_HEADER_USERDEF : &'static str = "userdef"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:370:5 [INFO] [stderr] | [INFO] [stderr] 370 | return Ok(aps.aps_tokens[aps.aps_tokens.len() - 1].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(aps.aps_tokens[aps.aps_tokens.len() - 1].clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:604:9 [INFO] [stderr] | [INFO] [stderr] 604 | / return super::AdiFile { [INFO] [stderr] 605 | | adi_header: header, [INFO] [stderr] 606 | | adi_records: records [INFO] [stderr] 607 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 604 | super::AdiFile { [INFO] [stderr] 605 | adi_header: header, [INFO] [stderr] 606 | adi_records: records [INFO] [stderr] 607 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:617:9 [INFO] [stderr] | [INFO] [stderr] 617 | / return super::AdiFile { [INFO] [stderr] 618 | | adi_header: Some(header), [INFO] [stderr] 619 | | adi_records: records [INFO] [stderr] 620 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 617 | super::AdiFile { [INFO] [stderr] 618 | adi_header: Some(header), [INFO] [stderr] 619 | adi_records: records [INFO] [stderr] 620 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:676:9 [INFO] [stderr] | [INFO] [stderr] 676 | / return super::AdiFile { [INFO] [stderr] 677 | | adi_header: Some(header), [INFO] [stderr] 678 | | adi_records: records [INFO] [stderr] 679 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 676 | super::AdiFile { [INFO] [stderr] 677 | adi_header: Some(header), [INFO] [stderr] 678 | adi_records: records [INFO] [stderr] 679 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | const ADI_STR_EOH : &'static str = "eoh"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:58:31 [INFO] [stderr] | [INFO] [stderr] 58 | const ADIF_HEADER_ADIF_VER : &'static str = "adif_ver"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:59:40 [INFO] [stderr] | [INFO] [stderr] 59 | const ADIF_HEADER_CREATED_TIMESTAMP : &'static str = "created_timestamp"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:60:32 [INFO] [stderr] | [INFO] [stderr] 60 | const ADIF_HEADER_PROGRAMID : &'static str = "programid"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:61:37 [INFO] [stderr] | [INFO] [stderr] 61 | const ADIF_HEADER_PROGRAMVERSION : &'static str = "programversion"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:62:30 [INFO] [stderr] | [INFO] [stderr] 62 | const ADIF_HEADER_USERDEF : &'static str = "userdef"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:370:5 [INFO] [stderr] | [INFO] [stderr] 370 | return Ok(aps.aps_tokens[aps.aps_tokens.len() - 1].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(aps.aps_tokens[aps.aps_tokens.len() - 1].clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `AdifFileType` [INFO] [stderr] --> src/lib.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | enum AdifFileType { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ADIF_HEADER_ADIF_VER` [INFO] [stderr] --> src/lib.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | const ADIF_HEADER_ADIF_VER : &'static str = "adif_ver"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ADIF_HEADER_CREATED_TIMESTAMP` [INFO] [stderr] --> src/lib.rs:59:1 [INFO] [stderr] | [INFO] [stderr] 59 | const ADIF_HEADER_CREATED_TIMESTAMP : &'static str = "created_timestamp"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ADIF_HEADER_PROGRAMID` [INFO] [stderr] --> src/lib.rs:60:1 [INFO] [stderr] | [INFO] [stderr] 60 | const ADIF_HEADER_PROGRAMID : &'static str = "programid"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ADIF_HEADER_PROGRAMVERSION` [INFO] [stderr] --> src/lib.rs:61:1 [INFO] [stderr] | [INFO] [stderr] 61 | const ADIF_HEADER_PROGRAMVERSION : &'static str = "programversion"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ADIF_HEADER_USERDEF` [INFO] [stderr] --> src/lib.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | const ADIF_HEADER_USERDEF : &'static str = "userdef"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:231:12 [INFO] [stderr] | [INFO] [stderr] 231 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:353:1 [INFO] [stderr] | [INFO] [stderr] 353 | / fn adi_parse_peek_token<'a>(aps : &'a mut AdiParseState, which : u8) -> [INFO] [stderr] 354 | | Result [INFO] [stderr] 355 | | { [INFO] [stderr] 356 | | adi_parse_advance_tokens(aps, which + 1)?; [INFO] [stderr] ... | [INFO] [stderr] 370 | | return Ok(aps.aps_tokens[aps.aps_tokens.len() - 1].clone()); [INFO] [stderr] 371 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | assert!(aps.aps_tokens.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!aps.aps_tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `AdifFileType` [INFO] [stderr] --> src/lib.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | enum AdifFileType { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ADI_STR_EOH` [INFO] [stderr] --> src/lib.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | const ADI_STR_EOH : &'static str = "eoh"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ADIF_HEADER_ADIF_VER` [INFO] [stderr] --> src/lib.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | const ADIF_HEADER_ADIF_VER : &'static str = "adif_ver"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ADIF_HEADER_CREATED_TIMESTAMP` [INFO] [stderr] --> src/lib.rs:59:1 [INFO] [stderr] | [INFO] [stderr] 59 | const ADIF_HEADER_CREATED_TIMESTAMP : &'static str = "created_timestamp"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ADIF_HEADER_PROGRAMID` [INFO] [stderr] --> src/lib.rs:60:1 [INFO] [stderr] | [INFO] [stderr] 60 | const ADIF_HEADER_PROGRAMID : &'static str = "programid"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ADIF_HEADER_PROGRAMVERSION` [INFO] [stderr] --> src/lib.rs:61:1 [INFO] [stderr] | [INFO] [stderr] 61 | const ADIF_HEADER_PROGRAMVERSION : &'static str = "programversion"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ADIF_HEADER_USERDEF` [INFO] [stderr] --> src/lib.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | const ADIF_HEADER_USERDEF : &'static str = "userdef"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ADI_MAX_FIELDLEN` [INFO] [stderr] --> src/lib.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | const ADI_MAX_FIELDLEN : usize = 1024; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adi_dump` [INFO] [stderr] --> src/lib.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | fn adi_dump(adf : AdiFile) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adi_dump_record` [INFO] [stderr] --> src/lib.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | fn adi_dump_record(rec : &AdiRecord, output: &mut String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adi_token_text` [INFO] [stderr] --> src/lib.rs:166:1 [INFO] [stderr] | [INFO] [stderr] 166 | fn adi_token_text(token: &AdiToken) -> String [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adi_parse_string` [INFO] [stderr] --> src/lib.rs:300:1 [INFO] [stderr] | [INFO] [stderr] 300 | fn adi_parse_string(source: &str) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `AdiParseState` [INFO] [stderr] --> src/lib.rs:306:1 [INFO] [stderr] | [INFO] [stderr] 306 | struct AdiParseState<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adi_parse_advance_tokens` [INFO] [stderr] --> src/lib.rs:313:1 [INFO] [stderr] | [INFO] [stderr] 313 | / fn adi_parse_advance_tokens(aps : &mut AdiParseState, howmany : u8) -> [INFO] [stderr] 314 | | Result<(), AdiParseError> [INFO] [stderr] 315 | | { [INFO] [stderr] 316 | | assert!(!aps.aps_error); [INFO] [stderr] ... | [INFO] [stderr] 333 | | Ok(()) [INFO] [stderr] 334 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adi_parse_consume_tokens` [INFO] [stderr] --> src/lib.rs:336:1 [INFO] [stderr] | [INFO] [stderr] 336 | fn adi_parse_consume_tokens(aps : &mut AdiParseState, howmany : u8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adi_parse_peek_token` [INFO] [stderr] --> src/lib.rs:353:1 [INFO] [stderr] | [INFO] [stderr] 353 | / fn adi_parse_peek_token<'a>(aps : &'a mut AdiParseState, which : u8) -> [INFO] [stderr] 354 | | Result [INFO] [stderr] 355 | | { [INFO] [stderr] 356 | | adi_parse_advance_tokens(aps, which + 1)?; [INFO] [stderr] ... | [INFO] [stderr] 370 | | return Ok(aps.aps_tokens[aps.aps_tokens.len() - 1].clone()); [INFO] [stderr] 371 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adi_parse` [INFO] [stderr] --> src/lib.rs:373:1 [INFO] [stderr] | [INFO] [stderr] 373 | fn adi_parse(source: &mut std::io::Read) -> Result [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adi_parse_header` [INFO] [stderr] --> src/lib.rs:395:1 [INFO] [stderr] | [INFO] [stderr] 395 | fn adi_parse_header(aps: &mut AdiParseState) -> Result [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adi_parse_data_specifier` [INFO] [stderr] --> src/lib.rs:485:1 [INFO] [stderr] | [INFO] [stderr] 485 | / fn adi_parse_data_specifier(aps : &mut AdiParseState) -> [INFO] [stderr] 486 | | Result [INFO] [stderr] 487 | | { [INFO] [stderr] 488 | | assert_eq!(adi_parse_peek_token(aps, 0).unwrap(), AdiToken::ADI_TOK_LAB); [INFO] [stderr] ... | [INFO] [stderr] 596 | | }) [INFO] [stderr] 597 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:231:12 [INFO] [stderr] | [INFO] [stderr] 231 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:353:1 [INFO] [stderr] | [INFO] [stderr] 353 | / fn adi_parse_peek_token<'a>(aps : &'a mut AdiParseState, which : u8) -> [INFO] [stderr] 354 | | Result [INFO] [stderr] 355 | | { [INFO] [stderr] 356 | | adi_parse_advance_tokens(aps, which + 1)?; [INFO] [stderr] ... | [INFO] [stderr] 370 | | return Ok(aps.aps_tokens[aps.aps_tokens.len() - 1].clone()); [INFO] [stderr] 371 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | assert!(aps.aps_tokens.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!aps.aps_tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.22s [INFO] running `"docker" "inspect" "a6177eb0d27c92cdca07018078910b01e5b980d4570baae7c666d44d51be6c49"` [INFO] running `"docker" "rm" "-f" "a6177eb0d27c92cdca07018078910b01e5b980d4570baae7c666d44d51be6c49"` [INFO] [stdout] a6177eb0d27c92cdca07018078910b01e5b980d4570baae7c666d44d51be6c49