[INFO] updating cached repository dat2/ms-hack-man [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dat2/ms-hack-man [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dat2/ms-hack-man" "work/ex/clippy-test-run/sources/stable/gh/dat2/ms-hack-man"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dat2/ms-hack-man'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dat2/ms-hack-man" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dat2/ms-hack-man"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dat2/ms-hack-man'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c539552eb88fdc6ec59dedf7de05492b3b357429 [INFO] sha for GitHub repo dat2/ms-hack-man: c539552eb88fdc6ec59dedf7de05492b3b357429 [INFO] validating manifest of dat2/ms-hack-man on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dat2/ms-hack-man on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dat2/ms-hack-man [INFO] finished frobbing dat2/ms-hack-man [INFO] frobbed toml for dat2/ms-hack-man written to work/ex/clippy-test-run/sources/stable/gh/dat2/ms-hack-man/Cargo.toml [INFO] started frobbing dat2/ms-hack-man [INFO] finished frobbing dat2/ms-hack-man [INFO] frobbed toml for dat2/ms-hack-man written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dat2/ms-hack-man/Cargo.toml [INFO] crate dat2/ms-hack-man has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dat2/ms-hack-man against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dat2/ms-hack-man:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5eef33368fa9e96d28a56e27f1d84b60359e94eedeba9600e934123c3387c74e [INFO] running `"docker" "start" "-a" "5eef33368fa9e96d28a56e27f1d84b60359e94eedeba9600e934123c3387c74e"` [INFO] [stderr] Checking ms-hack-man v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | snippets: snippets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `snippets` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | me: me, [INFO] [stderr] | ^^^^^^ help: replace it with: `me` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | others: others [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `others` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | snippets: snippets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `snippets` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | me: me, [INFO] [stderr] | ^^^^^^ help: replace it with: `me` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | others: others [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `others` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `game` [INFO] [stderr] --> src/main.rs:259:29 [INFO] [stderr] | [INFO] [stderr] 259 | fn action_move(&mut self, game: &Game, _time: usize) -> Move { [INFO] [stderr] | ^^^^ help: consider using `_game` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `game` [INFO] [stderr] --> src/main.rs:259:29 [INFO] [stderr] | [INFO] [stderr] 259 | fn action_move(&mut self, game: &Game, _time: usize) -> Move { [INFO] [stderr] | ^^^^ help: consider using `_game` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Bixiette` [INFO] [stderr] --> src/main.rs:193:3 [INFO] [stderr] | [INFO] [stderr] 193 | Bixiette, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Up` [INFO] [stderr] --> src/main.rs:209:3 [INFO] [stderr] | [INFO] [stderr] 209 | Up, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Down` [INFO] [stderr] --> src/main.rs:210:3 [INFO] [stderr] | [INFO] [stderr] 210 | Down, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Left` [INFO] [stderr] --> src/main.rs:211:3 [INFO] [stderr] | [INFO] [stderr] 211 | Left, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Right` [INFO] [stderr] --> src/main.rs:212:3 [INFO] [stderr] | [INFO] [stderr] 212 | Right, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Direction` [INFO] [stderr] --> src/main.rs:230:3 [INFO] [stderr] | [INFO] [stderr] 230 | Direction { direction: Direction }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DropBomb` [INFO] [stderr] --> src/main.rs:231:3 [INFO] [stderr] | [INFO] [stderr] 231 | DropBomb { direction: Direction, rounds: usize }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:22:57 [INFO] [stderr] | [INFO] [stderr] 22 | "player_names" => self.player_names = value.split(",").map(String::from).collect(), [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:79:42 [INFO] [stderr] | [INFO] [stderr] 79 | let parsed_cells: Vec<_> = field.split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Bixiette` [INFO] [stderr] --> src/main.rs:193:3 [INFO] [stderr] | [INFO] [stderr] 193 | Bixiette, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Up` [INFO] [stderr] --> src/main.rs:209:3 [INFO] [stderr] | [INFO] [stderr] 209 | Up, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Down` [INFO] [stderr] --> src/main.rs:210:3 [INFO] [stderr] | [INFO] [stderr] 210 | Down, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Left` [INFO] [stderr] --> src/main.rs:211:3 [INFO] [stderr] | [INFO] [stderr] 211 | Left, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Right` [INFO] [stderr] --> src/main.rs:212:3 [INFO] [stderr] | [INFO] [stderr] 212 | Right, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Direction` [INFO] [stderr] --> src/main.rs:230:3 [INFO] [stderr] | [INFO] [stderr] 230 | Direction { direction: Direction }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DropBomb` [INFO] [stderr] --> src/main.rs:231:3 [INFO] [stderr] | [INFO] [stderr] 231 | DropBomb { direction: Direction, rounds: usize }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:22:57 [INFO] [stderr] | [INFO] [stderr] 22 | "player_names" => self.player_names = value.split(",").map(String::from).collect(), [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | self.types.iter().cloned().find(|t| t == &CellType::CodeSnippet).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|t| t == &CellType::CodeSnippet).is_some()` with `any(|t| t == &CellType::CodeSnippet)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:126:28 [INFO] [stderr] | [INFO] [stderr] 126 | Cell { types: cell.split(";").map(|cell_type| parse_cell_type(cell_type)).collect() } [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:145:5 [INFO] [stderr] | [INFO] [stderr] 145 | / if let &CellType::Player { id } = self { [INFO] [stderr] 146 | | Some(id) [INFO] [stderr] 147 | | } else { [INFO] [stderr] 148 | | None [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 145 | if let CellType::Player { id } = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:79:42 [INFO] [stderr] | [INFO] [stderr] 79 | let parsed_cells: Vec<_> = field.split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | self.types.iter().cloned().find(|t| t == &CellType::CodeSnippet).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|t| t == &CellType::CodeSnippet).is_some()` with `any(|t| t == &CellType::CodeSnippet)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:126:28 [INFO] [stderr] | [INFO] [stderr] 126 | Cell { types: cell.split(";").map(|cell_type| parse_cell_type(cell_type)).collect() } [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:274:40 [INFO] [stderr] | [INFO] [stderr] 274 | let commands: Vec<_> = input.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:145:5 [INFO] [stderr] | [INFO] [stderr] 145 | / if let &CellType::Player { id } = self { [INFO] [stderr] 146 | | Some(id) [INFO] [stderr] 147 | | } else { [INFO] [stderr] 148 | | None [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 145 | if let CellType::Player { id } = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:274:40 [INFO] [stderr] | [INFO] [stderr] 274 | let commands: Vec<_> = input.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.72s [INFO] running `"docker" "inspect" "5eef33368fa9e96d28a56e27f1d84b60359e94eedeba9600e934123c3387c74e"` [INFO] running `"docker" "rm" "-f" "5eef33368fa9e96d28a56e27f1d84b60359e94eedeba9600e934123c3387c74e"` [INFO] [stdout] 5eef33368fa9e96d28a56e27f1d84b60359e94eedeba9600e934123c3387c74e