[INFO] updating cached repository danielwippermann/resol-vbus.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/danielwippermann/resol-vbus.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/danielwippermann/resol-vbus.rs" "work/ex/clippy-test-run/sources/stable/gh/danielwippermann/resol-vbus.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/danielwippermann/resol-vbus.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/danielwippermann/resol-vbus.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielwippermann/resol-vbus.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielwippermann/resol-vbus.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 64545f8fb4f426c9abef5cac22508f54bf432ea4 [INFO] sha for GitHub repo danielwippermann/resol-vbus.rs: 64545f8fb4f426c9abef5cac22508f54bf432ea4 [INFO] validating manifest of danielwippermann/resol-vbus.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of danielwippermann/resol-vbus.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing danielwippermann/resol-vbus.rs [INFO] finished frobbing danielwippermann/resol-vbus.rs [INFO] frobbed toml for danielwippermann/resol-vbus.rs written to work/ex/clippy-test-run/sources/stable/gh/danielwippermann/resol-vbus.rs/Cargo.toml [INFO] started frobbing danielwippermann/resol-vbus.rs [INFO] finished frobbing danielwippermann/resol-vbus.rs [INFO] frobbed toml for danielwippermann/resol-vbus.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielwippermann/resol-vbus.rs/Cargo.toml [INFO] crate danielwippermann/resol-vbus.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting danielwippermann/resol-vbus.rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielwippermann/resol-vbus.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7bc4d2ff3427c87036ecdcb4a3ab41b28aad49c84395513021f347b698248b8c [INFO] running `"docker" "start" "-a" "7bc4d2ff3427c87036ecdcb4a3ab41b28aad49c84395513021f347b698248b8c"` [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking resol-vbus v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blob_reader.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet.rs:495:13 [INFO] [stderr] | [INFO] [stderr] 495 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datagram.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_set.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_set.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | set: set, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_reader.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_writer.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blob_reader.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet.rs:495:13 [INFO] [stderr] | [INFO] [stderr] 495 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | frame_count: frame_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_count` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datagram.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | destination_address: destination_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | source_address: source_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | protocol_version: protocol_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protocol_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_set.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_set.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | set: set, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_decoder.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_reader.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | param16: param16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `param16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | param32: param32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `param32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_writer.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | destination_address: destination_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | source_address: source_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | protocol_version: protocol_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protocol_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | frame_count: frame_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | frame_data: frame_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | destination_address: destination_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | source_address: source_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | protocol_version: protocol_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protocol_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | param16: param16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `param16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | param32: param32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `param32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | destination_address: destination_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | source_address: source_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_decoder.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | protocol_version: protocol_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protocol_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_writer.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recording_writer.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_recording_writer.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | texts: texts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `texts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:361:13 [INFO] [stderr] | [INFO] [stderr] 361 | localized_texts: localized_texts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `localized_texts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:362:13 [INFO] [stderr] | [INFO] [stderr] 362 | units: units, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `units` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:363:13 [INFO] [stderr] | [INFO] [stderr] 363 | device_templates: device_templates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_templates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | packet_templates: packet_templates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_templates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:630:17 [INFO] [stderr] | [INFO] [stderr] 630 | self_address: self_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:631:17 [INFO] [stderr] | [INFO] [stderr] 631 | self_mask: self_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:632:17 [INFO] [stderr] | [INFO] [stderr] 632 | peer_address: peer_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:633:17 [INFO] [stderr] | [INFO] [stderr] 633 | peer_mask: peer_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:659:17 [INFO] [stderr] | [INFO] [stderr] 659 | destination_address: destination_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:660:17 [INFO] [stderr] | [INFO] [stderr] 660 | destination_mask: destination_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:661:17 [INFO] [stderr] | [INFO] [stderr] 661 | source_address: source_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:662:17 [INFO] [stderr] | [INFO] [stderr] 662 | source_mask: source_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:663:17 [INFO] [stderr] | [INFO] [stderr] 663 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:664:17 [INFO] [stderr] | [INFO] [stderr] 664 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:700:17 [INFO] [stderr] | [INFO] [stderr] 700 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:702:17 [INFO] [stderr] | [INFO] [stderr] 702 | parts: parts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:717:13 [INFO] [stderr] | [INFO] [stderr] 717 | bit_pos: bit_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bit_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:718:13 [INFO] [stderr] | [INFO] [stderr] 718 | mask: mask, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:720:13 [INFO] [stderr] | [INFO] [stderr] 720 | factor: factor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | device_id: device_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | self_address: self_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:378:21 [INFO] [stderr] | [INFO] [stderr] 378 | field_id: field_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `field_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:379:21 [INFO] [stderr] | [INFO] [stderr] 379 | packet_field_id: packet_field_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_field_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:382:21 [INFO] [stderr] | [INFO] [stderr] 382 | unit_family: unit_family, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:383:21 [INFO] [stderr] | [INFO] [stderr] 383 | unit_code: unit_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:384:21 [INFO] [stderr] | [INFO] [stderr] 384 | unit_text: unit_text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:386:21 [INFO] [stderr] | [INFO] [stderr] 386 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:388:21 [INFO] [stderr] | [INFO] [stderr] 388 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | packet_id: packet_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:396:9 [INFO] [stderr] | [INFO] [stderr] 396 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:397:9 [INFO] [stderr] | [INFO] [stderr] 397 | destination_address: destination_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:398:9 [INFO] [stderr] | [INFO] [stderr] 398 | source_address: source_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:399:9 [INFO] [stderr] | [INFO] [stderr] 399 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:400:9 [INFO] [stderr] | [INFO] [stderr] 400 | destination_device: destination_device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:401:9 [INFO] [stderr] | [INFO] [stderr] 401 | source_device: source_device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:403:9 [INFO] [stderr] | [INFO] [stderr] 403 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:476:13 [INFO] [stderr] | [INFO] [stderr] 476 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:477:13 [INFO] [stderr] | [INFO] [stderr] 477 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:478:13 [INFO] [stderr] | [INFO] [stderr] 478 | devices: devices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `devices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:479:13 [INFO] [stderr] | [INFO] [stderr] 479 | packets: packets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `packets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:576:13 [INFO] [stderr] | [INFO] [stderr] 576 | data_set: data_set, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `data_set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:688:13 [INFO] [stderr] | [INFO] [stderr] 688 | raw_value: raw_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:689:13 [INFO] [stderr] | [INFO] [stderr] 689 | unit_text: unit_text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:734:13 [INFO] [stderr] | [INFO] [stderr] 734 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:735:13 [INFO] [stderr] | [INFO] [stderr] 735 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:736:13 [INFO] [stderr] | [INFO] [stderr] 736 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:737:13 [INFO] [stderr] | [INFO] [stderr] 737 | raw_value: raw_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:738:13 [INFO] [stderr] | [INFO] [stderr] 738 | unit_text: unit_text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:856:25 [INFO] [stderr] | [INFO] [stderr] 856 | field_index: field_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:857:25 [INFO] [stderr] | [INFO] [stderr] 857 | raw_value: raw_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:876:13 [INFO] [stderr] | [INFO] [stderr] 876 | data_set: data_set, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `data_set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:877:13 [INFO] [stderr] | [INFO] [stderr] 877 | data_index: data_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:878:13 [INFO] [stderr] | [INFO] [stderr] 878 | packet_spec: packet_spec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_spec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:879:13 [INFO] [stderr] | [INFO] [stderr] 879 | field_index: field_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:880:13 [INFO] [stderr] | [INFO] [stderr] 880 | raw_value: raw_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:1207:17 [INFO] [stderr] | [INFO] [stderr] 1207 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:1208:17 [INFO] [stderr] | [INFO] [stderr] 1208 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_list_reader.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | file_list: file_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp_connector.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tcp_connector.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | write!(&stream, "+HELLO\r\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tcp_connector.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | write!(&stream, "+OK\r\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tcp_connector.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | write!(&stream, "+OK\r\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tcp_connector.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | write!(&stream, "+OK\r\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tcp_connector.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | write!(&stream, "+OK\r\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/live_data_recording_writer.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | texts: texts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `texts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:361:13 [INFO] [stderr] | [INFO] [stderr] 361 | localized_texts: localized_texts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `localized_texts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:362:13 [INFO] [stderr] | [INFO] [stderr] 362 | units: units, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `units` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:363:13 [INFO] [stderr] | [INFO] [stderr] 363 | device_templates: device_templates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_templates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | packet_templates: packet_templates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_templates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:630:17 [INFO] [stderr] | [INFO] [stderr] 630 | self_address: self_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:631:17 [INFO] [stderr] | [INFO] [stderr] 631 | self_mask: self_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:632:17 [INFO] [stderr] | [INFO] [stderr] 632 | peer_address: peer_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:633:17 [INFO] [stderr] | [INFO] [stderr] 633 | peer_mask: peer_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:659:17 [INFO] [stderr] | [INFO] [stderr] 659 | destination_address: destination_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:660:17 [INFO] [stderr] | [INFO] [stderr] 660 | destination_mask: destination_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:661:17 [INFO] [stderr] | [INFO] [stderr] 661 | source_address: source_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:662:17 [INFO] [stderr] | [INFO] [stderr] 662 | source_mask: source_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:663:17 [INFO] [stderr] | [INFO] [stderr] 663 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:664:17 [INFO] [stderr] | [INFO] [stderr] 664 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:700:17 [INFO] [stderr] | [INFO] [stderr] 700 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:702:17 [INFO] [stderr] | [INFO] [stderr] 702 | parts: parts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:717:13 [INFO] [stderr] | [INFO] [stderr] 717 | bit_pos: bit_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bit_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:718:13 [INFO] [stderr] | [INFO] [stderr] 718 | mask: mask, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification_file.rs:720:13 [INFO] [stderr] | [INFO] [stderr] 720 | factor: factor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | device_id: device_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | self_address: self_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:378:21 [INFO] [stderr] | [INFO] [stderr] 378 | field_id: field_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `field_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:379:21 [INFO] [stderr] | [INFO] [stderr] 379 | packet_field_id: packet_field_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_field_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:382:21 [INFO] [stderr] | [INFO] [stderr] 382 | unit_family: unit_family, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:383:21 [INFO] [stderr] | [INFO] [stderr] 383 | unit_code: unit_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:384:21 [INFO] [stderr] | [INFO] [stderr] 384 | unit_text: unit_text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:386:21 [INFO] [stderr] | [INFO] [stderr] 386 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:388:21 [INFO] [stderr] | [INFO] [stderr] 388 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | packet_id: packet_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:396:9 [INFO] [stderr] | [INFO] [stderr] 396 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:397:9 [INFO] [stderr] | [INFO] [stderr] 397 | destination_address: destination_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:398:9 [INFO] [stderr] | [INFO] [stderr] 398 | source_address: source_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:399:9 [INFO] [stderr] | [INFO] [stderr] 399 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:400:9 [INFO] [stderr] | [INFO] [stderr] 400 | destination_device: destination_device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:401:9 [INFO] [stderr] | [INFO] [stderr] 401 | source_device: source_device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:403:9 [INFO] [stderr] | [INFO] [stderr] 403 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:476:13 [INFO] [stderr] | [INFO] [stderr] 476 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:477:13 [INFO] [stderr] | [INFO] [stderr] 477 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:478:13 [INFO] [stderr] | [INFO] [stderr] 478 | devices: devices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `devices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:479:13 [INFO] [stderr] | [INFO] [stderr] 479 | packets: packets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `packets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:576:13 [INFO] [stderr] | [INFO] [stderr] 576 | data_set: data_set, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `data_set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:688:13 [INFO] [stderr] | [INFO] [stderr] 688 | raw_value: raw_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:689:13 [INFO] [stderr] | [INFO] [stderr] 689 | unit_text: unit_text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:734:13 [INFO] [stderr] | [INFO] [stderr] 734 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:735:13 [INFO] [stderr] | [INFO] [stderr] 735 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:736:13 [INFO] [stderr] | [INFO] [stderr] 736 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:737:13 [INFO] [stderr] | [INFO] [stderr] 737 | raw_value: raw_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:738:13 [INFO] [stderr] | [INFO] [stderr] 738 | unit_text: unit_text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:856:25 [INFO] [stderr] | [INFO] [stderr] 856 | field_index: field_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:857:25 [INFO] [stderr] | [INFO] [stderr] 857 | raw_value: raw_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:876:13 [INFO] [stderr] | [INFO] [stderr] 876 | data_set: data_set, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `data_set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:877:13 [INFO] [stderr] | [INFO] [stderr] 877 | data_index: data_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:878:13 [INFO] [stderr] | [INFO] [stderr] 878 | packet_spec: packet_spec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_spec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:879:13 [INFO] [stderr] | [INFO] [stderr] 879 | field_index: field_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:880:13 [INFO] [stderr] | [INFO] [stderr] 880 | raw_value: raw_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:1207:17 [INFO] [stderr] | [INFO] [stderr] 1207 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/specification.rs:1208:17 [INFO] [stderr] | [INFO] [stderr] 1208 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_list_reader.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | file_list: file_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp_connector.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tcp_connector.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | write!(&stream, "+HELLO\r\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tcp_connector.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | write!(&stream, "+OK\r\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tcp_connector.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | write!(&stream, "+OK\r\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tcp_connector.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | write!(&stream, "+OK\r\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tcp_connector.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | write!(&stream, "+OK\r\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils.rs:150:21 [INFO] [stderr] | [INFO] [stderr] 150 | const CRC16_TABLE: &'static [u16] = &[ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/recording_decoder.rs:46:55 [INFO] [stderr] | [INFO] [stderr] 46 | let timestamp_ns = (timestamp_ms % 1000) as u32 * 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:605:48 [INFO] [stderr] | [INFO] [stderr] 605 | raw_value: timestamp.timestamp() - 978307200, [INFO] [stderr] | ^^^^^^^^^ help: consider: `978_307_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/specification.rs:696:22 [INFO] [stderr] | [INFO] [stderr] 696 | const WEEKDAYS_EN: [&'static str; 7] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/specification.rs:707:22 [INFO] [stderr] | [INFO] [stderr] 707 | const WEEKDAYS_DE: [&'static str; 7] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/specification.rs:718:22 [INFO] [stderr] | [INFO] [stderr] 718 | const WEEKDAYS_FR: [&'static str; 7] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:802:64 [INFO] [stderr] | [INFO] [stderr] 802 | let timestamp = UTC.timestamp(self.raw_value + 978307200, 0); [INFO] [stderr] | ^^^^^^^^^ help: consider: `978_307_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_data.rs:1:25 [INFO] [stderr] | [INFO] [stderr] 1 | pub const LIVE_DATA_1: &'static [u8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_data.rs:66:29 [INFO] [stderr] | [INFO] [stderr] 66 | pub const LIVE_TELEGRAM_1: &'static [u8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_data.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | pub const RECORDING_1: &'static [u8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_data.rs:138:25 [INFO] [stderr] | [INFO] [stderr] 138 | pub const RECORDING_2: &'static [u8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_data.rs:200:25 [INFO] [stderr] | [INFO] [stderr] 200 | pub const RECORDING_3: &'static [u8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_data.rs:223:35 [INFO] [stderr] | [INFO] [stderr] 223 | pub const LIVE_DATA_RECORDING_1: &'static [u8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test_data.rs:311:25 [INFO] [stderr] | [INFO] [stderr] 311 | pub const SPEC_FILE_1: &'static [u8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/test_utils.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn reset(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils.rs:150:21 [INFO] [stderr] | [INFO] [stderr] 150 | const CRC16_TABLE: &'static [u16] = &[ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/header.rs:149:38 [INFO] [stderr] | [INFO] [stderr] 149 | timestamp: utc_timestamp(1485688933), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packet.rs:540:42 [INFO] [stderr] | [INFO] [stderr] 540 | timestamp: utc_timestamp(1485688933), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/datagram.rs:178:39 [INFO] [stderr] | [INFO] [stderr] 178 | let timestamp = utc_timestamp(1485688933); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/datagram.rs:190:22 [INFO] [stderr] | [INFO] [stderr] 190 | param32: 0x1b1c1d1e, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1b1c_1d1e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/telegram.rs:283:42 [INFO] [stderr] | [INFO] [stderr] 283 | timestamp: utc_timestamp(1485688933), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:384:39 [INFO] [stderr] | [INFO] [stderr] 384 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:399:39 [INFO] [stderr] | [INFO] [stderr] 399 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:414:39 [INFO] [stderr] | [INFO] [stderr] 414 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:429:39 [INFO] [stderr] | [INFO] [stderr] 429 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:444:39 [INFO] [stderr] | [INFO] [stderr] 444 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:459:39 [INFO] [stderr] | [INFO] [stderr] 459 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:474:39 [INFO] [stderr] | [INFO] [stderr] 474 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:507:39 [INFO] [stderr] | [INFO] [stderr] 507 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:633:39 [INFO] [stderr] | [INFO] [stderr] 633 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:828:39 [INFO] [stderr] | [INFO] [stderr] 828 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:834:20 [INFO] [stderr] | [INFO] [stderr] 834 | assert_eq!(541127499104566154, result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `541_127_499_104_566_154` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:839:20 [INFO] [stderr] | [INFO] [stderr] 839 | assert_eq!(6066488998843577430, result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_066_488_998_843_577_430` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:844:20 [INFO] [stderr] | [INFO] [stderr] 844 | assert_eq!(2688669052981416192, result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `2_688_669_052_981_416_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data_set.rs:236:39 [INFO] [stderr] | [INFO] [stderr] 236 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data_set.rs:287:39 [INFO] [stderr] | [INFO] [stderr] 287 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data_set.rs:309:39 [INFO] [stderr] | [INFO] [stderr] 309 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data_set.rs:327:39 [INFO] [stderr] | [INFO] [stderr] 327 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data_set.rs:353:39 [INFO] [stderr] | [INFO] [stderr] 353 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data_set.rs:389:39 [INFO] [stderr] | [INFO] [stderr] 389 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data_set.rs:429:39 [INFO] [stderr] | [INFO] [stderr] 429 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data_set.rs:440:20 [INFO] [stderr] | [INFO] [stderr] 440 | assert_eq!(13725728793204414233, result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `13_725_728_793_204_414_233` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_decoder.rs:228:39 [INFO] [stderr] | [INFO] [stderr] 228 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_encoder.rs:83:39 [INFO] [stderr] | [INFO] [stderr] 83 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_encoder.rs:101:39 [INFO] [stderr] | [INFO] [stderr] 101 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_writer.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_stream.rs:394:39 [INFO] [stderr] | [INFO] [stderr] 394 | let timestamp = utc_timestamp(1544209081); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_544_209_081` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_stream.rs:439:39 [INFO] [stderr] | [INFO] [stderr] 439 | let timestamp = utc_timestamp(1544209081); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_544_209_081` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_stream.rs:502:66 [INFO] [stderr] | [INFO] [stderr] 502 | let data = data_from_checked_bytes(utc_timestamp(1544209081), 0, &bytes [0..size]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_544_209_081` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_stream.rs:572:21 [INFO] [stderr] | [INFO] [stderr] 572 | let value = 0x56789abc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5678_9abc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_stream.rs:602:21 [INFO] [stderr] | [INFO] [stderr] 602 | let value = 0x56789abc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5678_9abc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_stream.rs:632:29 [INFO] [stderr] | [INFO] [stderr] 632 | let value_id_hash = 0x56789abc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5678_9abc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_stream.rs:648:29 [INFO] [stderr] | [INFO] [stderr] 648 | let value_id_hash = 0x56789abc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5678_9abc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_stream.rs:716:21 [INFO] [stderr] | [INFO] [stderr] 716 | let value = 0x56789abc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5678_9abc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/recording_decoder.rs:46:55 [INFO] [stderr] | [INFO] [stderr] 46 | let timestamp_ns = (timestamp_ms % 1000) as u32 * 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/recording_encoder.rs:123:39 [INFO] [stderr] | [INFO] [stderr] 123 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/recording_encoder.rs:133:39 [INFO] [stderr] | [INFO] [stderr] 133 | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_485_688_933` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:71:49 [INFO] [stderr] | [INFO] [stderr] 71 | let start_timestamp = UTC.timestamp(1486857602, 94000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_602` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:71:61 [INFO] [stderr] | [INFO] [stderr] 71 | let start_timestamp = UTC.timestamp(1486857602, 94000000); [INFO] [stderr] | ^^^^^^^^ help: consider: `94_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:72:47 [INFO] [stderr] | [INFO] [stderr] 72 | let end_timestamp = UTC.timestamp(1486857602, 95000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_602` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:72:59 [INFO] [stderr] | [INFO] [stderr] 72 | let end_timestamp = UTC.timestamp(1486857602, 95000000); [INFO] [stderr] | ^^^^^^^^ help: consider: `95_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:76:49 [INFO] [stderr] | [INFO] [stderr] 76 | let start_timestamp = UTC.timestamp(1486857602, 283000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_602` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:76:61 [INFO] [stderr] | [INFO] [stderr] 76 | let start_timestamp = UTC.timestamp(1486857602, 283000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `283_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:77:47 [INFO] [stderr] | [INFO] [stderr] 77 | let end_timestamp = UTC.timestamp(1486857602, 284000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_602` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:77:59 [INFO] [stderr] | [INFO] [stderr] 77 | let end_timestamp = UTC.timestamp(1486857602, 284000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `284_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:81:49 [INFO] [stderr] | [INFO] [stderr] 81 | let start_timestamp = UTC.timestamp(1486857602, 474000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_602` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:81:61 [INFO] [stderr] | [INFO] [stderr] 81 | let start_timestamp = UTC.timestamp(1486857602, 474000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `474_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:82:47 [INFO] [stderr] | [INFO] [stderr] 82 | let end_timestamp = UTC.timestamp(1486857602, 474000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_602` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:82:59 [INFO] [stderr] | [INFO] [stderr] 82 | let end_timestamp = UTC.timestamp(1486857602, 474000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `474_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:86:49 [INFO] [stderr] | [INFO] [stderr] 86 | let start_timestamp = UTC.timestamp(1486857602, 683000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_602` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:86:61 [INFO] [stderr] | [INFO] [stderr] 86 | let start_timestamp = UTC.timestamp(1486857602, 683000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `683_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:87:47 [INFO] [stderr] | [INFO] [stderr] 87 | let end_timestamp = UTC.timestamp(1486857602, 704000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_602` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:87:59 [INFO] [stderr] | [INFO] [stderr] 87 | let end_timestamp = UTC.timestamp(1486857602, 704000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `704_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:91:49 [INFO] [stderr] | [INFO] [stderr] 91 | let start_timestamp = UTC.timestamp(1486857602, 863000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_602` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:91:61 [INFO] [stderr] | [INFO] [stderr] 91 | let start_timestamp = UTC.timestamp(1486857602, 863000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `863_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:92:47 [INFO] [stderr] | [INFO] [stderr] 92 | let end_timestamp = UTC.timestamp(1486857602, 864000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_602` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:92:59 [INFO] [stderr] | [INFO] [stderr] 92 | let end_timestamp = UTC.timestamp(1486857602, 864000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `864_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:96:49 [INFO] [stderr] | [INFO] [stderr] 96 | let start_timestamp = UTC.timestamp(1486857603, 123000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_603` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:96:61 [INFO] [stderr] | [INFO] [stderr] 96 | let start_timestamp = UTC.timestamp(1486857603, 123000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:97:47 [INFO] [stderr] | [INFO] [stderr] 97 | let end_timestamp = UTC.timestamp(1486857603, 124000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_603` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:97:59 [INFO] [stderr] | [INFO] [stderr] 97 | let end_timestamp = UTC.timestamp(1486857603, 124000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `124_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:101:49 [INFO] [stderr] | [INFO] [stderr] 101 | let start_timestamp = UTC.timestamp(1486857603, 314000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_603` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:101:61 [INFO] [stderr] | [INFO] [stderr] 101 | let start_timestamp = UTC.timestamp(1486857603, 314000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `314_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:102:47 [INFO] [stderr] | [INFO] [stderr] 102 | let end_timestamp = UTC.timestamp(1486857603, 314000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_603` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:102:59 [INFO] [stderr] | [INFO] [stderr] 102 | let end_timestamp = UTC.timestamp(1486857603, 314000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `314_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:106:49 [INFO] [stderr] | [INFO] [stderr] 106 | let start_timestamp = UTC.timestamp(1486857603, 534000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_603` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:106:61 [INFO] [stderr] | [INFO] [stderr] 106 | let start_timestamp = UTC.timestamp(1486857603, 534000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `534_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:107:47 [INFO] [stderr] | [INFO] [stderr] 107 | let end_timestamp = UTC.timestamp(1486857603, 535000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_603` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:107:59 [INFO] [stderr] | [INFO] [stderr] 107 | let end_timestamp = UTC.timestamp(1486857603, 535000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `535_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:111:49 [INFO] [stderr] | [INFO] [stderr] 111 | let start_timestamp = UTC.timestamp(1486857603, 763000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_603` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:111:61 [INFO] [stderr] | [INFO] [stderr] 111 | let start_timestamp = UTC.timestamp(1486857603, 763000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `763_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:112:47 [INFO] [stderr] | [INFO] [stderr] 112 | let end_timestamp = UTC.timestamp(1486857603, 764000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_603` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:112:59 [INFO] [stderr] | [INFO] [stderr] 112 | let end_timestamp = UTC.timestamp(1486857603, 764000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `764_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:116:49 [INFO] [stderr] | [INFO] [stderr] 116 | let start_timestamp = UTC.timestamp(1486857604, 114000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_604` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:116:61 [INFO] [stderr] | [INFO] [stderr] 116 | let start_timestamp = UTC.timestamp(1486857604, 114000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `114_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:117:47 [INFO] [stderr] | [INFO] [stderr] 117 | let end_timestamp = UTC.timestamp(1486857604, 114000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_604` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:117:59 [INFO] [stderr] | [INFO] [stderr] 117 | let end_timestamp = UTC.timestamp(1486857604, 114000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `114_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:121:49 [INFO] [stderr] | [INFO] [stderr] 121 | let start_timestamp = UTC.timestamp(1486857605, 94000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:121:61 [INFO] [stderr] | [INFO] [stderr] 121 | let start_timestamp = UTC.timestamp(1486857605, 94000000); [INFO] [stderr] | ^^^^^^^^ help: consider: `94_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:122:47 [INFO] [stderr] | [INFO] [stderr] 122 | let end_timestamp = UTC.timestamp(1486857605, 94000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:122:59 [INFO] [stderr] | [INFO] [stderr] 122 | let end_timestamp = UTC.timestamp(1486857605, 94000000); [INFO] [stderr] | ^^^^^^^^ help: consider: `94_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:126:49 [INFO] [stderr] | [INFO] [stderr] 126 | let start_timestamp = UTC.timestamp(1486857605, 283000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:126:61 [INFO] [stderr] | [INFO] [stderr] 126 | let start_timestamp = UTC.timestamp(1486857605, 283000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `283_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:127:47 [INFO] [stderr] | [INFO] [stderr] 127 | let end_timestamp = UTC.timestamp(1486857605, 284000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:127:59 [INFO] [stderr] | [INFO] [stderr] 127 | let end_timestamp = UTC.timestamp(1486857605, 284000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `284_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:131:49 [INFO] [stderr] | [INFO] [stderr] 131 | let start_timestamp = UTC.timestamp(1486857605, 474000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:131:61 [INFO] [stderr] | [INFO] [stderr] 131 | let start_timestamp = UTC.timestamp(1486857605, 474000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `474_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:132:47 [INFO] [stderr] | [INFO] [stderr] 132 | let end_timestamp = UTC.timestamp(1486857605, 474000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:132:59 [INFO] [stderr] | [INFO] [stderr] 132 | let end_timestamp = UTC.timestamp(1486857605, 474000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `474_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:136:49 [INFO] [stderr] | [INFO] [stderr] 136 | let start_timestamp = UTC.timestamp(1486857605, 703000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:136:61 [INFO] [stderr] | [INFO] [stderr] 136 | let start_timestamp = UTC.timestamp(1486857605, 703000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `703_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:137:47 [INFO] [stderr] | [INFO] [stderr] 137 | let end_timestamp = UTC.timestamp(1486857605, 704000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:137:59 [INFO] [stderr] | [INFO] [stderr] 137 | let end_timestamp = UTC.timestamp(1486857605, 704000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `704_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:141:49 [INFO] [stderr] | [INFO] [stderr] 141 | let start_timestamp = UTC.timestamp(1486857605, 863000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:141:61 [INFO] [stderr] | [INFO] [stderr] 141 | let start_timestamp = UTC.timestamp(1486857605, 863000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `863_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:142:47 [INFO] [stderr] | [INFO] [stderr] 142 | let end_timestamp = UTC.timestamp(1486857605, 863000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:142:59 [INFO] [stderr] | [INFO] [stderr] 142 | let end_timestamp = UTC.timestamp(1486857605, 863000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `863_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:146:49 [INFO] [stderr] | [INFO] [stderr] 146 | let start_timestamp = UTC.timestamp(1486857606, 123000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_606` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:146:61 [INFO] [stderr] | [INFO] [stderr] 146 | let start_timestamp = UTC.timestamp(1486857606, 123000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:147:47 [INFO] [stderr] | [INFO] [stderr] 147 | let end_timestamp = UTC.timestamp(1486857606, 124000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_606` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:147:59 [INFO] [stderr] | [INFO] [stderr] 147 | let end_timestamp = UTC.timestamp(1486857606, 124000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `124_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:151:49 [INFO] [stderr] | [INFO] [stderr] 151 | let start_timestamp = UTC.timestamp(1486857606, 314000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_606` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:151:61 [INFO] [stderr] | [INFO] [stderr] 151 | let start_timestamp = UTC.timestamp(1486857606, 314000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `314_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:152:47 [INFO] [stderr] | [INFO] [stderr] 152 | let end_timestamp = UTC.timestamp(1486857606, 314000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_606` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:152:59 [INFO] [stderr] | [INFO] [stderr] 152 | let end_timestamp = UTC.timestamp(1486857606, 314000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `314_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:156:49 [INFO] [stderr] | [INFO] [stderr] 156 | let start_timestamp = UTC.timestamp(1486857606, 503000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_606` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:156:61 [INFO] [stderr] | [INFO] [stderr] 156 | let start_timestamp = UTC.timestamp(1486857606, 503000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `503_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:157:47 [INFO] [stderr] | [INFO] [stderr] 157 | let end_timestamp = UTC.timestamp(1486857606, 504000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_486_857_606` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/live_data_recording_writer.rs:157:59 [INFO] [stderr] | [INFO] [stderr] 157 | let end_timestamp = UTC.timestamp(1486857606, 504000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `504_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification_file.rs:1109:43 [INFO] [stderr] | [INFO] [stderr] 1109 | check_next_part(3, 0, 0xFF, true, 16777216); [INFO] [stderr] | ^^^^^^^^ help: consider: `16_777_216` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification_file.rs:1110:45 [INFO] [stderr] | [INFO] [stderr] 1110 | check_next_part(36, 0, 0xFF, false, 1000000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification_file.rs:1111:45 [INFO] [stderr] | [INFO] [stderr] 1111 | check_next_part(37, 0, 0xFF, false, 256000000000); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `256_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification_file.rs:1112:45 [INFO] [stderr] | [INFO] [stderr] 1112 | check_next_part(38, 0, 0xFF, false, 65536000000000); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `65_536_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification_file.rs:1113:44 [INFO] [stderr] | [INFO] [stderr] 1113 | check_next_part(39, 0, 0xFF, true, 16777216000000000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `16_777_216_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:605:48 [INFO] [stderr] | [INFO] [stderr] 605 | raw_value: timestamp.timestamp() - 978307200, [INFO] [stderr] | ^^^^^^^^^ help: consider: `978_307_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/specification.rs:696:22 [INFO] [stderr] | [INFO] [stderr] 696 | const WEEKDAYS_EN: [&'static str; 7] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/specification.rs:707:22 [INFO] [stderr] | [INFO] [stderr] 707 | const WEEKDAYS_DE: [&'static str; 7] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/specification.rs:718:22 [INFO] [stderr] | [INFO] [stderr] 718 | const WEEKDAYS_FR: [&'static str; 7] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:802:64 [INFO] [stderr] | [INFO] [stderr] 802 | let timestamp = UTC.timestamp(self.raw_value + 978307200, 0); [INFO] [stderr] | ^^^^^^^^^ help: consider: `978_307_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:984:60 [INFO] [stderr] | [INFO] [stderr] 984 | assert_eq!("12345.7", fmt_to_string(En, Number, 1, 123457, "")); [INFO] [stderr] | ^^^^^^ help: consider: `123_457` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:985:61 [INFO] [stderr] | [INFO] [stderr] 985 | assert_eq!("12345.68", fmt_to_string(En, Number, 2, 1234568, "")); [INFO] [stderr] | ^^^^^^^ help: consider: `1_234_568` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:986:62 [INFO] [stderr] | [INFO] [stderr] 986 | assert_eq!("12345.679", fmt_to_string(En, Number, 3, 12345679, "")); [INFO] [stderr] | ^^^^^^^^ help: consider: `12_345_679` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:987:63 [INFO] [stderr] | [INFO] [stderr] 987 | assert_eq!("12345.6789", fmt_to_string(En, Number, 4, 123456789, "")); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:988:66 [INFO] [stderr] | [INFO] [stderr] 988 | assert_eq!("1.2345678900", fmt_to_string(En, Number, 10, 12345678900, "")); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_345_678_900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:989:66 [INFO] [stderr] | [INFO] [stderr] 989 | assert_eq!("1,2345678900", fmt_to_string(De, Number, 10, 12345678900, "")); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_345_678_900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:990:66 [INFO] [stderr] | [INFO] [stderr] 990 | assert_eq!("1,2345678900", fmt_to_string(Fr, Number, 10, 12345678900, "")); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_345_678_900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1000:75 [INFO] [stderr] | [INFO] [stderr] 1000 | assert_eq!("22/12/2013 15:17:42", fmt_to_string(En, DateTime, 10, 409418262, " ignore this unit")); [INFO] [stderr] | ^^^^^^^^^ help: consider: `409_418_262` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1001:75 [INFO] [stderr] | [INFO] [stderr] 1001 | assert_eq!("22.12.2013 15:17:42", fmt_to_string(De, DateTime, 10, 409418262, " ignore this unit")); [INFO] [stderr] | ^^^^^^^^^ help: consider: `409_418_262` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1002:75 [INFO] [stderr] | [INFO] [stderr] 1002 | assert_eq!("22/12/2013 15:17:42", fmt_to_string(Fr, DateTime, 10, 409418262, " ignore this unit")); [INFO] [stderr] | ^^^^^^^^^ help: consider: `409_418_262` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1162:25 [INFO] [stderr] | [INFO] [stderr] 1162 | assert_eq!(Some(0x12345678), packet_spec.get_field_spec("000_4_0").unwrap().raw_value_i64(buf)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1165:25 [INFO] [stderr] | [INFO] [stderr] 1165 | assert_eq!(Some(0x345678), packet_spec.get_field_spec("000_4_0").unwrap().raw_value_i64(&buf [0..3])); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0034_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1187:25 [INFO] [stderr] | [INFO] [stderr] 1187 | assert_eq!(Some(0x12345678 as f64), packet_spec.get_field_spec("000_4_0").unwrap().raw_value_f64(buf)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1188:25 [INFO] [stderr] | [INFO] [stderr] 1188 | assert_eq!(Some(888.8000000000001), packet_spec.get_field_spec("004_4_0").unwrap().raw_value_f64(buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `888.800_000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1189:26 [INFO] [stderr] | [INFO] [stderr] 1189 | assert_eq!(Some(-888.8000000000001), packet_spec.get_field_spec("008_4_0").unwrap().raw_value_f64(buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `888.800_000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1190:25 [INFO] [stderr] | [INFO] [stderr] 1190 | assert_eq!(Some(0x345678 as f64), packet_spec.get_field_spec("000_4_0").unwrap().raw_value_f64(&buf [0..3])); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0034_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1226:58 [INFO] [stderr] | [INFO] [stderr] 1226 | assert_eq!("12345.7", fmt_raw_value(&field_spec, 123457, false)); [INFO] [stderr] | ^^^^^^ help: consider: `123_457` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1229:59 [INFO] [stderr] | [INFO] [stderr] 1229 | assert_eq!("12345.68", fmt_raw_value(&field_spec, 1234568, false)); [INFO] [stderr] | ^^^^^^^ help: consider: `1_234_568` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1232:60 [INFO] [stderr] | [INFO] [stderr] 1232 | assert_eq!("12345.679", fmt_raw_value(&field_spec, 12345679, false)); [INFO] [stderr] | ^^^^^^^^ help: consider: `12_345_679` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1235:61 [INFO] [stderr] | [INFO] [stderr] 1235 | assert_eq!("12345.6789", fmt_raw_value(&field_spec, 123456789, false)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1238:61 [INFO] [stderr] | [INFO] [stderr] 1238 | assert_eq!("12345.0009", fmt_raw_value(&field_spec, 123450009, false)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_450_009` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1241:63 [INFO] [stderr] | [INFO] [stderr] 1241 | assert_eq!("1.2345678900", fmt_raw_value(&field_spec, 12345678900, false)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_345_678_900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/specification.rs:1250:70 [INFO] [stderr] | [INFO] [stderr] 1250 | assert_eq!("22/12/2013 15:17:42", fmt_raw_value(&field_spec, 409418262, true)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `409_418_262` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:199:48 [INFO] [stderr] | [INFO] [stderr] 199 | crc = (crc >> 8) ^ CRC16_TABLE [(crc ^ *byte as u16) as usize & 0xFF]; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/packet.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn packet_id_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/data.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Packet(Packet), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 38 | Packet(Box), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/data.rs:194:87 [INFO] [stderr] | [INFO] [stderr] 194 | } else if left_header.destination_address != right_header.destination_address { [INFO] [stderr] | _______________________________________________________________________________________^ [INFO] [stderr] 195 | | false [INFO] [stderr] 196 | | } else if left_header.source_address != right_header.source_address { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/data.rs:192:56 [INFO] [stderr] | [INFO] [stderr] 192 | if left_header.channel != right_header.channel { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 193 | | false [INFO] [stderr] 194 | | } else if left_header.destination_address != right_header.destination_address { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/data.rs:204:25 [INFO] [stderr] | [INFO] [stderr] 204 | / if left_packet.command != right_packet.command { [INFO] [stderr] 205 | | false [INFO] [stderr] 206 | | } else { [INFO] [stderr] 207 | | true [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `!(left_packet.command != right_packet.command)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/data.rs:219:32 [INFO] [stderr] | [INFO] [stderr] 219 | } else if left_dgram.param16 != right_dgram.param16 { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 220 | | false [INFO] [stderr] 221 | | } else { [INFO] [stderr] 222 | | true [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `!(left_dgram.param16 != right_dgram.param16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/data.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | / if left_tgram.command != right_tgram.command { [INFO] [stderr] 231 | | false [INFO] [stderr] 232 | | } else { [INFO] [stderr] 233 | | true [INFO] [stderr] 234 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `!(left_tgram.command != right_tgram.command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: item `data_set::DataSet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/data_set.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / impl DataSet { [INFO] [stderr] 50 | | [INFO] [stderr] 51 | | /// Construct an empty `DataSet`. [INFO] [stderr] 52 | | pub fn new() -> DataSet { [INFO] [stderr] ... | [INFO] [stderr] 190 | | [INFO] [stderr] 191 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_decoder.rs:36:67 [INFO] [stderr] | [INFO] [stderr] 36 | } else if !calc_and_compare_checksum_v0(&buf [1..10]) { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 37 | | Malformed [INFO] [stderr] 38 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_decoder.rs:34:49 [INFO] [stderr] | [INFO] [stderr] 34 | } else if has_msb_set(&buf [6..10]) { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 35 | | Malformed [INFO] [stderr] 36 | | } else if !calc_and_compare_checksum_v0(&buf [1..10]) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_decoder.rs:62:67 [INFO] [stderr] | [INFO] [stderr] 62 | } else if !calc_and_compare_checksum_v0(&buf [1..16]) { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 63 | | Malformed [INFO] [stderr] 64 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_decoder.rs:60:49 [INFO] [stderr] | [INFO] [stderr] 60 | } else if has_msb_set(&buf [6..16]) { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 61 | | Malformed [INFO] [stderr] 62 | | } else if !calc_and_compare_checksum_v0(&buf [1..16]) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_decoder.rs:72:66 [INFO] [stderr] | [INFO] [stderr] 72 | } else if !calc_and_compare_checksum_v0(&buf [1..8]) { [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 73 | | Malformed [INFO] [stderr] 74 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_decoder.rs:70:48 [INFO] [stderr] | [INFO] [stderr] 70 | } else if has_msb_set(&buf [6..8]) { [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 71 | | Malformed [INFO] [stderr] 72 | | } else if !calc_and_compare_checksum_v0(&buf [1..8]) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/live_data_reader.rs:83:23 [INFO] [stderr] | [INFO] [stderr] 83 | let data = if bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/live_data_reader.rs:145:23 [INFO] [stderr] | [INFO] [stderr] 145 | let data = if bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:72:45 [INFO] [stderr] | [INFO] [stderr] 72 | let timeout = Duration::from_millis(timeout_ms as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(timeout_ms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:78:49 [INFO] [stderr] | [INFO] [stderr] 78 | let mut timeout = Duration::from_millis(initial_timeout_ms as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(initial_timeout_ms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/live_data_stream.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | timeout = timeout + timeout_incr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timeout += timeout_incr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:138:62 [INFO] [stderr] | [INFO] [stderr] 138 | let tx_data = self.create_datagram(address, 0x0300 | (sub_index as u16), value_index, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(sub_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:146:70 [INFO] [stderr] | [INFO] [stderr] 146 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 147 | | false [INFO] [stderr] 148 | | } else if dgram.command != (0x0100 | (sub_index as u16)) { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:144:73 [INFO] [stderr] | [INFO] [stderr] 144 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 145 | | false [INFO] [stderr] 146 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:148:58 [INFO] [stderr] | [INFO] [stderr] 148 | } else if dgram.command != (0x0100 | (sub_index as u16)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(sub_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:150:28 [INFO] [stderr] | [INFO] [stderr] 150 | } else if dgram.param16 != value_index { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 151 | | false [INFO] [stderr] 152 | | } else { [INFO] [stderr] 153 | | true [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.param16 != value_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:163:62 [INFO] [stderr] | [INFO] [stderr] 163 | let tx_data = self.create_datagram(address, 0x0200 | (sub_index as u16), value_index, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(sub_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:171:70 [INFO] [stderr] | [INFO] [stderr] 171 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 172 | | false [INFO] [stderr] 173 | | } else if dgram.command != (0x0100 | (sub_index as u16)) { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:169:73 [INFO] [stderr] | [INFO] [stderr] 169 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 170 | | false [INFO] [stderr] 171 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:173:58 [INFO] [stderr] | [INFO] [stderr] 173 | } else if dgram.command != (0x0100 | (sub_index as u16)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(sub_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:175:28 [INFO] [stderr] | [INFO] [stderr] 175 | } else if dgram.param16 != value_index { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 176 | | false [INFO] [stderr] 177 | | } else { [INFO] [stderr] 178 | | true [INFO] [stderr] 179 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.param16 != value_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:196:70 [INFO] [stderr] | [INFO] [stderr] 196 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 197 | | false [INFO] [stderr] 198 | | } else if (dgram.command != 0x0100) && (dgram.command != 0x1001) { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:194:73 [INFO] [stderr] | [INFO] [stderr] 194 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 195 | | false [INFO] [stderr] 196 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:200:28 [INFO] [stderr] | [INFO] [stderr] 200 | } else if dgram.param16 != value_index { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 201 | | false [INFO] [stderr] 202 | | } else { [INFO] [stderr] 203 | | true [INFO] [stderr] 204 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.param16 != value_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:221:70 [INFO] [stderr] | [INFO] [stderr] 221 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 222 | | false [INFO] [stderr] 223 | | } else if (dgram.command != 0x0100) && (dgram.command != 0x1101) { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:219:73 [INFO] [stderr] | [INFO] [stderr] 219 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 220 | | false [INFO] [stderr] 221 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:225:28 [INFO] [stderr] | [INFO] [stderr] 225 | } else if dgram.param32 != value_id_hash { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 226 | | false [INFO] [stderr] 227 | | } else { [INFO] [stderr] 228 | | true [INFO] [stderr] 229 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.param32 != value_id_hash)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:246:70 [INFO] [stderr] | [INFO] [stderr] 246 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 247 | | false [INFO] [stderr] 248 | | } else if dgram.command != 0x1301 { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:244:73 [INFO] [stderr] | [INFO] [stderr] 244 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 245 | | false [INFO] [stderr] 246 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:248:28 [INFO] [stderr] | [INFO] [stderr] 248 | } else if dgram.command != 0x1301 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 249 | | false [INFO] [stderr] 250 | | } else { [INFO] [stderr] 251 | | true [INFO] [stderr] 252 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.command != 0x1301)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:269:70 [INFO] [stderr] | [INFO] [stderr] 269 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 270 | | false [INFO] [stderr] 271 | | } else if dgram.command != 0x1401 { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:267:73 [INFO] [stderr] | [INFO] [stderr] 267 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 268 | | false [INFO] [stderr] 269 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:271:28 [INFO] [stderr] | [INFO] [stderr] 271 | } else if dgram.command != 0x1401 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 272 | | false [INFO] [stderr] 273 | | } else { [INFO] [stderr] 274 | | true [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.command != 0x1401)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:292:70 [INFO] [stderr] | [INFO] [stderr] 292 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 293 | | false [INFO] [stderr] 294 | | } else if dgram.command != 0x1403 { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:290:73 [INFO] [stderr] | [INFO] [stderr] 290 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 291 | | false [INFO] [stderr] 292 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:294:28 [INFO] [stderr] | [INFO] [stderr] 294 | } else if dgram.command != 0x1403 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 295 | | false [INFO] [stderr] 296 | | } else { [INFO] [stderr] 297 | | true [INFO] [stderr] 298 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.command != 0x1403)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:315:70 [INFO] [stderr] | [INFO] [stderr] 315 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 316 | | false [INFO] [stderr] 317 | | } else if dgram.command != 0x1405 { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:313:73 [INFO] [stderr] | [INFO] [stderr] 313 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 314 | | false [INFO] [stderr] 315 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | } else if dgram.command != 0x1405 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 318 | | false [INFO] [stderr] 319 | | } else { [INFO] [stderr] 320 | | true [INFO] [stderr] 321 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.command != 0x1405)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:330:62 [INFO] [stderr] | [INFO] [stderr] 330 | let tx_data = self.create_datagram(address, 0x1500 | (sub_index as u16), value_index, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(sub_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:332:37 [INFO] [stderr] | [INFO] [stderr] 332 | let resp_command = 0x1600 | (sub_index as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(sub_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:339:70 [INFO] [stderr] | [INFO] [stderr] 339 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 340 | | false [INFO] [stderr] 341 | | } else if dgram.command != resp_command { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:337:73 [INFO] [stderr] | [INFO] [stderr] 337 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 338 | | false [INFO] [stderr] 339 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:341:28 [INFO] [stderr] | [INFO] [stderr] 341 | } else if dgram.command != resp_command { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 342 | | false [INFO] [stderr] 343 | | } else { [INFO] [stderr] 344 | | true [INFO] [stderr] 345 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.command != resp_command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/recording_decoder.rs:25:34 [INFO] [stderr] | [INFO] [stderr] 25 | } else if buf [2] != buf [4] { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 26 | | Malformed [INFO] [stderr] 27 | | } else if buf [3] != buf [5] { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/recording_decoder.rs:23:50 [INFO] [stderr] | [INFO] [stderr] 23 | } else if (buf [1] >> 4) != (buf [1] & 0x0F) { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 24 | | Malformed [INFO] [stderr] 25 | | } else if buf [2] != buf [4] { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/recording_decoder.rs:108:39 [INFO] [stderr] | [INFO] [stderr] 108 | } else if buf [1] != 0x66 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 109 | | None [INFO] [stderr] 110 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/recording_decoder.rs:106:28 [INFO] [stderr] | [INFO] [stderr] 106 | if length < 20 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 107 | | None [INFO] [stderr] 108 | | } else if buf [1] != 0x66 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/recording_encoder.rs:25:42 [INFO] [stderr] | [INFO] [stderr] 25 | let timestamp = timestamp_s * 1000 + timestamp_ms as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(timestamp_ms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/recording_reader.rs:139:45 [INFO] [stderr] | [INFO] [stderr] 139 | } else if bytes [1] == 0x44 { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 140 | | break; [INFO] [stderr] 141 | | } else if bytes [1] == 0x66 { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/recording_reader.rs:137:32 [INFO] [stderr] | [INFO] [stderr] 137 | if length == 0 { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 138 | | break; [INFO] [stderr] 139 | | } else if bytes [1] == 0x44 { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/live_data_recording_writer.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | &mut buf [22..].copy_from_slice(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buf [22..].copy_from_slice(data);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/specification_file.rs:417:41 [INFO] [stderr] | [INFO] [stderr] 417 | pub fn unit_family_by_id(&self, id: &UnitFamilyId) -> UnitFamily { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `UnitFamilyId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/specification_file.rs:437:34 [INFO] [stderr] | [INFO] [stderr] 437 | pub fn type_by_id(&self, id: &TypeId) -> Type { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `TypeId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification_file.rs:452:104 [INFO] [stderr] | [INFO] [stderr] 452 | } else if ((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0 { [INFO] [stderr] | ________________________________________________________________________________________________________^ [INFO] [stderr] 453 | | false [INFO] [stderr] 454 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification_file.rs:450:97 [INFO] [stderr] | [INFO] [stderr] 450 | if ((device_template.self_address ^ self_address) & device_template.self_mask) != 0 { [INFO] [stderr] | _________________________________________________________________________________________________^ [INFO] [stderr] 451 | | false [INFO] [stderr] 452 | | } else if ((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification_file.rs:452:20 [INFO] [stderr] | [INFO] [stderr] 452 | } else if ((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0 { [INFO] [stderr] | ____________________^ [INFO] [stderr] 453 | | false [INFO] [stderr] 454 | | } else { [INFO] [stderr] 455 | | true [INFO] [stderr] 456 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `!(((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification_file.rs:465:110 [INFO] [stderr] | [INFO] [stderr] 465 | } else if ((packet_template.source_address ^ source_address) & packet_template.source_mask) != 0 { [INFO] [stderr] | ______________________________________________________________________________________________________________^ [INFO] [stderr] 466 | | false [INFO] [stderr] 467 | | } else if packet_template.command != command { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification_file.rs:463:118 [INFO] [stderr] | [INFO] [stderr] 463 | if ((packet_template.destination_address ^ destination_address) & packet_template.destination_mask) != 0 { [INFO] [stderr] | ______________________________________________________________________________________________________________________^ [INFO] [stderr] 464 | | false [INFO] [stderr] 465 | | } else if ((packet_template.source_address ^ source_address) & packet_template.source_mask) != 0 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification_file.rs:467:20 [INFO] [stderr] | [INFO] [stderr] 467 | } else if packet_template.command != command { [INFO] [stderr] | ____________________^ [INFO] [stderr] 468 | | false [INFO] [stderr] 469 | | } else { [INFO] [stderr] 470 | | true [INFO] [stderr] 471 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `!(packet_template.command != command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification.rs:253:55 [INFO] [stderr] | [INFO] [stderr] 253 | } else if device.self_address != self_address { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 254 | | false [INFO] [stderr] 255 | | } else if device.peer_address.is_some() && device.peer_address.unwrap() != peer_address { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification.rs:251:38 [INFO] [stderr] | [INFO] [stderr] 251 | if device.channel != channel { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 252 | | false [INFO] [stderr] 253 | | } else if device.self_address != self_address { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification.rs:255:16 [INFO] [stderr] | [INFO] [stderr] 255 | } else if device.peer_address.is_some() && device.peer_address.unwrap() != peer_address { [INFO] [stderr] | ________________^ [INFO] [stderr] 256 | | false [INFO] [stderr] 257 | | } else { [INFO] [stderr] 258 | | true [INFO] [stderr] 259 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(device.peer_address.is_some() && device.peer_address.unwrap() != peer_address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification.rs:326:69 [INFO] [stderr] | [INFO] [stderr] 326 | } else if packet.destination_address != destination_address { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 327 | | false [INFO] [stderr] 328 | | } else if packet.source_address != source_address { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification.rs:324:38 [INFO] [stderr] | [INFO] [stderr] 324 | if packet.channel != channel { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 325 | | false [INFO] [stderr] 326 | | } else if packet.destination_address != destination_address { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification.rs:330:16 [INFO] [stderr] | [INFO] [stderr] 330 | } else if packet.command != command { [INFO] [stderr] | ________________^ [INFO] [stderr] 331 | | false [INFO] [stderr] 332 | | } else { [INFO] [stderr] 333 | | true [INFO] [stderr] 334 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(packet.command != command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/specification.rs:344:1 [INFO] [stderr] | [INFO] [stderr] 344 | / fn get_or_create_cached_packet_spec(packets: &mut Vec>, channel: u8, destination_address: u16, source_address: u16, command: u16, devices: &mut Vec>, file: &SpecificationFile, language: Language) -> Rc { [INFO] [stderr] 345 | | if let Some(packet) = get_cached_packet_spec(packets, channel, destination_address, source_address, command) { [INFO] [stderr] 346 | | return packet; [INFO] [stderr] 347 | | } [INFO] [stderr] ... | [INFO] [stderr] 408 | | get_cached_packet_spec(packets, channel, destination_address, source_address, command).unwrap() [INFO] [stderr] 409 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:452:27 [INFO] [stderr] | [INFO] [stderr] 452 | _ => 10.0f64.powf(n as f64), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:647:21 [INFO] [stderr] | [INFO] [stderr] 647 | (buf [offset] as i8) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((buf [offset] as i8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:649:21 [INFO] [stderr] | [INFO] [stderr] 649 | buf [offset] as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buf [offset])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:652:35 [INFO] [stderr] | [INFO] [stderr] 652 | part_value &= part.mask as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(part.mask)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/tcp_connector.rs:95:16 [INFO] [stderr] | [INFO] [stderr] 95 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 96 | | Err(Error::new(ErrorKind::Other, line)) [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/tcp_connector.rs:93:41 [INFO] [stderr] | [INFO] [stderr] 93 | } else if line.starts_with('-') { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 94 | | Err(Error::new(ErrorKind::Other, line)) [INFO] [stderr] 95 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to 21 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `resol-vbus`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/test_utils.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/test_utils.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | buffer.write(&[0x01, 0x23, 0x45, 0x67]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:199:48 [INFO] [stderr] | [INFO] [stderr] 199 | crc = (crc >> 8) ^ CRC16_TABLE [(crc ^ *byte as u16) as usize & 0xFF]; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/blob_reader.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | br.as_mut().write(&LIVE_DATA_1 [0..172]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/blob_reader.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | br.as_mut().write(&LIVE_DATA_1 [172..232]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/blob_reader.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | br.as_mut().write(&LIVE_DATA_1 [232..242]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/packet.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn packet_id_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/data.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Packet(Packet), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 38 | Packet(Box), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/data.rs:194:87 [INFO] [stderr] | [INFO] [stderr] 194 | } else if left_header.destination_address != right_header.destination_address { [INFO] [stderr] | _______________________________________________________________________________________^ [INFO] [stderr] 195 | | false [INFO] [stderr] 196 | | } else if left_header.source_address != right_header.source_address { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/data.rs:192:56 [INFO] [stderr] | [INFO] [stderr] 192 | if left_header.channel != right_header.channel { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 193 | | false [INFO] [stderr] 194 | | } else if left_header.destination_address != right_header.destination_address { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/data.rs:204:25 [INFO] [stderr] | [INFO] [stderr] 204 | / if left_packet.command != right_packet.command { [INFO] [stderr] 205 | | false [INFO] [stderr] 206 | | } else { [INFO] [stderr] 207 | | true [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `!(left_packet.command != right_packet.command)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/data.rs:219:32 [INFO] [stderr] | [INFO] [stderr] 219 | } else if left_dgram.param16 != right_dgram.param16 { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 220 | | false [INFO] [stderr] 221 | | } else { [INFO] [stderr] 222 | | true [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `!(left_dgram.param16 != right_dgram.param16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/data.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | / if left_tgram.command != right_tgram.command { [INFO] [stderr] 231 | | false [INFO] [stderr] 232 | | } else { [INFO] [stderr] 233 | | true [INFO] [stderr] 234 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `!(left_tgram.command != right_tgram.command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/data.rs:506:5 [INFO] [stderr] | [INFO] [stderr] 506 | / fn test_eq() { [INFO] [stderr] 507 | | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] 508 | | let channel = 0x11; [INFO] [stderr] 509 | | [INFO] [stderr] ... | [INFO] [stderr] 628 | | assert_eq!(true, Data::Telegram(other).eq(&tgram_data)); [INFO] [stderr] 629 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 48 [INFO] [stderr] --> src/data.rs:632:5 [INFO] [stderr] | [INFO] [stderr] 632 | / fn test_partial_cmp() { [INFO] [stderr] 633 | | let timestamp = UTC.timestamp(1485688933, 0); [INFO] [stderr] 634 | | let channel = 0x11; [INFO] [stderr] 635 | | [INFO] [stderr] ... | [INFO] [stderr] 823 | | assert_eq!(Some(Equal), Data::Telegram(other).partial_cmp(&tgram_data)); [INFO] [stderr] 824 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: item `data_set::DataSet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/data_set.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / impl DataSet { [INFO] [stderr] 50 | | [INFO] [stderr] 51 | | /// Construct an empty `DataSet`. [INFO] [stderr] 52 | | pub fn new() -> DataSet { [INFO] [stderr] ... | [INFO] [stderr] 190 | | [INFO] [stderr] 191 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_decoder.rs:36:67 [INFO] [stderr] | [INFO] [stderr] 36 | } else if !calc_and_compare_checksum_v0(&buf [1..10]) { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 37 | | Malformed [INFO] [stderr] 38 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_decoder.rs:34:49 [INFO] [stderr] | [INFO] [stderr] 34 | } else if has_msb_set(&buf [6..10]) { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 35 | | Malformed [INFO] [stderr] 36 | | } else if !calc_and_compare_checksum_v0(&buf [1..10]) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_decoder.rs:62:67 [INFO] [stderr] | [INFO] [stderr] 62 | } else if !calc_and_compare_checksum_v0(&buf [1..16]) { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 63 | | Malformed [INFO] [stderr] 64 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_decoder.rs:60:49 [INFO] [stderr] | [INFO] [stderr] 60 | } else if has_msb_set(&buf [6..16]) { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 61 | | Malformed [INFO] [stderr] 62 | | } else if !calc_and_compare_checksum_v0(&buf [1..16]) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_decoder.rs:72:66 [INFO] [stderr] | [INFO] [stderr] 72 | } else if !calc_and_compare_checksum_v0(&buf [1..8]) { [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 73 | | Malformed [INFO] [stderr] 74 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_decoder.rs:70:48 [INFO] [stderr] | [INFO] [stderr] 70 | } else if has_msb_set(&buf [6..8]) { [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 71 | | Malformed [INFO] [stderr] 72 | | } else if !calc_and_compare_checksum_v0(&buf [1..8]) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/live_data_decoder.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | / fn test_length_from_bytes() { [INFO] [stderr] 185 | | // version independent [INFO] [stderr] 186 | | assert_eq!(Partial, length_from_bytes(&[])); [INFO] [stderr] 187 | | assert_eq!(Malformed, length_from_bytes(&[ 0x00 ])); [INFO] [stderr] ... | [INFO] [stderr] 223 | | assert_eq!(BlobLength(17), length_from_bytes(&LIVE_TELEGRAM_1 [0..])); [INFO] [stderr] 224 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/live_data_reader.rs:83:23 [INFO] [stderr] | [INFO] [stderr] 83 | let data = if bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/live_data_reader.rs:145:23 [INFO] [stderr] | [INFO] [stderr] 145 | let data = if bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/live_data_reader.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | ldr.as_mut().write(&LIVE_DATA_1 [0..172]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/live_data_reader.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | ldr.as_mut().write(&LIVE_DATA_1 [0..172]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/live_data_reader.rs:250:9 [INFO] [stderr] | [INFO] [stderr] 250 | ldr.as_mut().write(&LIVE_DATA_1 [172..232]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/live_data_reader.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | ldr.as_mut().write(&LIVE_DATA_1 [232..242]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:72:45 [INFO] [stderr] | [INFO] [stderr] 72 | let timeout = Duration::from_millis(timeout_ms as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(timeout_ms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:78:49 [INFO] [stderr] | [INFO] [stderr] 78 | let mut timeout = Duration::from_millis(initial_timeout_ms as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(initial_timeout_ms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/live_data_stream.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | timeout = timeout + timeout_incr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timeout += timeout_incr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:138:62 [INFO] [stderr] | [INFO] [stderr] 138 | let tx_data = self.create_datagram(address, 0x0300 | (sub_index as u16), value_index, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(sub_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:146:70 [INFO] [stderr] | [INFO] [stderr] 146 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 147 | | false [INFO] [stderr] 148 | | } else if dgram.command != (0x0100 | (sub_index as u16)) { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:144:73 [INFO] [stderr] | [INFO] [stderr] 144 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 145 | | false [INFO] [stderr] 146 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:148:58 [INFO] [stderr] | [INFO] [stderr] 148 | } else if dgram.command != (0x0100 | (sub_index as u16)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(sub_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:150:28 [INFO] [stderr] | [INFO] [stderr] 150 | } else if dgram.param16 != value_index { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 151 | | false [INFO] [stderr] 152 | | } else { [INFO] [stderr] 153 | | true [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.param16 != value_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:163:62 [INFO] [stderr] | [INFO] [stderr] 163 | let tx_data = self.create_datagram(address, 0x0200 | (sub_index as u16), value_index, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(sub_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:171:70 [INFO] [stderr] | [INFO] [stderr] 171 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 172 | | false [INFO] [stderr] 173 | | } else if dgram.command != (0x0100 | (sub_index as u16)) { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:169:73 [INFO] [stderr] | [INFO] [stderr] 169 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 170 | | false [INFO] [stderr] 171 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:173:58 [INFO] [stderr] | [INFO] [stderr] 173 | } else if dgram.command != (0x0100 | (sub_index as u16)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(sub_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:175:28 [INFO] [stderr] | [INFO] [stderr] 175 | } else if dgram.param16 != value_index { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 176 | | false [INFO] [stderr] 177 | | } else { [INFO] [stderr] 178 | | true [INFO] [stderr] 179 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.param16 != value_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:196:70 [INFO] [stderr] | [INFO] [stderr] 196 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 197 | | false [INFO] [stderr] 198 | | } else if (dgram.command != 0x0100) && (dgram.command != 0x1001) { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:194:73 [INFO] [stderr] | [INFO] [stderr] 194 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 195 | | false [INFO] [stderr] 196 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:200:28 [INFO] [stderr] | [INFO] [stderr] 200 | } else if dgram.param16 != value_index { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 201 | | false [INFO] [stderr] 202 | | } else { [INFO] [stderr] 203 | | true [INFO] [stderr] 204 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.param16 != value_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:221:70 [INFO] [stderr] | [INFO] [stderr] 221 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 222 | | false [INFO] [stderr] 223 | | } else if (dgram.command != 0x0100) && (dgram.command != 0x1101) { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:219:73 [INFO] [stderr] | [INFO] [stderr] 219 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 220 | | false [INFO] [stderr] 221 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:225:28 [INFO] [stderr] | [INFO] [stderr] 225 | } else if dgram.param32 != value_id_hash { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 226 | | false [INFO] [stderr] 227 | | } else { [INFO] [stderr] 228 | | true [INFO] [stderr] 229 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.param32 != value_id_hash)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:246:70 [INFO] [stderr] | [INFO] [stderr] 246 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 247 | | false [INFO] [stderr] 248 | | } else if dgram.command != 0x1301 { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:244:73 [INFO] [stderr] | [INFO] [stderr] 244 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 245 | | false [INFO] [stderr] 246 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:248:28 [INFO] [stderr] | [INFO] [stderr] 248 | } else if dgram.command != 0x1301 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 249 | | false [INFO] [stderr] 250 | | } else { [INFO] [stderr] 251 | | true [INFO] [stderr] 252 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.command != 0x1301)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:269:70 [INFO] [stderr] | [INFO] [stderr] 269 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 270 | | false [INFO] [stderr] 271 | | } else if dgram.command != 0x1401 { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:267:73 [INFO] [stderr] | [INFO] [stderr] 267 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 268 | | false [INFO] [stderr] 269 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:271:28 [INFO] [stderr] | [INFO] [stderr] 271 | } else if dgram.command != 0x1401 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 272 | | false [INFO] [stderr] 273 | | } else { [INFO] [stderr] 274 | | true [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.command != 0x1401)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:292:70 [INFO] [stderr] | [INFO] [stderr] 292 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 293 | | false [INFO] [stderr] 294 | | } else if dgram.command != 0x1403 { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:290:73 [INFO] [stderr] | [INFO] [stderr] 290 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 291 | | false [INFO] [stderr] 292 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:294:28 [INFO] [stderr] | [INFO] [stderr] 294 | } else if dgram.command != 0x1403 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 295 | | false [INFO] [stderr] 296 | | } else { [INFO] [stderr] 297 | | true [INFO] [stderr] 298 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.command != 0x1403)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:315:70 [INFO] [stderr] | [INFO] [stderr] 315 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 316 | | false [INFO] [stderr] 317 | | } else if dgram.command != 0x1405 { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:313:73 [INFO] [stderr] | [INFO] [stderr] 313 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 314 | | false [INFO] [stderr] 315 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | } else if dgram.command != 0x1405 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 318 | | false [INFO] [stderr] 319 | | } else { [INFO] [stderr] 320 | | true [INFO] [stderr] 321 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.command != 0x1405)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:330:62 [INFO] [stderr] | [INFO] [stderr] 330 | let tx_data = self.create_datagram(address, 0x1500 | (sub_index as u16), value_index, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(sub_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/live_data_stream.rs:332:37 [INFO] [stderr] | [INFO] [stderr] 332 | let resp_command = 0x1600 | (sub_index as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(sub_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/live_data_stream.rs:339:70 [INFO] [stderr] | [INFO] [stderr] 339 | } else if dgram.header.source_address != address { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 340 | | false [INFO] [stderr] 341 | | } else if dgram.command != resp_command { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/live_data_stream.rs:337:73 [INFO] [stderr] | [INFO] [stderr] 337 | if dgram.header.destination_address != self_address { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 338 | | false [INFO] [stderr] 339 | | } else if dgram.header.source_address != address { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/live_data_stream.rs:341:28 [INFO] [stderr] | [INFO] [stderr] 341 | } else if dgram.command != resp_command { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 342 | | false [INFO] [stderr] 343 | | } else { [INFO] [stderr] 344 | | true [INFO] [stderr] 345 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `!(dgram.command != resp_command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/live_data_stream.rs:414:9 [INFO] [stderr] | [INFO] [stderr] 414 | lds.reader_mut().write(&LIVE_DATA_1 [0..172]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/live_data_stream.rs:420:9 [INFO] [stderr] | [INFO] [stderr] 420 | lds.reader_mut().write(&LIVE_DATA_1 [172..232]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/live_data_stream.rs:426:9 [INFO] [stderr] | [INFO] [stderr] 426 | lds.reader_mut().write(&LIVE_DATA_1 [232..242]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/live_data_stream.rs:445:9 [INFO] [stderr] | [INFO] [stderr] 445 | lds.reader_mut().write(&LIVE_DATA_1 [172..258]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/live_data_stream.rs:464:9 [INFO] [stderr] | [INFO] [stderr] 464 | lds.reader_mut().write(&LIVE_DATA_1 [172..258]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/live_data_stream.rs:501:17 [INFO] [stderr] | [INFO] [stderr] 501 | lds.writer_mut().read(&mut bytes [0..size]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/live_data_stream.rs:529:9 [INFO] [stderr] | [INFO] [stderr] 529 | lds.reader_mut().write(&bytes [0..size]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/live_data_stream.rs:551:9 [INFO] [stderr] | [INFO] [stderr] 551 | lds.reader_mut().write(&LIVE_DATA_1 [0..172]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/recording_decoder.rs:25:34 [INFO] [stderr] | [INFO] [stderr] 25 | } else if buf [2] != buf [4] { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 26 | | Malformed [INFO] [stderr] 27 | | } else if buf [3] != buf [5] { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/recording_decoder.rs:23:50 [INFO] [stderr] | [INFO] [stderr] 23 | } else if (buf [1] >> 4) != (buf [1] & 0x0F) { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 24 | | Malformed [INFO] [stderr] 25 | | } else if buf [2] != buf [4] { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/recording_decoder.rs:108:39 [INFO] [stderr] | [INFO] [stderr] 108 | } else if buf [1] != 0x66 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 109 | | None [INFO] [stderr] 110 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/recording_decoder.rs:106:28 [INFO] [stderr] | [INFO] [stderr] 106 | if length < 20 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 107 | | None [INFO] [stderr] 108 | | } else if buf [1] != 0x66 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/recording_decoder.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / fn test_length_from_bytes() { [INFO] [stderr] 149 | | assert_eq!(Partial, length_from_bytes(&[])); [INFO] [stderr] 150 | | assert_eq!(Malformed, length_from_bytes(&[ 0x00 ])); [INFO] [stderr] 151 | | assert_eq!(Partial, length_from_bytes(&[ 0xA5, 0x44, 0x0E, 0x00, 0x0E, 0x00, 0x31, 0x47, 0xA9, 0x82, 0x59, 0x01, 0x00 ])); [INFO] [stderr] ... | [INFO] [stderr] 177 | | assert_eq!(224, RECORDING_3.len()); [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/recording_decoder.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | / fn test_data_from_checked_bytes() { [INFO] [stderr] 212 | | let data = data_from_checked_bytes(0x00, &RECORDING_1 [14..]); [INFO] [stderr] 213 | | assert_eq!("2017-01-09T09:57:28.975+00:00", data.as_header().timestamp.to_rfc3339()); [INFO] [stderr] 214 | | assert_eq!("00_0010_0053_10_0100", data.id_string()); [INFO] [stderr] ... | [INFO] [stderr] 274 | | assert_eq!("01_0000_7E11_20_0900_18F8", data.id_string()); [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/recording_encoder.rs:25:42 [INFO] [stderr] | [INFO] [stderr] 25 | let timestamp = timestamp_s * 1000 + timestamp_ms as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(timestamp_ms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/recording_reader.rs:139:45 [INFO] [stderr] | [INFO] [stderr] 139 | } else if bytes [1] == 0x44 { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 140 | | break; [INFO] [stderr] 141 | | } else if bytes [1] == 0x66 { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/recording_reader.rs:137:32 [INFO] [stderr] | [INFO] [stderr] 137 | if length == 0 { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 138 | | break; [INFO] [stderr] 139 | | } else if bytes [1] == 0x44 { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/live_data_recording_writer.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | &mut buf [22..].copy_from_slice(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buf [22..].copy_from_slice(data);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/specification_file.rs:417:41 [INFO] [stderr] | [INFO] [stderr] 417 | pub fn unit_family_by_id(&self, id: &UnitFamilyId) -> UnitFamily { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `UnitFamilyId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/specification_file.rs:437:34 [INFO] [stderr] | [INFO] [stderr] 437 | pub fn type_by_id(&self, id: &TypeId) -> Type { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `TypeId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification_file.rs:452:104 [INFO] [stderr] | [INFO] [stderr] 452 | } else if ((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0 { [INFO] [stderr] | ________________________________________________________________________________________________________^ [INFO] [stderr] 453 | | false [INFO] [stderr] 454 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification_file.rs:450:97 [INFO] [stderr] | [INFO] [stderr] 450 | if ((device_template.self_address ^ self_address) & device_template.self_mask) != 0 { [INFO] [stderr] | _________________________________________________________________________________________________^ [INFO] [stderr] 451 | | false [INFO] [stderr] 452 | | } else if ((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification_file.rs:452:20 [INFO] [stderr] | [INFO] [stderr] 452 | } else if ((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0 { [INFO] [stderr] | ____________________^ [INFO] [stderr] 453 | | false [INFO] [stderr] 454 | | } else { [INFO] [stderr] 455 | | true [INFO] [stderr] 456 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `!(((device_template.peer_address ^ peer_address) & device_template.peer_mask) != 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification_file.rs:465:110 [INFO] [stderr] | [INFO] [stderr] 465 | } else if ((packet_template.source_address ^ source_address) & packet_template.source_mask) != 0 { [INFO] [stderr] | ______________________________________________________________________________________________________________^ [INFO] [stderr] 466 | | false [INFO] [stderr] 467 | | } else if packet_template.command != command { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification_file.rs:463:118 [INFO] [stderr] | [INFO] [stderr] 463 | if ((packet_template.destination_address ^ destination_address) & packet_template.destination_mask) != 0 { [INFO] [stderr] | ______________________________________________________________________________________________________________________^ [INFO] [stderr] 464 | | false [INFO] [stderr] 465 | | } else if ((packet_template.source_address ^ source_address) & packet_template.source_mask) != 0 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification_file.rs:467:20 [INFO] [stderr] | [INFO] [stderr] 467 | } else if packet_template.command != command { [INFO] [stderr] | ____________________^ [INFO] [stderr] 468 | | false [INFO] [stderr] 469 | | } else { [INFO] [stderr] 470 | | true [INFO] [stderr] 471 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `!(packet_template.command != command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/specification_file.rs:733:5 [INFO] [stderr] | [INFO] [stderr] 733 | / fn check_spec_file_fixture(spec_file: &SpecificationFile) { [INFO] [stderr] 734 | | let mut text_index = 0; [INFO] [stderr] 735 | | [INFO] [stderr] 736 | | let mut check_next_text = |ref_text| { [INFO] [stderr] ... | [INFO] [stderr] 1113 | | check_next_part(39, 0, 0xFF, true, 16777216000000000); [INFO] [stderr] 1114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification.rs:253:55 [INFO] [stderr] | [INFO] [stderr] 253 | } else if device.self_address != self_address { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 254 | | false [INFO] [stderr] 255 | | } else if device.peer_address.is_some() && device.peer_address.unwrap() != peer_address { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification.rs:251:38 [INFO] [stderr] | [INFO] [stderr] 251 | if device.channel != channel { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 252 | | false [INFO] [stderr] 253 | | } else if device.self_address != self_address { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification.rs:255:16 [INFO] [stderr] | [INFO] [stderr] 255 | } else if device.peer_address.is_some() && device.peer_address.unwrap() != peer_address { [INFO] [stderr] | ________________^ [INFO] [stderr] 256 | | false [INFO] [stderr] 257 | | } else { [INFO] [stderr] 258 | | true [INFO] [stderr] 259 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(device.peer_address.is_some() && device.peer_address.unwrap() != peer_address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/specification.rs:326:69 [INFO] [stderr] | [INFO] [stderr] 326 | } else if packet.destination_address != destination_address { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 327 | | false [INFO] [stderr] 328 | | } else if packet.source_address != source_address { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/specification.rs:324:38 [INFO] [stderr] | [INFO] [stderr] 324 | if packet.channel != channel { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 325 | | false [INFO] [stderr] 326 | | } else if packet.destination_address != destination_address { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/specification.rs:330:16 [INFO] [stderr] | [INFO] [stderr] 330 | } else if packet.command != command { [INFO] [stderr] | ________________^ [INFO] [stderr] 331 | | false [INFO] [stderr] 332 | | } else { [INFO] [stderr] 333 | | true [INFO] [stderr] 334 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(packet.command != command)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/specification.rs:344:1 [INFO] [stderr] | [INFO] [stderr] 344 | / fn get_or_create_cached_packet_spec(packets: &mut Vec>, channel: u8, destination_address: u16, source_address: u16, command: u16, devices: &mut Vec>, file: &SpecificationFile, language: Language) -> Rc { [INFO] [stderr] 345 | | if let Some(packet) = get_cached_packet_spec(packets, channel, destination_address, source_address, command) { [INFO] [stderr] 346 | | return packet; [INFO] [stderr] 347 | | } [INFO] [stderr] ... | [INFO] [stderr] 408 | | get_cached_packet_spec(packets, channel, destination_address, source_address, command).unwrap() [INFO] [stderr] 409 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:452:27 [INFO] [stderr] | [INFO] [stderr] 452 | _ => 10.0f64.powf(n as f64), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:647:21 [INFO] [stderr] | [INFO] [stderr] 647 | (buf [offset] as i8) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((buf [offset] as i8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:649:21 [INFO] [stderr] | [INFO] [stderr] 649 | buf [offset] as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buf [offset])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:652:35 [INFO] [stderr] | [INFO] [stderr] 652 | part_value &= part.mask as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(part.mask)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:968:37 [INFO] [stderr] | [INFO] [stderr] 968 | assert_eq!(10.0f64.powf(n as f64), power_of_ten_f64(n)); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/specification.rs:968:13 [INFO] [stderr] | [INFO] [stderr] 968 | assert_eq!(10.0f64.powf(n as f64), power_of_ten_f64(n)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/specification.rs:968:13 [INFO] [stderr] | [INFO] [stderr] 968 | assert_eq!(10.0f64.powf(n as f64), power_of_ten_f64(n)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 44 [INFO] [stderr] --> src/specification.rs:1057:5 [INFO] [stderr] | [INFO] [stderr] 1057 | / fn test_get_packet_spec() { [INFO] [stderr] 1058 | | let spec_file = SpecificationFile::from_bytes(SPEC_FILE_1).unwrap(); [INFO] [stderr] 1059 | | [INFO] [stderr] 1060 | | let spec = Specification::from_file(spec_file, Language::En); [INFO] [stderr] ... | [INFO] [stderr] 1118 | | assert_eq!(0, packet_spec.fields.len()); [INFO] [stderr] 1119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:1187:25 [INFO] [stderr] | [INFO] [stderr] 1187 | assert_eq!(Some(0x12345678 as f64), packet_spec.get_field_spec("000_4_0").unwrap().raw_value_f64(buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(0x12345678)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:1190:25 [INFO] [stderr] | [INFO] [stderr] 1190 | assert_eq!(Some(0x345678 as f64), packet_spec.get_field_spec("000_4_0").unwrap().raw_value_f64(&buf [0..3])); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(0x345678)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:1191:25 [INFO] [stderr] | [INFO] [stderr] 1191 | assert_eq!(Some(0x5678 as f64), packet_spec.get_field_spec("000_4_0").unwrap().raw_value_f64(&buf [0..2])); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(0x5678)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/specification.rs:1192:25 [INFO] [stderr] | [INFO] [stderr] 1192 | assert_eq!(Some(0x78 as f64), packet_spec.get_field_spec("000_4_0").unwrap().raw_value_f64(&buf [0..1])); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(0x78)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 58 [INFO] [stderr] --> src/specification.rs:1254:5 [INFO] [stderr] | [INFO] [stderr] 1254 | / fn test_fields_in_data_set() { [INFO] [stderr] 1255 | | let mut rr = RecordingReader::new(RECORDING_2); [INFO] [stderr] 1256 | | [INFO] [stderr] 1257 | | let data_set = rr.read_data_set().unwrap().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 1335 | | assert_eq!("0 l", format!("{}", field.fmt_raw_value(true))); [INFO] [stderr] 1336 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/tcp_connector.rs:95:16 [INFO] [stderr] | [INFO] [stderr] 95 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 96 | | Err(Error::new(ErrorKind::Other, line)) [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/tcp_connector.rs:93:41 [INFO] [stderr] | [INFO] [stderr] 93 | } else if line.starts_with('-') { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 94 | | Err(Error::new(ErrorKind::Other, line)) [INFO] [stderr] 95 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to 38 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `resol-vbus`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7bc4d2ff3427c87036ecdcb4a3ab41b28aad49c84395513021f347b698248b8c"` [INFO] running `"docker" "rm" "-f" "7bc4d2ff3427c87036ecdcb4a3ab41b28aad49c84395513021f347b698248b8c"` [INFO] [stdout] 7bc4d2ff3427c87036ecdcb4a3ab41b28aad49c84395513021f347b698248b8c