[INFO] updating cached repository danielbusaba/histogram [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/danielbusaba/histogram [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/danielbusaba/histogram" "work/ex/clippy-test-run/sources/stable/gh/danielbusaba/histogram"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/danielbusaba/histogram'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/danielbusaba/histogram" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielbusaba/histogram"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielbusaba/histogram'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a9f99552de2fb7afbb4cb01b60e801ffbedb6ccb [INFO] sha for GitHub repo danielbusaba/histogram: a9f99552de2fb7afbb4cb01b60e801ffbedb6ccb [INFO] validating manifest of danielbusaba/histogram on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of danielbusaba/histogram on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing danielbusaba/histogram [INFO] finished frobbing danielbusaba/histogram [INFO] frobbed toml for danielbusaba/histogram written to work/ex/clippy-test-run/sources/stable/gh/danielbusaba/histogram/Cargo.toml [INFO] started frobbing danielbusaba/histogram [INFO] finished frobbing danielbusaba/histogram [INFO] frobbed toml for danielbusaba/histogram written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielbusaba/histogram/Cargo.toml [INFO] crate danielbusaba/histogram has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting danielbusaba/histogram against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielbusaba/histogram:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 93bb6389f79eb60450551b86360e3919adc78fc552825d6df2686f734e87e8e4 [INFO] running `"docker" "start" "-a" "93bb6389f79eb60450551b86360e3919adc78fc552825d6df2686f734e87e8e4"` [INFO] [stderr] Checking histogram v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/histogram.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; //Can be used with bucket to create sublog histograms [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `histogram::Histogram` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use histogram::Histogram; //Imports Histogram struct [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Histogram` [INFO] [stderr] --> src/histogram.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct Histogram //Stores a Histogram [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_single` [INFO] [stderr] --> src/histogram.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new_single(sb: u64, mrt: u64) -> Histogram //Constructor that takes in the sublog bits and the maximum reuse time [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add` [INFO] [stderr] --> src/histogram.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn add(&mut self, reuse_time: u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `insert` [INFO] [stderr] --> src/histogram.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn insert(&mut self, reuse_time: u64, frequency: u64) //Inserts a value into the histogram at a given reuse time [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_frequency` [INFO] [stderr] --> src/histogram.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn get_frequency(&self, reuse_time: u64) -> u64 //Retreives the frequency value at a given reuse time [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_values` [INFO] [stderr] --> src/histogram.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn get_values(&self) -> Vec //Returns copy of internal vector [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_max_reuse_time` [INFO] [stderr] --> src/histogram.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn get_max_reuse_time(&self) -> u64 //Returns copy of max reuse time [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_tuple` [INFO] [stderr] --> src/histogram.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn new_tuple(sb: u64, mrt: u64) -> Histogram <(u64, u64, u64, u64)> //Constructor that takes in the sublog bits and the maximum reuse time [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add` [INFO] [stderr] --> src/histogram.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn add(&mut self, reuse_time: u64) //Inserts a value into the histogram at a given reuse time [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_tuple` [INFO] [stderr] --> src/histogram.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn get_tuple(&self, reuse_time: u64) -> (u64, u64, u64, u64) //Retreives the value tuple at a given reuse time [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_frequency` [INFO] [stderr] --> src/histogram.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn get_frequency(&self, reuse_time: u64) -> u64 //Retreives the frequency value at a given reuse time [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_values` [INFO] [stderr] --> src/histogram.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | pub fn get_values(&self) -> Vec <(u64, u64, u64, u64)> //Returns copy of internal vector [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_max_reuse_time` [INFO] [stderr] --> src/histogram.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn get_max_reuse_time(&self) -> u64 //Returns copy of max reuse time [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/histogram.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | let frequency = self.values[convert_value_to_index(reuse_time, self.sublog_bits) as usize].clone(); //Retrieves old frequency [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.values[convert_value_to_index(reuse_time, self.sublog_bits) as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/histogram.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | self.max_reuse_time.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_reuse_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/histogram.rs:84:23 [INFO] [stderr] | [INFO] [stderr] 84 | let sum = self.values[convert_value_to_index(reuse_time, self.sublog_bits) as usize].2.clone(); //Retrieves old sum [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.values[convert_value_to_index(reuse_time, self.sublog_bits) as usize].2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/histogram.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | let frequency = self.values[convert_value_to_index(reuse_time, self.sublog_bits) as usize].3.clone(); //Retrieves old freuency [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.values[convert_value_to_index(reuse_time, self.sublog_bits) as usize].3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/histogram.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | self.max_reuse_time.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_reuse_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/histogram.rs:163:32 [INFO] [stderr] | [INFO] [stderr] 163 | let most_significant_bit = (63 - value.leading_zeros()) as u64; //Find's value's most significant bit [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(63 - value.leading_zeros())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/histogram.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | index = index & ((1 << sublog_bits) - 1); //Does a bitwise and with sublog bits number of 1's [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index &= ((1 << sublog_bits) - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused import: `histogram::Histogram` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use histogram::Histogram; //Imports Histogram struct [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_values` [INFO] [stderr] --> src/histogram.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | pub fn get_values(&self) -> Vec <(u64, u64, u64, u64)> //Returns copy of internal vector [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_max_reuse_time` [INFO] [stderr] --> src/histogram.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn get_max_reuse_time(&self) -> u64 //Returns copy of max reuse time [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/histogram.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | let frequency = self.values[convert_value_to_index(reuse_time, self.sublog_bits) as usize].clone(); //Retrieves old frequency [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.values[convert_value_to_index(reuse_time, self.sublog_bits) as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/histogram.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | self.max_reuse_time.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_reuse_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/histogram.rs:84:23 [INFO] [stderr] | [INFO] [stderr] 84 | let sum = self.values[convert_value_to_index(reuse_time, self.sublog_bits) as usize].2.clone(); //Retrieves old sum [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.values[convert_value_to_index(reuse_time, self.sublog_bits) as usize].2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/histogram.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | let frequency = self.values[convert_value_to_index(reuse_time, self.sublog_bits) as usize].3.clone(); //Retrieves old freuency [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.values[convert_value_to_index(reuse_time, self.sublog_bits) as usize].3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/histogram.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | self.max_reuse_time.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_reuse_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/histogram.rs:163:32 [INFO] [stderr] | [INFO] [stderr] 163 | let most_significant_bit = (63 - value.leading_zeros()) as u64; //Find's value's most significant bit [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(63 - value.leading_zeros())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/histogram.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | index = index & ((1 << sublog_bits) - 1); //Does a bitwise and with sublog bits number of 1's [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index &= ((1 << sublog_bits) - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/histogram.rs:218:20 [INFO] [stderr] | [INFO] [stderr] 218 | let temp = histogram.get(&b2).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*histogram.get(&b2).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/histogram.rs:218:20 [INFO] [stderr] | [INFO] [stderr] 218 | let temp = histogram.get(&b2).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&histogram[&b2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/histogram.rs:222:17 [INFO] [stderr] | [INFO] [stderr] 222 | assert_eq!(*histogram.get(&b1).unwrap(), 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&histogram[&b1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/histogram.rs:255:28 [INFO] [stderr] | [INFO] [stderr] 255 | let mut exponent = (63 - (i as u64).leading_zeros()) as i64 - sublog_bits as i64; //Defines exponent in 2^(bits - sublog_bits) formula [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(63 - (i as u64).leading_zeros())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "93bb6389f79eb60450551b86360e3919adc78fc552825d6df2686f734e87e8e4"` [INFO] running `"docker" "rm" "-f" "93bb6389f79eb60450551b86360e3919adc78fc552825d6df2686f734e87e8e4"` [INFO] [stdout] 93bb6389f79eb60450551b86360e3919adc78fc552825d6df2686f734e87e8e4