[INFO] updating cached repository danielbusaba/affinity
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/danielbusaba/affinity
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/danielbusaba/affinity" "work/ex/clippy-test-run/sources/stable/gh/danielbusaba/affinity"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/danielbusaba/affinity'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/danielbusaba/affinity" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielbusaba/affinity"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielbusaba/affinity'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] bf15927e1c785623be4ea26ac7acf62c96c8ca70
[INFO] sha for GitHub repo danielbusaba/affinity: bf15927e1c785623be4ea26ac7acf62c96c8ca70
[INFO] validating manifest of danielbusaba/affinity on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of danielbusaba/affinity on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing danielbusaba/affinity
[INFO] finished frobbing danielbusaba/affinity
[INFO] frobbed toml for danielbusaba/affinity written to work/ex/clippy-test-run/sources/stable/gh/danielbusaba/affinity/Cargo.toml
[INFO] started frobbing danielbusaba/affinity
[INFO] finished frobbing danielbusaba/affinity
[INFO] frobbed toml for danielbusaba/affinity written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielbusaba/affinity/Cargo.toml
[INFO] crate danielbusaba/affinity has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting danielbusaba/affinity against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielbusaba/affinity:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 68e1223b76d4ebf4e251016f5abb3b2e7ffd38b14ab5a8e300418a1d7b497f53
[INFO] running `"docker" "start" "-a" "68e1223b76d4ebf4e251016f5abb3b2e7ffd38b14ab5a8e300418a1d7b497f53"`
[INFO] [stderr]     Checking affinity v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/main.rs:153:5
[INFO] [stderr]     |
[INFO] [stderr] 153 |     print!("}}\n");
[INFO] [stderr]     |     ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:413:9
[INFO] [stderr]     |
[INFO] [stderr] 413 |     let a = get_a(&u);
[INFO] [stderr]     |         ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:414:9
[INFO] [stderr]     |
[INFO] [stderr] 414 |     let b = get_b(&u, a);
[INFO] [stderr]     |         ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/main.rs:153:5
[INFO] [stderr]     |
[INFO] [stderr] 153 |     print!("}}\n");
[INFO] [stderr]     |     ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:413:9
[INFO] [stderr]     |
[INFO] [stderr] 413 |     let a = get_a(&u);
[INFO] [stderr]     |         ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:414:9
[INFO] [stderr]     |
[INFO] [stderr] 414 |     let b = get_b(&u, a);
[INFO] [stderr]     |         ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |     return trace;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `trace`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:165:5
[INFO] [stderr]     |
[INFO] [stderr] 165 |     return unique_characters;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unique_characters`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> src/main.rs:156:8
[INFO] [stderr]     |
[INFO] [stderr] 156 |     if (aws.len() > 0)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:338:5
[INFO] [stderr]     |
[INFO] [stderr] 338 |     return output;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/main.rs:287:9
[INFO] [stderr]     |
[INFO] [stderr] 287 | /         {
[INFO] [stderr] 288 | |             if input == 0
[INFO] [stderr] 289 | |             {
[INFO] [stderr] 290 | |                 println!("Invalid Input");
[INFO] [stderr] ...   |
[INFO] [stderr] 301 | |             }
[INFO] [stderr] 302 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 287 |         if input == 0
[INFO] [stderr] 288 | {
[INFO] [stderr] 289 |     println!("Invalid Input");
[INFO] [stderr] 290 |     continue;
[INFO] [stderr] 291 | }
[INFO] [stderr] 292 | else if unique_times.contains(&input)
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |     return trace;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `trace`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:165:5
[INFO] [stderr]     |
[INFO] [stderr] 165 |     return unique_characters;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unique_characters`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> src/main.rs:156:8
[INFO] [stderr]     |
[INFO] [stderr] 156 |     if (aws.len() > 0)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:338:5
[INFO] [stderr]     |
[INFO] [stderr] 338 |     return output;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/main.rs:287:9
[INFO] [stderr]     |
[INFO] [stderr] 287 | /         {
[INFO] [stderr] 288 | |             if input == 0
[INFO] [stderr] 289 | |             {
[INFO] [stderr] 290 | |                 println!("Invalid Input");
[INFO] [stderr] ...   |
[INFO] [stderr] 301 | |             }
[INFO] [stderr] 302 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 287 |         if input == 0
[INFO] [stderr] 288 | {
[INFO] [stderr] 289 |     println!("Invalid Input");
[INFO] [stderr] 290 |     continue;
[INFO] [stderr] 291 | }
[INFO] [stderr] 292 | else if unique_times.contains(&input)
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `num` is never read
[INFO] [stderr]   --> src/main.rs:47:17
[INFO] [stderr]    |
[INFO] [stderr] 47 |         let mut num = 0;
[INFO] [stderr]    |                 ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `num` is never read
[INFO] [stderr]   --> src/main.rs:86:17
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let mut num = 0;
[INFO] [stderr]    |                 ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `c` is never read
[INFO] [stderr]    --> src/main.rs:172:17
[INFO] [stderr]     |
[INFO] [stderr] 172 |         let mut c = ' ';
[INFO] [stderr]     |                 ^
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `c` is never read
[INFO] [stderr]    --> src/main.rs:211:17
[INFO] [stderr]     |
[INFO] [stderr] 211 |         let mut c = ' ';
[INFO] [stderr]     |                 ^
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `unique_characters` is never read
[INFO] [stderr]    --> src/main.rs:344:13
[INFO] [stderr]     |
[INFO] [stderr] 344 |     let mut unique_characters: HashSet<char> = HashSet::new();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `unique_characters` is never read
[INFO] [stderr]    --> src/main.rs:356:17
[INFO] [stderr]     |
[INFO] [stderr] 356 |                 unique_characters = HashSet::new();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `affinity` is never read
[INFO] [stderr]    --> src/main.rs:384:13
[INFO] [stderr]     |
[INFO] [stderr] 384 |     let mut affinity = String::new();
[INFO] [stderr]     |             ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:43:21
[INFO] [stderr]    |
[INFO] [stderr] 43 | fn get_start(trace: &Vec<char>) -> usize
[INFO] [stderr]    |                     ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:82:20
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn get_size(trace: &Vec<char>, start: usize) -> usize
[INFO] [stderr]    |                    ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:121:35
[INFO] [stderr]     |
[INFO] [stderr] 121 | fn get_affinity_window_set(trace: &Vec<char>, start: usize, size: usize) -> HashSet<char>
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             count = count + 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:156:8
[INFO] [stderr]     |
[INFO] [stderr] 156 |     if (aws.len() > 0)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!aws.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:246:23
[INFO] [stderr]     |
[INFO] [stderr] 246 | fn get_samples(trace: &Vec<char>) -> Vec<usize>
[INFO] [stderr]     |                       ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `num` is never read
[INFO] [stderr]   --> src/main.rs:47:17
[INFO] [stderr]    |
[INFO] [stderr] 47 |         let mut num = 0;
[INFO] [stderr]    |                 ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `num` is never read
[INFO] [stderr]   --> src/main.rs:86:17
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let mut num = 0;
[INFO] [stderr]    |                 ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `c` is never read
[INFO] [stderr]    --> src/main.rs:172:17
[INFO] [stderr]     |
[INFO] [stderr] 172 |         let mut c = ' ';
[INFO] [stderr]     |                 ^
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `c` is never read
[INFO] [stderr]    --> src/main.rs:211:17
[INFO] [stderr]     |
[INFO] [stderr] 211 |         let mut c = ' ';
[INFO] [stderr]     |                 ^
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `unique_characters` is never read
[INFO] [stderr]    --> src/main.rs:344:13
[INFO] [stderr]     |
[INFO] [stderr] 344 |     let mut unique_characters: HashSet<char> = HashSet::new();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `unique_characters` is never read
[INFO] [stderr]    --> src/main.rs:356:17
[INFO] [stderr]     |
[INFO] [stderr] 356 |                 unique_characters = HashSet::new();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `affinity` is never read
[INFO] [stderr]    --> src/main.rs:384:13
[INFO] [stderr]     |
[INFO] [stderr] 384 |     let mut affinity = String::new();
[INFO] [stderr]     |             ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:277:16
[INFO] [stderr]     |
[INFO] [stderr] 277 |             if unique_times.len() > 0
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!unique_times.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:341:24
[INFO] [stderr]     |
[INFO] [stderr] 341 | fn get_affinity(trace: &Vec<char>, a: char, b:char, size: usize, samples: &Vec<usize>)
[INFO] [stderr]     |                        ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:341:75
[INFO] [stderr]     |
[INFO] [stderr] 341 | fn get_affinity(trace: &Vec<char>, a: char, b:char, size: usize, samples: &Vec<usize>)
[INFO] [stderr]     |                                                                           ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:384:5
[INFO] [stderr]     |
[INFO] [stderr] 384 | /     let mut affinity = String::new();
[INFO] [stderr] 385 | |     if a_count > b_count
[INFO] [stderr] 386 | |     {
[INFO] [stderr] 387 | |         affinity = joint_count.to_string() + "/" + &a_count.to_string();
[INFO] [stderr] ...   |
[INFO] [stderr] 391 | |         affinity = joint_count.to_string() + "/" + &b_count.to_string();
[INFO] [stderr] 392 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> affinity = if a_count > b_count { joint_count.to_string() + "/" + &a_count.to_string() } else { joint_count.to_string() + "/" + &b_count.to_string() };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:369:13
[INFO] [stderr]     |
[INFO] [stderr] 369 |             joint_count = joint_count + 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `joint_count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:373:13
[INFO] [stderr]     |
[INFO] [stderr] 373 |             a_count = a_count + 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `a_count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:377:13
[INFO] [stderr]     |
[INFO] [stderr] 377 |             b_count = b_count + 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `b_count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:43:21
[INFO] [stderr]    |
[INFO] [stderr] 43 | fn get_start(trace: &Vec<char>) -> usize
[INFO] [stderr]    |                     ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:82:20
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn get_size(trace: &Vec<char>, start: usize) -> usize
[INFO] [stderr]    |                    ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:121:35
[INFO] [stderr]     |
[INFO] [stderr] 121 | fn get_affinity_window_set(trace: &Vec<char>, start: usize, size: usize) -> HashSet<char>
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             count = count + 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:156:8
[INFO] [stderr]     |
[INFO] [stderr] 156 |     if (aws.len() > 0)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!aws.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:246:23
[INFO] [stderr]     |
[INFO] [stderr] 246 | fn get_samples(trace: &Vec<char>) -> Vec<usize>
[INFO] [stderr]     |                       ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:277:16
[INFO] [stderr]     |
[INFO] [stderr] 277 |             if unique_times.len() > 0
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!unique_times.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:341:24
[INFO] [stderr]     |
[INFO] [stderr] 341 | fn get_affinity(trace: &Vec<char>, a: char, b:char, size: usize, samples: &Vec<usize>)
[INFO] [stderr]     |                        ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:341:75
[INFO] [stderr]     |
[INFO] [stderr] 341 | fn get_affinity(trace: &Vec<char>, a: char, b:char, size: usize, samples: &Vec<usize>)
[INFO] [stderr]     |                                                                           ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:384:5
[INFO] [stderr]     |
[INFO] [stderr] 384 | /     let mut affinity = String::new();
[INFO] [stderr] 385 | |     if a_count > b_count
[INFO] [stderr] 386 | |     {
[INFO] [stderr] 387 | |         affinity = joint_count.to_string() + "/" + &a_count.to_string();
[INFO] [stderr] ...   |
[INFO] [stderr] 391 | |         affinity = joint_count.to_string() + "/" + &b_count.to_string();
[INFO] [stderr] 392 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> affinity = if a_count > b_count { joint_count.to_string() + "/" + &a_count.to_string() } else { joint_count.to_string() + "/" + &b_count.to_string() };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:369:13
[INFO] [stderr]     |
[INFO] [stderr] 369 |             joint_count = joint_count + 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `joint_count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:373:13
[INFO] [stderr]     |
[INFO] [stderr] 373 |             a_count = a_count + 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `a_count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:377:13
[INFO] [stderr]     |
[INFO] [stderr] 377 |             b_count = b_count + 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `b_count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.76s
[INFO] running `"docker" "inspect" "68e1223b76d4ebf4e251016f5abb3b2e7ffd38b14ab5a8e300418a1d7b497f53"`
[INFO] running `"docker" "rm" "-f" "68e1223b76d4ebf4e251016f5abb3b2e7ffd38b14ab5a8e300418a1d7b497f53"`
[INFO] [stdout] 68e1223b76d4ebf4e251016f5abb3b2e7ffd38b14ab5a8e300418a1d7b497f53