[INFO] updating cached repository dangreco/rust-bsa-extract [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dangreco/rust-bsa-extract [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dangreco/rust-bsa-extract" "work/ex/clippy-test-run/sources/stable/gh/dangreco/rust-bsa-extract"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dangreco/rust-bsa-extract'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dangreco/rust-bsa-extract" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dangreco/rust-bsa-extract"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dangreco/rust-bsa-extract'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0da821715deba16273478fd9fe2e810f75264968 [INFO] sha for GitHub repo dangreco/rust-bsa-extract: 0da821715deba16273478fd9fe2e810f75264968 [INFO] validating manifest of dangreco/rust-bsa-extract on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dangreco/rust-bsa-extract on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dangreco/rust-bsa-extract [INFO] finished frobbing dangreco/rust-bsa-extract [INFO] frobbed toml for dangreco/rust-bsa-extract written to work/ex/clippy-test-run/sources/stable/gh/dangreco/rust-bsa-extract/Cargo.toml [INFO] started frobbing dangreco/rust-bsa-extract [INFO] finished frobbing dangreco/rust-bsa-extract [INFO] frobbed toml for dangreco/rust-bsa-extract written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dangreco/rust-bsa-extract/Cargo.toml [INFO] crate dangreco/rust-bsa-extract has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dangreco/rust-bsa-extract against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dangreco/rust-bsa-extract:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9976fd44efd7fc34f20675f475f9c8370ee29b34a428e1e3b5d0fd867c01c8e9 [INFO] running `"docker" "start" "-a" "9976fd44efd7fc34f20675f475f9c8370ee29b34a428e1e3b5d0fd867c01c8e9"` [INFO] [stderr] Checking pbr v1.0.1 [INFO] [stderr] Checking tes4-bsa-extract v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | Ok(v) => { return Some(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | Err(e) => { return None } [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | Ok(v) => { return Some(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | Err(e) => { return None } [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:40:20 [INFO] [stderr] | [INFO] [stderr] 40 | Ok(v) => { return Some((v, byte_length as usize + 1)) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((v, byte_length as usize + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | Err(e) => { return None } [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(v) => { return Some((v, byte_length as usize + 1)) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((v, byte_length as usize + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | Err(e) => { return None } [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | return Some((v, len + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((v, len + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | Err(e) => { return None } [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return Some(header); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(header)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | return folder_records; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `folder_records` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:196:5 [INFO] [stderr] | [INFO] [stderr] 196 | / return FileRecordBlock { [INFO] [stderr] 197 | | name: directory_name, [INFO] [stderr] 198 | | file_records [INFO] [stderr] 199 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 196 | FileRecordBlock { [INFO] [stderr] 197 | name: directory_name, [INFO] [stderr] 198 | file_records [INFO] [stderr] 199 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | return file_names; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | / return CompressedFileBlock { [INFO] [stderr] 237 | | hash: file_record.name_hash, [INFO] [stderr] 238 | | name, [INFO] [stderr] 239 | | original_size, [INFO] [stderr] 240 | | data: d[start+4..end].to_vec() [INFO] [stderr] 241 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 236 | CompressedFileBlock { [INFO] [stderr] 237 | hash: file_record.name_hash, [INFO] [stderr] 238 | name, [INFO] [stderr] 239 | original_size, [INFO] [stderr] 240 | data: d[start+4..end].to_vec() [INFO] [stderr] 241 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:257:5 [INFO] [stderr] | [INFO] [stderr] 257 | / return UncompressedFileBlock { [INFO] [stderr] 258 | | hash: file_record.name_hash, [INFO] [stderr] 259 | | name, [INFO] [stderr] 260 | | data: d[start..end].to_vec() [INFO] [stderr] 261 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 257 | UncompressedFileBlock { [INFO] [stderr] 258 | hash: file_record.name_hash, [INFO] [stderr] 259 | name, [INFO] [stderr] 260 | data: d[start..end].to_vec() [INFO] [stderr] 261 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | / return BSAParser { [INFO] [stderr] 273 | | data [INFO] [stderr] 274 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 272 | BSAParser { [INFO] [stderr] 273 | data [INFO] [stderr] 274 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | / return Some(BSA { [INFO] [stderr] 341 | | header, [INFO] [stderr] 342 | | folder_records, [INFO] [stderr] 343 | | file_record_blocks, [INFO] [stderr] ... | [INFO] [stderr] 346 | | file_names [INFO] [stderr] 347 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 340 | Some(BSA { [INFO] [stderr] 341 | header, [INFO] [stderr] 342 | folder_records, [INFO] [stderr] 343 | file_record_blocks, [INFO] [stderr] 344 | compressed_file_blocks, [INFO] [stderr] 345 | uncompressed_file_blocks, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bsa.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | return (None, None) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `UNIX_EPOCH` [INFO] [stderr] --> src/main.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | use std::time::{SystemTime, UNIX_EPOCH}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | Ok(v) => { return Some(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | Err(e) => { return None } [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | Ok(v) => { return Some(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | Err(e) => { return None } [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:40:20 [INFO] [stderr] | [INFO] [stderr] 40 | Ok(v) => { return Some((v, byte_length as usize + 1)) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((v, byte_length as usize + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | Err(e) => { return None } [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(v) => { return Some((v, byte_length as usize + 1)) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((v, byte_length as usize + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | Err(e) => { return None } [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | return Some((v, len + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((v, len + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | Err(e) => { return None } [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return Some(header); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(header)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | return folder_records; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `folder_records` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:196:5 [INFO] [stderr] | [INFO] [stderr] 196 | / return FileRecordBlock { [INFO] [stderr] 197 | | name: directory_name, [INFO] [stderr] 198 | | file_records [INFO] [stderr] 199 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 196 | FileRecordBlock { [INFO] [stderr] 197 | name: directory_name, [INFO] [stderr] 198 | file_records [INFO] [stderr] 199 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | return file_names; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | / return CompressedFileBlock { [INFO] [stderr] 237 | | hash: file_record.name_hash, [INFO] [stderr] 238 | | name, [INFO] [stderr] 239 | | original_size, [INFO] [stderr] 240 | | data: d[start+4..end].to_vec() [INFO] [stderr] 241 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 236 | CompressedFileBlock { [INFO] [stderr] 237 | hash: file_record.name_hash, [INFO] [stderr] 238 | name, [INFO] [stderr] 239 | original_size, [INFO] [stderr] 240 | data: d[start+4..end].to_vec() [INFO] [stderr] 241 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:257:5 [INFO] [stderr] | [INFO] [stderr] 257 | / return UncompressedFileBlock { [INFO] [stderr] 258 | | hash: file_record.name_hash, [INFO] [stderr] 259 | | name, [INFO] [stderr] 260 | | data: d[start..end].to_vec() [INFO] [stderr] 261 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 257 | UncompressedFileBlock { [INFO] [stderr] 258 | hash: file_record.name_hash, [INFO] [stderr] 259 | name, [INFO] [stderr] 260 | data: d[start..end].to_vec() [INFO] [stderr] 261 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | / return BSAParser { [INFO] [stderr] 273 | | data [INFO] [stderr] 274 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 272 | BSAParser { [INFO] [stderr] 273 | data [INFO] [stderr] 274 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | / return Some(BSA { [INFO] [stderr] 341 | | header, [INFO] [stderr] 342 | | folder_records, [INFO] [stderr] 343 | | file_record_blocks, [INFO] [stderr] ... | [INFO] [stderr] 346 | | file_names [INFO] [stderr] 347 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 340 | Some(BSA { [INFO] [stderr] 341 | header, [INFO] [stderr] 342 | folder_records, [INFO] [stderr] 343 | file_record_blocks, [INFO] [stderr] 344 | compressed_file_blocks, [INFO] [stderr] 345 | uncompressed_file_blocks, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bsa.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | return (None, None) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `UNIX_EPOCH` [INFO] [stderr] --> src/main.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | use std::time::{SystemTime, UNIX_EPOCH}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/data.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | Err(e) => { return None } [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/data.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | Err(e) => { return None } [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/data.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | Err(e) => { return None } [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/data.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | Err(e) => { return None } [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/data.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | Err(e) => { return None } [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/data.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | for i in 0..file_count { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `big_endian` [INFO] [stderr] --> src/data.rs:244:84 [INFO] [stderr] | [INFO] [stderr] 244 | fn get_uncompressed_file_block(d: &Vec, file_record: &FileRecord, ninth: bool, big_endian: bool) -> UncompressedFileBlock [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_big_endian` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cwd` [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let cwd = env::current_dir().unwrap(); [INFO] [stderr] | ^^^ help: consider using `_cwd` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `compressed_block` [INFO] [stderr] --> src/bsa.rs:165:25 [INFO] [stderr] | [INFO] [stderr] 165 | let compressed_block = comp.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_compressed_block` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NamedFiles` [INFO] [stderr] --> src/bsa.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | NamedFiles, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RetainDirs` [INFO] [stderr] --> src/bsa.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | RetainDirs, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RetainFiles` [INFO] [stderr] --> src/bsa.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | RetainFiles, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RetainOffsets` [INFO] [stderr] --> src/bsa.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | RetainOffsets, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RetainStrings` [INFO] [stderr] --> src/bsa.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | RetainStrings, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Unknown1` [INFO] [stderr] --> src/bsa.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | Unknown1, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Unknown2` [INFO] [stderr] --> src/bsa.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | Unknown2, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Unknown3` [INFO] [stderr] --> src/bsa.rs:196:5 [INFO] [stderr] | [INFO] [stderr] 196 | Unknown3 [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/data.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / let res; [INFO] [stderr] 8 | | if big_endian { [INFO] [stderr] 9 | | res = buf.read_u32::(); [INFO] [stderr] 10 | | } else { [INFO] [stderr] 11 | | res = buf.read_u32::(); [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let res = if big_endian { buf.read_u32::() } else { buf.read_u32::() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/data.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / let res; [INFO] [stderr] 23 | | if big_endian { [INFO] [stderr] 24 | | res = buf.read_u64::(); [INFO] [stderr] 25 | | } else { [INFO] [stderr] 26 | | res = buf.read_u64::(); [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let res = if big_endian { buf.read_u64::() } else { buf.read_u64::() };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/data.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | let string = &data[1..byte_length as usize + 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=byte_length as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/data.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | fn get_header(d: &Vec) -> Option
[INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/data.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | Err(e) => { return None } [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/data.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | Err(e) => { return None } [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/data.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | Err(e) => { return None } [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/data.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | Err(e) => { return None } [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/data.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | Err(e) => { return None } [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/data.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | for i in 0..file_count { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `big_endian` [INFO] [stderr] --> src/data.rs:244:84 [INFO] [stderr] | [INFO] [stderr] 244 | fn get_uncompressed_file_block(d: &Vec, file_record: &FileRecord, ninth: bool, big_endian: bool) -> UncompressedFileBlock [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_big_endian` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cwd` [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let cwd = env::current_dir().unwrap(); [INFO] [stderr] | ^^^ help: consider using `_cwd` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `compressed_block` [INFO] [stderr] --> src/bsa.rs:165:25 [INFO] [stderr] | [INFO] [stderr] 165 | let compressed_block = comp.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_compressed_block` instead [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/data.rs:138:26 [INFO] [stderr] | [INFO] [stderr] 138 | fn get_folder_records(d: &Vec, folder_count: u32, big_endian: bool) -> Vec [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/data.rs:164:29 [INFO] [stderr] | [INFO] [stderr] 164 | fn get_file_record_block(d: &Vec, folder_record: &FolderRecord, total_file_name_length: u32, named_directories: bool, big_endian: bool) -> FileRecordBlock [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/data.rs:202:22 [INFO] [stderr] | [INFO] [stderr] 202 | fn get_file_names(d: &Vec, offset: u32, file_count: u32) -> Vec [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/data.rs:220:33 [INFO] [stderr] | [INFO] [stderr] 220 | fn get_compressed_file_block(d: &Vec, file_record: &FileRecord, ninth: bool, big_endian: bool) -> CompressedFileBlock [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/data.rs:244:35 [INFO] [stderr] | [INFO] [stderr] 244 | fn get_uncompressed_file_block(d: &Vec, file_record: &FileRecord, ninth: bool, big_endian: bool) -> UncompressedFileBlock [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/data.rs:326:52 [INFO] [stderr] | [INFO] [stderr] 326 | let folder_name = block_clone.name.unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | name_hash: self.name_hash.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.name_hash` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | size: self.size.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | offset: self.offset.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:63:26 [INFO] [stderr] | [INFO] [stderr] 63 | self.name_hash = source.name_hash.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `source.name_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | self.size = source.size.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `source.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | self.offset = source.offset.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `source.offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | hash: self.hash.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | original_size: self.original_size.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.original_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | self.hash = source.hash.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `source.hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:90:30 [INFO] [stderr] | [INFO] [stderr] 90 | self.original_size = source.original_size.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `source.original_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:105:19 [INFO] [stderr] | [INFO] [stderr] 105 | hash: self.hash.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | self.hash = source.hash.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `source.hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bsa.rs:154:39 [INFO] [stderr] | [INFO] [stderr] 154 | let mut pb = ProgressBar::new(*count as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bsa.rs:157:85 [INFO] [stderr] | [INFO] [stderr] 157 | let path = format!("{}/{}", export_path, file_record_block.clone().name.unwrap_or(format!("{}", counter)).replace("\\", "/")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("{}", counter))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/bsa.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | fs::create_dir_all(&path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/bsa.rs:171:21 [INFO] [stderr] | [INFO] [stderr] 171 | fs::write(format!("{}/{}", path, file_name), uncompressed_block.data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:42:20 [INFO] [stderr] | [INFO] [stderr] 42 | if !bsa_opt.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `bsa_opt.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | reader.read_to_end(&mut buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:46:61 [INFO] [stderr] | [INFO] [stderr] 46 | let in_ms = duration.as_secs() * 1000 + duration.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NamedFiles` [INFO] [stderr] --> src/bsa.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | NamedFiles, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RetainDirs` [INFO] [stderr] --> src/bsa.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | RetainDirs, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RetainFiles` [INFO] [stderr] --> src/bsa.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | RetainFiles, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RetainOffsets` [INFO] [stderr] --> src/bsa.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | RetainOffsets, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RetainStrings` [INFO] [stderr] --> src/bsa.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | RetainStrings, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Unknown1` [INFO] [stderr] --> src/bsa.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | Unknown1, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Unknown2` [INFO] [stderr] --> src/bsa.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | Unknown2, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Unknown3` [INFO] [stderr] --> src/bsa.rs:196:5 [INFO] [stderr] | [INFO] [stderr] 196 | Unknown3 [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/data.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / let res; [INFO] [stderr] 8 | | if big_endian { [INFO] [stderr] 9 | | res = buf.read_u32::(); [INFO] [stderr] 10 | | } else { [INFO] [stderr] 11 | | res = buf.read_u32::(); [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let res = if big_endian { buf.read_u32::() } else { buf.read_u32::() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/data.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / let res; [INFO] [stderr] 23 | | if big_endian { [INFO] [stderr] 24 | | res = buf.read_u64::(); [INFO] [stderr] 25 | | } else { [INFO] [stderr] 26 | | res = buf.read_u64::(); [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let res = if big_endian { buf.read_u64::() } else { buf.read_u64::() };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/data.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | let string = &data[1..byte_length as usize + 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=byte_length as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/data.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | fn get_header(d: &Vec) -> Option
[INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/data.rs:138:26 [INFO] [stderr] | [INFO] [stderr] 138 | fn get_folder_records(d: &Vec, folder_count: u32, big_endian: bool) -> Vec [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/data.rs:164:29 [INFO] [stderr] | [INFO] [stderr] 164 | fn get_file_record_block(d: &Vec, folder_record: &FolderRecord, total_file_name_length: u32, named_directories: bool, big_endian: bool) -> FileRecordBlock [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/data.rs:202:22 [INFO] [stderr] | [INFO] [stderr] 202 | fn get_file_names(d: &Vec, offset: u32, file_count: u32) -> Vec [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/data.rs:220:33 [INFO] [stderr] | [INFO] [stderr] 220 | fn get_compressed_file_block(d: &Vec, file_record: &FileRecord, ninth: bool, big_endian: bool) -> CompressedFileBlock [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/data.rs:244:35 [INFO] [stderr] | [INFO] [stderr] 244 | fn get_uncompressed_file_block(d: &Vec, file_record: &FileRecord, ninth: bool, big_endian: bool) -> UncompressedFileBlock [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/data.rs:326:52 [INFO] [stderr] | [INFO] [stderr] 326 | let folder_name = block_clone.name.unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | name_hash: self.name_hash.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.name_hash` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | size: self.size.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | offset: self.offset.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:63:26 [INFO] [stderr] | [INFO] [stderr] 63 | self.name_hash = source.name_hash.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `source.name_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | self.size = source.size.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `source.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | self.offset = source.offset.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `source.offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | hash: self.hash.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | original_size: self.original_size.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.original_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | self.hash = source.hash.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `source.hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:90:30 [INFO] [stderr] | [INFO] [stderr] 90 | self.original_size = source.original_size.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `source.original_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:105:19 [INFO] [stderr] | [INFO] [stderr] 105 | hash: self.hash.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bsa.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | self.hash = source.hash.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `source.hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bsa.rs:154:39 [INFO] [stderr] | [INFO] [stderr] 154 | let mut pb = ProgressBar::new(*count as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bsa.rs:157:85 [INFO] [stderr] | [INFO] [stderr] 157 | let path = format!("{}/{}", export_path, file_record_block.clone().name.unwrap_or(format!("{}", counter)).replace("\\", "/")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("{}", counter))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/bsa.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | fs::create_dir_all(&path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/bsa.rs:171:21 [INFO] [stderr] | [INFO] [stderr] 171 | fs::write(format!("{}/{}", path, file_name), uncompressed_block.data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:42:20 [INFO] [stderr] | [INFO] [stderr] 42 | if !bsa_opt.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `bsa_opt.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | reader.read_to_end(&mut buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:46:61 [INFO] [stderr] | [INFO] [stderr] 46 | let in_ms = duration.as_secs() * 1000 + duration.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.54s [INFO] running `"docker" "inspect" "9976fd44efd7fc34f20675f475f9c8370ee29b34a428e1e3b5d0fd867c01c8e9"` [INFO] running `"docker" "rm" "-f" "9976fd44efd7fc34f20675f475f9c8370ee29b34a428e1e3b5d0fd867c01c8e9"` [INFO] [stdout] 9976fd44efd7fc34f20675f475f9c8370ee29b34a428e1e3b5d0fd867c01c8e9