[INFO] updating cached repository d3zd3z/sdial [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/d3zd3z/sdial [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/d3zd3z/sdial" "work/ex/clippy-test-run/sources/stable/gh/d3zd3z/sdial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/d3zd3z/sdial'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/d3zd3z/sdial" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d3zd3z/sdial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d3zd3z/sdial'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8ceb9a75e62a6bad94583636e076c8b0f91c7ad6 [INFO] sha for GitHub repo d3zd3z/sdial: 8ceb9a75e62a6bad94583636e076c8b0f91c7ad6 [INFO] validating manifest of d3zd3z/sdial on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of d3zd3z/sdial on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing d3zd3z/sdial [INFO] finished frobbing d3zd3z/sdial [INFO] frobbed toml for d3zd3z/sdial written to work/ex/clippy-test-run/sources/stable/gh/d3zd3z/sdial/Cargo.toml [INFO] started frobbing d3zd3z/sdial [INFO] finished frobbing d3zd3z/sdial [INFO] frobbed toml for d3zd3z/sdial written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d3zd3z/sdial/Cargo.toml [INFO] crate d3zd3z/sdial has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting d3zd3z/sdial against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d3zd3z/sdial:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4cbb5cb42d4e6c17bcb34cfee91adf3106f89fbeb53625c1de9a182cfae808fe [INFO] running `"docker" "start" "-a" "4cbb5cb42d4e6c17bcb34cfee91adf3106f89fbeb53625c1de9a182cfae808fe"` [INFO] [stderr] Checking clap v2.27.1 [INFO] [stderr] Checking sdial v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:70:32 [INFO] [stderr] | [INFO] [stderr] 70 | for binary in 0u64 .. (1 << 2*moves) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (2*moves)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:70:32 [INFO] [stderr] | [INFO] [stderr] 70 | for binary in 0u64 .. (1 << 2*moves) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (2*moves)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | for moves in 1..(max+1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | for moves in 1..(max+1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.96s [INFO] running `"docker" "inspect" "4cbb5cb42d4e6c17bcb34cfee91adf3106f89fbeb53625c1de9a182cfae808fe"` [INFO] running `"docker" "rm" "-f" "4cbb5cb42d4e6c17bcb34cfee91adf3106f89fbeb53625c1de9a182cfae808fe"` [INFO] [stdout] 4cbb5cb42d4e6c17bcb34cfee91adf3106f89fbeb53625c1de9a182cfae808fe