[INFO] updating cached repository cyplo/resin-rust-multidevice-example [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cyplo/resin-rust-multidevice-example [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cyplo/resin-rust-multidevice-example" "work/ex/clippy-test-run/sources/stable/gh/cyplo/resin-rust-multidevice-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cyplo/resin-rust-multidevice-example'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cyplo/resin-rust-multidevice-example" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cyplo/resin-rust-multidevice-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cyplo/resin-rust-multidevice-example'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 967973dff969b18f64136a223d3866915bcdf827 [INFO] sha for GitHub repo cyplo/resin-rust-multidevice-example: 967973dff969b18f64136a223d3866915bcdf827 [INFO] validating manifest of cyplo/resin-rust-multidevice-example on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cyplo/resin-rust-multidevice-example on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cyplo/resin-rust-multidevice-example [INFO] finished frobbing cyplo/resin-rust-multidevice-example [INFO] frobbed toml for cyplo/resin-rust-multidevice-example written to work/ex/clippy-test-run/sources/stable/gh/cyplo/resin-rust-multidevice-example/Cargo.toml [INFO] started frobbing cyplo/resin-rust-multidevice-example [INFO] finished frobbing cyplo/resin-rust-multidevice-example [INFO] frobbed toml for cyplo/resin-rust-multidevice-example written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cyplo/resin-rust-multidevice-example/Cargo.toml [INFO] crate cyplo/resin-rust-multidevice-example has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cyplo/resin-rust-multidevice-example against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cyplo/resin-rust-multidevice-example:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 90ef8a9242ad24a9b2001b1456eb4b265d2511feeb07b0e475d6541db5b839c7 [INFO] running `"docker" "start" "-a" "90ef8a9242ad24a9b2001b1456eb4b265d2511feeb07b0e475d6541db5b839c7"` [INFO] [stderr] Checking hello v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match value.trim().is_empty() { [INFO] [stderr] 13 | | true => Err("I can't say hello to empty NAME".to_string()), [INFO] [stderr] 14 | | false => Ok(()), [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if value.trim().is_empty() { Err("I can't say hello to empty NAME".to_string()) } else { Ok(()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match value.trim().is_empty() { [INFO] [stderr] 13 | | true => Err("I can't say hello to empty NAME".to_string()), [INFO] [stderr] 14 | | false => Ok(()), [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if value.trim().is_empty() { Err("I can't say hello to empty NAME".to_string()) } else { Ok(()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "90ef8a9242ad24a9b2001b1456eb4b265d2511feeb07b0e475d6541db5b839c7"` [INFO] running `"docker" "rm" "-f" "90ef8a9242ad24a9b2001b1456eb4b265d2511feeb07b0e475d6541db5b839c7"` [INFO] [stdout] 90ef8a9242ad24a9b2001b1456eb4b265d2511feeb07b0e475d6541db5b839c7