[INFO] updating cached repository ctlusto/gol
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ctlusto/gol
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ctlusto/gol" "work/ex/clippy-test-run/sources/stable/gh/ctlusto/gol"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ctlusto/gol'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ctlusto/gol" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ctlusto/gol"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ctlusto/gol'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 77d68915fef2048a78b55a0a46c4e2adee872fe1
[INFO] sha for GitHub repo ctlusto/gol: 77d68915fef2048a78b55a0a46c4e2adee872fe1
[INFO] validating manifest of ctlusto/gol on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ctlusto/gol on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ctlusto/gol
[INFO] finished frobbing ctlusto/gol
[INFO] frobbed toml for ctlusto/gol written to work/ex/clippy-test-run/sources/stable/gh/ctlusto/gol/Cargo.toml
[INFO] started frobbing ctlusto/gol
[INFO] finished frobbing ctlusto/gol
[INFO] frobbed toml for ctlusto/gol written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ctlusto/gol/Cargo.toml
[INFO] crate ctlusto/gol has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ctlusto/gol against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ctlusto/gol:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 09c381df89c3dd95f7e0c23d13853972ce3574aeb76e07b9bcbb1be8e2976884
[INFO] running `"docker" "start" "-a" "09c381df89c3dd95f7e0c23d13853972ce3574aeb76e07b9bcbb1be8e2976884"`
[INFO] [stderr]     Checking gol v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:80:32
[INFO] [stderr]    |
[INFO] [stderr] 80 |     fn should_live(&self, idx: &usize) -> bool {
[INFO] [stderr]    |                                ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:88:9
[INFO] [stderr]    |
[INFO] [stderr] 88 | /         let min_row: usize;
[INFO] [stderr] 89 | |         if pos.0 == 0 {
[INFO] [stderr] 90 | |             min_row = 0;
[INFO] [stderr] 91 | |         } else{
[INFO] [stderr] 92 | |             min_row = pos.0 - 1;
[INFO] [stderr] 93 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let min_row = if pos.0 == 0 { 0 } else { pos.0 - 1 };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:95:9
[INFO] [stderr]     |
[INFO] [stderr] 95  | /         let min_col: usize;
[INFO] [stderr] 96  | |         if pos.1 == 0 {
[INFO] [stderr] 97  | |             min_col = 0;
[INFO] [stderr] 98  | |         } else{
[INFO] [stderr] 99  | |             min_col = pos.1 - 1;
[INFO] [stderr] 100 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let min_col = if pos.1 == 0 { 0 } else { pos.1 - 1 };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:120:31
[INFO] [stderr]     |
[INFO] [stderr] 120 |     fn idx_to_pos(&self, idx: &usize) -> Pos {
[INFO] [stderr]     |                               ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:146:17
[INFO] [stderr]     |
[INFO] [stderr] 146 | /                 match self.is_alive(&(r, c)) {
[INFO] [stderr] 147 | |                     true => s.push(ALIVE_CHAR),
[INFO] [stderr] 148 | |                     false => s.push(DEAD_CHAR),
[INFO] [stderr] 149 | |                 }
[INFO] [stderr]     | |_________________^ help: consider using an if/else expression: `if self.is_alive(&(r, c)) { s.push(ALIVE_CHAR) } else { s.push(DEAD_CHAR) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:80:32
[INFO] [stderr]    |
[INFO] [stderr] 80 |     fn should_live(&self, idx: &usize) -> bool {
[INFO] [stderr]    |                                ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:88:9
[INFO] [stderr]    |
[INFO] [stderr] 88 | /         let min_row: usize;
[INFO] [stderr] 89 | |         if pos.0 == 0 {
[INFO] [stderr] 90 | |             min_row = 0;
[INFO] [stderr] 91 | |         } else{
[INFO] [stderr] 92 | |             min_row = pos.0 - 1;
[INFO] [stderr] 93 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let min_row = if pos.0 == 0 { 0 } else { pos.0 - 1 };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:95:9
[INFO] [stderr]     |
[INFO] [stderr] 95  | /         let min_col: usize;
[INFO] [stderr] 96  | |         if pos.1 == 0 {
[INFO] [stderr] 97  | |             min_col = 0;
[INFO] [stderr] 98  | |         } else{
[INFO] [stderr] 99  | |             min_col = pos.1 - 1;
[INFO] [stderr] 100 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let min_col = if pos.1 == 0 { 0 } else { pos.1 - 1 };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:120:31
[INFO] [stderr]     |
[INFO] [stderr] 120 |     fn idx_to_pos(&self, idx: &usize) -> Pos {
[INFO] [stderr]     |                               ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:146:17
[INFO] [stderr]     |
[INFO] [stderr] 146 | /                 match self.is_alive(&(r, c)) {
[INFO] [stderr] 147 | |                     true => s.push(ALIVE_CHAR),
[INFO] [stderr] 148 | |                     false => s.push(DEAD_CHAR),
[INFO] [stderr] 149 | |                 }
[INFO] [stderr]     | |_________________^ help: consider using an if/else expression: `if self.is_alive(&(r, c)) { s.push(ALIVE_CHAR) } else { s.push(DEAD_CHAR) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.62s
[INFO] running `"docker" "inspect" "09c381df89c3dd95f7e0c23d13853972ce3574aeb76e07b9bcbb1be8e2976884"`
[INFO] running `"docker" "rm" "-f" "09c381df89c3dd95f7e0c23d13853972ce3574aeb76e07b9bcbb1be8e2976884"`
[INFO] [stdout] 09c381df89c3dd95f7e0c23d13853972ce3574aeb76e07b9bcbb1be8e2976884