[INFO] updating cached repository ctlevi/adventofcode2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ctlevi/adventofcode2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ctlevi/adventofcode2017" "work/ex/clippy-test-run/sources/stable/gh/ctlevi/adventofcode2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ctlevi/adventofcode2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ctlevi/adventofcode2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ctlevi/adventofcode2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ctlevi/adventofcode2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 188a5897af018944e120eb4190d54bfa69098947 [INFO] sha for GitHub repo ctlevi/adventofcode2017: 188a5897af018944e120eb4190d54bfa69098947 [INFO] validating manifest of ctlevi/adventofcode2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ctlevi/adventofcode2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ctlevi/adventofcode2017 [INFO] finished frobbing ctlevi/adventofcode2017 [INFO] frobbed toml for ctlevi/adventofcode2017 written to work/ex/clippy-test-run/sources/stable/gh/ctlevi/adventofcode2017/Cargo.toml [INFO] started frobbing ctlevi/adventofcode2017 [INFO] finished frobbing ctlevi/adventofcode2017 [INFO] frobbed toml for ctlevi/adventofcode2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ctlevi/adventofcode2017/Cargo.toml [INFO] crate ctlevi/adventofcode2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ctlevi/adventofcode2017 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ctlevi/adventofcode2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2280fc785068b7408173aeba360e77893d2aea6a8933aadd0f91e5d6e7e8efa1 [INFO] running `"docker" "start" "-a" "2280fc785068b7408173aeba360e77893d2aea6a8933aadd0f91e5d6e7e8efa1"` [INFO] [stderr] Checking adventofcode2017 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day1.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day1.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return checksum; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return checksum; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day3.rs:1:21 [INFO] [stderr] | [INFO] [stderr] 1 | static INPUT: u32 = 368078; [INFO] [stderr] | ^^^^^^ help: consider: `368_078` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day3.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return (x.abs() + y.abs()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(x.abs() + y.abs()) as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day3.rs:191:20 [INFO] [stderr] | [INFO] [stderr] 191 | assert_eq!(369601, part2(INPUT)); [INFO] [stderr] | ^^^^^^ help: consider: `369_601` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day4.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day4.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day5.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return steps; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `steps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day5.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return steps; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `steps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day5.rs:63:20 [INFO] [stderr] | [INFO] [stderr] 63 | assert_eq!(381680, part1(&input)); [INFO] [stderr] | ^^^^^^ help: consider: `381_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day5.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | assert_eq!(29717847, part2(&input)); [INFO] [stderr] | ^^^^^^^^ help: consider: `29_717_847` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day1.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day1.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return checksum; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return checksum; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day3.rs:1:21 [INFO] [stderr] | [INFO] [stderr] 1 | static INPUT: u32 = 368078; [INFO] [stderr] | ^^^^^^ help: consider: `368_078` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day3.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return (x.abs() + y.abs()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(x.abs() + y.abs()) as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day4.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day4.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day5.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return steps; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `steps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day5.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return steps; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `steps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.68s [INFO] running `"docker" "inspect" "2280fc785068b7408173aeba360e77893d2aea6a8933aadd0f91e5d6e7e8efa1"` [INFO] running `"docker" "rm" "-f" "2280fc785068b7408173aeba360e77893d2aea6a8933aadd0f91e5d6e7e8efa1"` [INFO] [stdout] 2280fc785068b7408173aeba360e77893d2aea6a8933aadd0f91e5d6e7e8efa1