[INFO] updating cached repository ctfhacker/frida-hit [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ctfhacker/frida-hit [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ctfhacker/frida-hit" "work/ex/clippy-test-run/sources/stable/gh/ctfhacker/frida-hit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ctfhacker/frida-hit'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ctfhacker/frida-hit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ctfhacker/frida-hit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ctfhacker/frida-hit'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8198e0cf43602d21b1de5508b72db92e003562ae [INFO] sha for GitHub repo ctfhacker/frida-hit: 8198e0cf43602d21b1de5508b72db92e003562ae [INFO] validating manifest of ctfhacker/frida-hit on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ctfhacker/frida-hit on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ctfhacker/frida-hit [INFO] finished frobbing ctfhacker/frida-hit [INFO] frobbed toml for ctfhacker/frida-hit written to work/ex/clippy-test-run/sources/stable/gh/ctfhacker/frida-hit/Cargo.toml [INFO] started frobbing ctfhacker/frida-hit [INFO] finished frobbing ctfhacker/frida-hit [INFO] frobbed toml for ctfhacker/frida-hit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ctfhacker/frida-hit/Cargo.toml [INFO] crate ctfhacker/frida-hit has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ctfhacker/frida-hit against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ctfhacker/frida-hit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e1b2383f8d4eaddff713da3a2ec0434743faa5175a8b2d633f96f089b604e6d7 [INFO] running `"docker" "start" "-a" "e1b2383f8d4eaddff713da3a2ec0434743faa5175a8b2d633f96f089b604e6d7"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking frida-hit v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/main.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | use std::fs::{self, File}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/main.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | use nom::IResult::{Done, self}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:152:32 [INFO] [stderr] | [INFO] [stderr] 152 | ", offset=format!("{:#x}", num-0x400000), func_name=func.name, arguments=frida_arguments, self_args=self_args, return_type=func.return_type); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/main.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | use std::fs::{self, File}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/main.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | use nom::IResult::{Done, self}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:152:32 [INFO] [stderr] | [INFO] [stderr] 152 | ", offset=format!("{:#x}", num-0x400000), func_name=func.name, arguments=frida_arguments, self_args=self_args, return_type=func.return_type); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `length` [INFO] [stderr] --> src/main.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | let length = BufReader::new(file).read_to_string(&mut data)?; [INFO] [stderr] | ^^^^^^ help: consider using `_length` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:106:43 [INFO] [stderr] | [INFO] [stderr] 106 | let mut file_data: Vec = vec!(String::from(format!("var base = parseInt(Module.findBaseAddress('{}'));", binary_name))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("var base = parseInt(Module.findBaseAddress('{}'));", binary_name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | / match res { [INFO] [stderr] 116 | | Done(_, func) => { [INFO] [stderr] 117 | | // println!("{:#?}", func); [INFO] [stderr] 118 | | let frida_arguments = match func.frida_arguments().len() { [INFO] [stderr] ... | [INFO] [stderr] 181 | | _ => { } [INFO] [stderr] 182 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | if let Done(_, func) = res { [INFO] [stderr] 116 | // println!("{:#?}", func); [INFO] [stderr] 117 | let frida_arguments = match func.frida_arguments().len() { [INFO] [stderr] 118 | 0 => String::from("''"), [INFO] [stderr] 119 | _ => func.frida_arguments() [INFO] [stderr] 120 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | / match file.write_all(file_data.join("\n").as_bytes()) { [INFO] [stderr] 194 | | Err(why) => panic!("couldn't write to {}: {}", filepath, why.description()), [INFO] [stderr] 195 | | Ok(_) => { [INFO] [stderr] 196 | | // println!("successfully wrote to {}", filepath), [INFO] [stderr] 197 | | } [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.write_all(file_data.join("\n").as_bytes()) { panic!("couldn't write to {}: {}", filepath, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused variable: `length` [INFO] [stderr] --> src/main.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | let length = BufReader::new(file).read_to_string(&mut data)?; [INFO] [stderr] | ^^^^^^ help: consider using `_length` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:106:43 [INFO] [stderr] | [INFO] [stderr] 106 | let mut file_data: Vec = vec!(String::from(format!("var base = parseInt(Module.findBaseAddress('{}'));", binary_name))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("var base = parseInt(Module.findBaseAddress('{}'));", binary_name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | / match res { [INFO] [stderr] 116 | | Done(_, func) => { [INFO] [stderr] 117 | | // println!("{:#?}", func); [INFO] [stderr] 118 | | let frida_arguments = match func.frida_arguments().len() { [INFO] [stderr] ... | [INFO] [stderr] 181 | | _ => { } [INFO] [stderr] 182 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | if let Done(_, func) = res { [INFO] [stderr] 116 | // println!("{:#?}", func); [INFO] [stderr] 117 | let frida_arguments = match func.frida_arguments().len() { [INFO] [stderr] 118 | 0 => String::from("''"), [INFO] [stderr] 119 | _ => func.frida_arguments() [INFO] [stderr] 120 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | / match file.write_all(file_data.join("\n").as_bytes()) { [INFO] [stderr] 194 | | Err(why) => panic!("couldn't write to {}: {}", filepath, why.description()), [INFO] [stderr] 195 | | Ok(_) => { [INFO] [stderr] 196 | | // println!("successfully wrote to {}", filepath), [INFO] [stderr] 197 | | } [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.write_all(file_data.join("\n").as_bytes()) { panic!("couldn't write to {}: {}", filepath, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.21s [INFO] running `"docker" "inspect" "e1b2383f8d4eaddff713da3a2ec0434743faa5175a8b2d633f96f089b604e6d7"` [INFO] running `"docker" "rm" "-f" "e1b2383f8d4eaddff713da3a2ec0434743faa5175a8b2d633f96f089b604e6d7"` [INFO] [stdout] e1b2383f8d4eaddff713da3a2ec0434743faa5175a8b2d633f96f089b604e6d7