[INFO] updating cached repository csf/wator-wasm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/csf/wator-wasm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/csf/wator-wasm" "work/ex/clippy-test-run/sources/stable/gh/csf/wator-wasm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/csf/wator-wasm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/csf/wator-wasm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csf/wator-wasm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csf/wator-wasm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b4f3cb1c2734bc77e21403f24834665cd0ce6ad5 [INFO] sha for GitHub repo csf/wator-wasm: b4f3cb1c2734bc77e21403f24834665cd0ce6ad5 [INFO] validating manifest of csf/wator-wasm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of csf/wator-wasm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing csf/wator-wasm [INFO] finished frobbing csf/wator-wasm [INFO] frobbed toml for csf/wator-wasm written to work/ex/clippy-test-run/sources/stable/gh/csf/wator-wasm/Cargo.toml [INFO] started frobbing csf/wator-wasm [INFO] finished frobbing csf/wator-wasm [INFO] frobbed toml for csf/wator-wasm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csf/wator-wasm/Cargo.toml [INFO] crate csf/wator-wasm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting csf/wator-wasm against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csf/wator-wasm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 51f640947d6b9eba46599ed6b112a3966422bba2205fe05e9e8784a54de949f3 [INFO] running `"docker" "start" "-a" "51f640947d6b9eba46599ed6b112a3966422bba2205fe05e9e8784a54de949f3"` [INFO] [stderr] Checking wator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rand.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | q: q, [INFO] [stderr] | ^^^^ help: replace it with: `q` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rand.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | q: q, [INFO] [stderr] | ^^^^ help: replace it with: `q` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/world.rs:224:42 [INFO] [stderr] | [INFO] [stderr] 224 | else { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 225 | | if s.ate+1 < self.shark_starve { [INFO] [stderr] 226 | | let next_shark = Particle { row: r, col: c, ate: s.ate+1, born: s.born, reproduced: s.reproduced+1 }; [INFO] [stderr] 227 | | next_shark_list.items.push(next_shark); [INFO] [stderr] 228 | | } [INFO] [stderr] 229 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 224 | else if s.ate+1 < self.shark_starve { [INFO] [stderr] 225 | let next_shark = Particle { row: r, col: c, ate: s.ate+1, born: s.born, reproduced: s.reproduced+1 }; [INFO] [stderr] 226 | next_shark_list.items.push(next_shark); [INFO] [stderr] 227 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rand.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | const PHI: u32 = 0x9e3779b9; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x9e37_79b9` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rand.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | c: 362436, [INFO] [stderr] | ^^^^^^ help: consider: `362_436` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rand.rs:54:24 [INFO] [stderr] | [INFO] [stderr] 54 | const R: u32 = 0xfffffffe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/world.rs:224:42 [INFO] [stderr] | [INFO] [stderr] 224 | else { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 225 | | if s.ate+1 < self.shark_starve { [INFO] [stderr] 226 | | let next_shark = Particle { row: r, col: c, ate: s.ate+1, born: s.born, reproduced: s.reproduced+1 }; [INFO] [stderr] 227 | | next_shark_list.items.push(next_shark); [INFO] [stderr] 228 | | } [INFO] [stderr] 229 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 224 | else if s.ate+1 < self.shark_starve { [INFO] [stderr] 225 | let next_shark = Particle { row: r, col: c, ate: s.ate+1, born: s.born, reproduced: s.reproduced+1 }; [INFO] [stderr] 226 | next_shark_list.items.push(next_shark); [INFO] [stderr] 227 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rand.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | const PHI: u32 = 0x9e3779b9; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x9e37_79b9` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rand.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | c: 362436, [INFO] [stderr] | ^^^^^^ help: consider: `362_436` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rand.rs:54:24 [INFO] [stderr] | [INFO] [stderr] 54 | const R: u32 = 0xfffffffe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/world.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | return Some(p.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/world.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | return Some(p.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rand.rs:41:33 [INFO] [stderr] | [INFO] [stderr] 41 | let window = &mut q[i - 3..i + 1]; [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `i - 3..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rand.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | let t = A * self.q[self.i] as u64 + self.c as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.q[self.i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rand.rs:57:45 [INFO] [stderr] | [INFO] [stderr] 57 | let t = A * self.q[self.i] as u64 + self.c as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rand.rs:60:26 [INFO] [stderr] | [INFO] [stderr] 60 | let mut x = (t + self.c as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:51:27 [INFO] [stderr] | [INFO] [stderr] 51 | draw_fish(x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:51:37 [INFO] [stderr] | [INFO] [stderr] 51 | draw_fish(x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:57:28 [INFO] [stderr] | [INFO] [stderr] 57 | draw_shark(x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:57:38 [INFO] [stderr] | [INFO] [stderr] 57 | draw_shark(x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | draw_status(f as f64, s as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:60:27 [INFO] [stderr] | [INFO] [stderr] 60 | draw_status(f as f64, s as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:61:39 [INFO] [stderr] | [INFO] [stderr] 61 | draw_debug(data.world_state.time, (data.world_state.epoch as f64) / data.world_state.time as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(data.world_state.epoch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rand.rs:41:33 [INFO] [stderr] | [INFO] [stderr] 41 | let window = &mut q[i - 3..i + 1]; [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `i - 3..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rand.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | let t = A * self.q[self.i] as u64 + self.c as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.q[self.i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rand.rs:57:45 [INFO] [stderr] | [INFO] [stderr] 57 | let t = A * self.q[self.i] as u64 + self.c as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rand.rs:60:26 [INFO] [stderr] | [INFO] [stderr] 60 | let mut x = (t + self.c as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:51:27 [INFO] [stderr] | [INFO] [stderr] 51 | draw_fish(x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:51:37 [INFO] [stderr] | [INFO] [stderr] 51 | draw_fish(x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:57:28 [INFO] [stderr] | [INFO] [stderr] 57 | draw_shark(x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:57:38 [INFO] [stderr] | [INFO] [stderr] 57 | draw_shark(x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | draw_status(f as f64, s as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:60:27 [INFO] [stderr] | [INFO] [stderr] 60 | draw_status(f as f64, s as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:61:39 [INFO] [stderr] | [INFO] [stderr] 61 | draw_debug(data.world_state.time, (data.world_state.epoch as f64) / data.world_state.time as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(data.world_state.epoch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.10s [INFO] running `"docker" "inspect" "51f640947d6b9eba46599ed6b112a3966422bba2205fe05e9e8784a54de949f3"` [INFO] running `"docker" "rm" "-f" "51f640947d6b9eba46599ed6b112a3966422bba2205fe05e9e8784a54de949f3"` [INFO] [stdout] 51f640947d6b9eba46599ed6b112a3966422bba2205fe05e9e8784a54de949f3