[INFO] updating cached repository crystalboxes/ascii-canvas
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/crystalboxes/ascii-canvas
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/crystalboxes/ascii-canvas" "work/ex/clippy-test-run/sources/stable/gh/crystalboxes/ascii-canvas"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/crystalboxes/ascii-canvas'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/crystalboxes/ascii-canvas" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crystalboxes/ascii-canvas"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crystalboxes/ascii-canvas'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a6b45d6c3c9c85d2dabfd3b8faf8fe20aa62719a
[INFO] sha for GitHub repo crystalboxes/ascii-canvas: a6b45d6c3c9c85d2dabfd3b8faf8fe20aa62719a
[INFO] validating manifest of crystalboxes/ascii-canvas on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of crystalboxes/ascii-canvas on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing crystalboxes/ascii-canvas
[INFO] finished frobbing crystalboxes/ascii-canvas
[INFO] frobbed toml for crystalboxes/ascii-canvas written to work/ex/clippy-test-run/sources/stable/gh/crystalboxes/ascii-canvas/Cargo.toml
[INFO] started frobbing crystalboxes/ascii-canvas
[INFO] finished frobbing crystalboxes/ascii-canvas
[INFO] frobbed toml for crystalboxes/ascii-canvas written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crystalboxes/ascii-canvas/Cargo.toml
[INFO] crate crystalboxes/ascii-canvas has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting crystalboxes/ascii-canvas against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crystalboxes/ascii-canvas:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 333baa43487debf1b57d6990bdc0b78d80ef079ebc9315eb99d8275b1e957448
[INFO] running `"docker" "start" "-a" "333baa43487debf1b57d6990bdc0b78d80ef079ebc9315eb99d8275b1e957448"`
[INFO] [stderr]     Checking ascii-canvas v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/vec2.rs:21:10
[INFO] [stderr]    |
[INFO] [stderr] 21 |   Vec2 { x: x, y: y }
[INFO] [stderr]    |          ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/vec2.rs:21:16
[INFO] [stderr]    |
[INFO] [stderr] 21 |   Vec2 { x: x, y: y }
[INFO] [stderr]    |                ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:53:7
[INFO] [stderr]    |
[INFO] [stderr] 53 |       pixel_processor: pixel_processor,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixel_processor`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/vec2.rs:21:10
[INFO] [stderr]    |
[INFO] [stderr] 21 |   Vec2 { x: x, y: y }
[INFO] [stderr]    |          ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/vec2.rs:21:16
[INFO] [stderr]    |
[INFO] [stderr] 21 |   Vec2 { x: x, y: y }
[INFO] [stderr]    |                ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:53:7
[INFO] [stderr]    |
[INFO] [stderr] 53 |       pixel_processor: pixel_processor,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixel_processor`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:22:23
[INFO] [stderr]    |
[INFO] [stderr] 22 |       frame_delay_ms: 33.333333,
[INFO] [stderr]    |                       ^^^^^^^^^ help: consider: `33.333_333`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:22:23
[INFO] [stderr]    |
[INFO] [stderr] 22 |       frame_delay_ms: 33.333333,
[INFO] [stderr]    |                       ^^^^^^^^^ help: consider: `33.333_333`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/display.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 |                 (screen_buffer.data[index] as f32) / 255.0 * (greyscale_map.len() as f32);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(screen_buffer.data[index])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/pixel_processing.rs:42:20
[INFO] [stderr]    |
[INFO] [stderr] 42 |   pixel_processor: &Box<dyn PixelProcessor>,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn PixelProcessor`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/bmp_reader.rs:13:10
[INFO] [stderr]    |
[INFO] [stderr] 13 |     if let Err(_) = file.read(&mut header_info) {
[INFO] [stderr]    |  ___-      ^^^^^^
[INFO] [stderr] 14 | |     return Err("Couldn't read header");
[INFO] [stderr] 15 | |   }
[INFO] [stderr]    | |___- help: try this: `if file.read(&mut header_info).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/bmp_reader.rs:23:8
[INFO] [stderr]    |
[INFO] [stderr] 23 |       *ptr.offset(x as isize) = header_info[offset + x];
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/bmp_reader.rs:42:10
[INFO] [stderr]    |
[INFO] [stderr] 42 |     if let Err(_) = file.read(&mut pixels_raw) {
[INFO] [stderr]    |  ___-      ^^^^^^
[INFO] [stderr] 43 | |     return Err("Couldn't read pixels");
[INFO] [stderr] 44 | |   }
[INFO] [stderr]    | |___- help: try this: `if file.read(&mut pixels_raw).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/bmp_reader.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 |         pixels_raw[index * 3 + 2] as f32 / 255.0,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixels_raw[index * 3 + 2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/bmp_reader.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         pixels_raw[index * 3 + 1] as f32 / 255.0,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixels_raw[index * 3 + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/bmp_reader.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |         pixels_raw[index * 3 + 0] as f32 / 255.0,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixels_raw[index * 3 + 0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `index * 3`
[INFO] [stderr]   --> src/bmp_reader.rs:55:20
[INFO] [stderr]    |
[INFO] [stderr] 55 |         pixels_raw[index * 3 + 0] as f32 / 255.0,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/vec2.rs:25:15
[INFO] [stderr]    |
[INFO] [stderr] 25 |   pub fn lerp(&self, b: Vec2, t: f32) -> Vec2 {
[INFO] [stderr]    |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/vec2.rs:29:19
[INFO] [stderr]    |
[INFO] [stderr] 29 |   pub fn as_tuple(&self) -> (f32, f32) {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/lib.rs:93:12
[INFO] [stderr]    |
[INFO] [stderr] 93 |       if let None = opt {
[INFO] [stderr]    |  _____-      ^^^^
[INFO] [stderr] 94 | |       return default;
[INFO] [stderr] 95 | |     };
[INFO] [stderr]    | |_____- help: try this: `if opt.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/lib.rs:103:22
[INFO] [stderr]     |
[INFO] [stderr] 103 |   let mut arg = args.into_iter();
[INFO] [stderr]     |                      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/lib.rs:108:12
[INFO] [stderr]     |
[INFO] [stderr] 108 |       if let None = next_iter {
[INFO] [stderr]     |  _____-      ^^^^
[INFO] [stderr] 109 | |       break;
[INFO] [stderr] 110 | |     }
[INFO] [stderr]     | |_____- help: try this: `if next_iter.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/display.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 |                 (screen_buffer.data[index] as f32) / 255.0 * (greyscale_map.len() as f32);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(screen_buffer.data[index])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/pixel_processing.rs:42:20
[INFO] [stderr]    |
[INFO] [stderr] 42 |   pixel_processor: &Box<dyn PixelProcessor>,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn PixelProcessor`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/bmp_reader.rs:13:10
[INFO] [stderr]    |
[INFO] [stderr] 13 |     if let Err(_) = file.read(&mut header_info) {
[INFO] [stderr]    |  ___-      ^^^^^^
[INFO] [stderr] 14 | |     return Err("Couldn't read header");
[INFO] [stderr] 15 | |   }
[INFO] [stderr]    | |___- help: try this: `if file.read(&mut header_info).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/bmp_reader.rs:23:8
[INFO] [stderr]    |
[INFO] [stderr] 23 |       *ptr.offset(x as isize) = header_info[offset + x];
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/bmp_reader.rs:42:10
[INFO] [stderr]    |
[INFO] [stderr] 42 |     if let Err(_) = file.read(&mut pixels_raw) {
[INFO] [stderr]    |  ___-      ^^^^^^
[INFO] [stderr] 43 | |     return Err("Couldn't read pixels");
[INFO] [stderr] 44 | |   }
[INFO] [stderr]    | |___- help: try this: `if file.read(&mut pixels_raw).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/bmp_reader.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 |         pixels_raw[index * 3 + 2] as f32 / 255.0,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixels_raw[index * 3 + 2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/bmp_reader.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         pixels_raw[index * 3 + 1] as f32 / 255.0,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixels_raw[index * 3 + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/bmp_reader.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |         pixels_raw[index * 3 + 0] as f32 / 255.0,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixels_raw[index * 3 + 0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `index * 3`
[INFO] [stderr]   --> src/bmp_reader.rs:55:20
[INFO] [stderr]    |
[INFO] [stderr] 55 |         pixels_raw[index * 3 + 0] as f32 / 255.0,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/vec2.rs:25:15
[INFO] [stderr]    |
[INFO] [stderr] 25 |   pub fn lerp(&self, b: Vec2, t: f32) -> Vec2 {
[INFO] [stderr]    |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/vec2.rs:29:19
[INFO] [stderr]    |
[INFO] [stderr] 29 |   pub fn as_tuple(&self) -> (f32, f32) {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/lib.rs:93:12
[INFO] [stderr]    |
[INFO] [stderr] 93 |       if let None = opt {
[INFO] [stderr]    |  _____-      ^^^^
[INFO] [stderr] 94 | |       return default;
[INFO] [stderr] 95 | |     };
[INFO] [stderr]    | |_____- help: try this: `if opt.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/lib.rs:103:22
[INFO] [stderr]     |
[INFO] [stderr] 103 |   let mut arg = args.into_iter();
[INFO] [stderr]     |                      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/lib.rs:108:12
[INFO] [stderr]     |
[INFO] [stderr] 108 |       if let None = next_iter {
[INFO] [stderr]     |  _____-      ^^^^
[INFO] [stderr] 109 | |       break;
[INFO] [stderr] 110 | |     }
[INFO] [stderr]     | |_____- help: try this: `if next_iter.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.58s
[INFO] running `"docker" "inspect" "333baa43487debf1b57d6990bdc0b78d80ef079ebc9315eb99d8275b1e957448"`
[INFO] running `"docker" "rm" "-f" "333baa43487debf1b57d6990bdc0b78d80ef079ebc9315eb99d8275b1e957448"`
[INFO] [stdout] 333baa43487debf1b57d6990bdc0b78d80ef079ebc9315eb99d8275b1e957448