[INFO] updating cached repository crossedxd/rust_ga [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/crossedxd/rust_ga [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/crossedxd/rust_ga" "work/ex/clippy-test-run/sources/stable/gh/crossedxd/rust_ga"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/crossedxd/rust_ga'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/crossedxd/rust_ga" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crossedxd/rust_ga"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crossedxd/rust_ga'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cb40d925420d32383af2a803ae778eb3c759fa05 [INFO] sha for GitHub repo crossedxd/rust_ga: cb40d925420d32383af2a803ae778eb3c759fa05 [INFO] validating manifest of crossedxd/rust_ga on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of crossedxd/rust_ga on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing crossedxd/rust_ga [INFO] finished frobbing crossedxd/rust_ga [INFO] frobbed toml for crossedxd/rust_ga written to work/ex/clippy-test-run/sources/stable/gh/crossedxd/rust_ga/Cargo.toml [INFO] started frobbing crossedxd/rust_ga [INFO] finished frobbing crossedxd/rust_ga [INFO] frobbed toml for crossedxd/rust_ga written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crossedxd/rust_ga/Cargo.toml [INFO] crate crossedxd/rust_ga has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting crossedxd/rust_ga against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crossedxd/rust_ga:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 035587eaac853a205b2482b4bdfb2a5732cb19dc3d086c96b0c7cde01e05829c [INFO] running `"docker" "start" "-a" "035587eaac853a205b2482b4bdfb2a5732cb19dc3d086c96b0c7cde01e05829c"` [INFO] [stderr] Checking GA v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector2.rs:10:19 [INFO] [stderr] | [INFO] [stderr] 10 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector2.rs:10:25 [INFO] [stderr] | [INFO] [stderr] 10 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector2.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector2.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector2.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector2.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector2.rs:10:19 [INFO] [stderr] | [INFO] [stderr] 10 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector2.rs:10:25 [INFO] [stderr] | [INFO] [stderr] 10 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector2.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector2.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector2.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector2.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn subtract(&self, v: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn subtract(&self, v: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn add(&self, v: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn add(&self, v: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:25:19 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn equals(&self, v: &Vector2) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn equals(&self, v: &Vector2) -> bool { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn distance_to(&self, v: &Vector2) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:29:34 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn distance_to(&self, v: &Vector2) -> f64 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn distance(v1: &Vector2, v2: &Vector2) -> f64 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:36:39 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn distance(v1: &Vector2, v2: &Vector2) -> f64 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/pathfinding.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | current = *came_from.get(¤t).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&came_from[¤t]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn subtract(&self, v: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn subtract(&self, v: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn add(&self, v: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn add(&self, v: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:25:19 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn equals(&self, v: &Vector2) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn equals(&self, v: &Vector2) -> bool { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn distance_to(&self, v: &Vector2) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:29:34 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn distance_to(&self, v: &Vector2) -> f64 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn distance(v1: &Vector2, v2: &Vector2) -> f64 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:36:39 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn distance(v1: &Vector2, v2: &Vector2) -> f64 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/pathfinding.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | current = *came_from.get(¤t).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&came_from[¤t]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.65s [INFO] running `"docker" "inspect" "035587eaac853a205b2482b4bdfb2a5732cb19dc3d086c96b0c7cde01e05829c"` [INFO] running `"docker" "rm" "-f" "035587eaac853a205b2482b4bdfb2a5732cb19dc3d086c96b0c7cde01e05829c"` [INFO] [stdout] 035587eaac853a205b2482b4bdfb2a5732cb19dc3d086c96b0c7cde01e05829c