[INFO] updating cached repository crisvergara/vigenere-analyzer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/crisvergara/vigenere-analyzer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/crisvergara/vigenere-analyzer" "work/ex/clippy-test-run/sources/stable/gh/crisvergara/vigenere-analyzer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/crisvergara/vigenere-analyzer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/crisvergara/vigenere-analyzer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crisvergara/vigenere-analyzer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crisvergara/vigenere-analyzer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3068ef56feffed857ad8d2c928a1bf8192bdff07 [INFO] sha for GitHub repo crisvergara/vigenere-analyzer: 3068ef56feffed857ad8d2c928a1bf8192bdff07 [INFO] validating manifest of crisvergara/vigenere-analyzer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of crisvergara/vigenere-analyzer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing crisvergara/vigenere-analyzer [INFO] finished frobbing crisvergara/vigenere-analyzer [INFO] frobbed toml for crisvergara/vigenere-analyzer written to work/ex/clippy-test-run/sources/stable/gh/crisvergara/vigenere-analyzer/Cargo.toml [INFO] started frobbing crisvergara/vigenere-analyzer [INFO] finished frobbing crisvergara/vigenere-analyzer [INFO] frobbed toml for crisvergara/vigenere-analyzer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crisvergara/vigenere-analyzer/Cargo.toml [INFO] crate crisvergara/vigenere-analyzer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting crisvergara/vigenere-analyzer against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crisvergara/vigenere-analyzer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14c02b9461a0bf3c53fb6e63a6264a7c460ad3dbd9cd41cdd7497bed1b52c3e0 [INFO] running `"docker" "start" "-a" "14c02b9461a0bf3c53fb6e63a6264a7c460ad3dbd9cd41cdd7497bed1b52c3e0"` [INFO] [stderr] Checking vigenere-analyzer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match counts[i % keysize].entry(c) { [INFO] [stderr] 31 | | Occupied(ref mut entry) => *entry.get_mut() += 1, [INFO] [stderr] 32 | | _ => () [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ help: try this: `if let Occupied(ref mut entry) = counts[i % keysize].entry(c) { *entry.get_mut() += 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:77:37 [INFO] [stderr] | [INFO] [stderr] 77 | let base_code = alphabet_map.get(&counts[index][0].0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&alphabet_map[&counts[index][0].0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | key = key + (alphabet_chars.len() as i16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `key += (alphabet_chars.len() as i16)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:86:41 [INFO] [stderr] | [INFO] [stderr] 86 | let char_code = alphabet_map.get(&v.0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&alphabet_map[&v.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match counts[i % keysize].entry(c) { [INFO] [stderr] 31 | | Occupied(ref mut entry) => *entry.get_mut() += 1, [INFO] [stderr] 32 | | _ => () [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ help: try this: `if let Occupied(ref mut entry) = counts[i % keysize].entry(c) { *entry.get_mut() += 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:77:37 [INFO] [stderr] | [INFO] [stderr] 77 | let base_code = alphabet_map.get(&counts[index][0].0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&alphabet_map[&counts[index][0].0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | key = key + (alphabet_chars.len() as i16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `key += (alphabet_chars.len() as i16)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:86:41 [INFO] [stderr] | [INFO] [stderr] 86 | let char_code = alphabet_map.get(&v.0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&alphabet_map[&v.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.58s [INFO] running `"docker" "inspect" "14c02b9461a0bf3c53fb6e63a6264a7c460ad3dbd9cd41cdd7497bed1b52c3e0"` [INFO] running `"docker" "rm" "-f" "14c02b9461a0bf3c53fb6e63a6264a7c460ad3dbd9cd41cdd7497bed1b52c3e0"` [INFO] [stdout] 14c02b9461a0bf3c53fb6e63a6264a7c460ad3dbd9cd41cdd7497bed1b52c3e0