[INFO] updating cached repository crisvergara/letter-count [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/crisvergara/letter-count [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/crisvergara/letter-count" "work/ex/clippy-test-run/sources/stable/gh/crisvergara/letter-count"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/crisvergara/letter-count'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/crisvergara/letter-count" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crisvergara/letter-count"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crisvergara/letter-count'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e097f88dd864d02c9cc044981fa9004f971c02fd [INFO] sha for GitHub repo crisvergara/letter-count: e097f88dd864d02c9cc044981fa9004f971c02fd [INFO] validating manifest of crisvergara/letter-count on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of crisvergara/letter-count on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing crisvergara/letter-count [INFO] finished frobbing crisvergara/letter-count [INFO] frobbed toml for crisvergara/letter-count written to work/ex/clippy-test-run/sources/stable/gh/crisvergara/letter-count/Cargo.toml [INFO] started frobbing crisvergara/letter-count [INFO] finished frobbing crisvergara/letter-count [INFO] frobbed toml for crisvergara/letter-count written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crisvergara/letter-count/Cargo.toml [INFO] crate crisvergara/letter-count has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting crisvergara/letter-count against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crisvergara/letter-count:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dbf861c1dcd3b28528e45872337275f7804e6ed224951b9137caf9f85224c060 [INFO] running `"docker" "start" "-a" "dbf861c1dcd3b28528e45872337275f7804e6ed224951b9137caf9f85224c060"` [INFO] [stderr] Checking letter-count v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match counts[i % keysize].entry(c) { [INFO] [stderr] 29 | | Occupied(ref mut entry) => *entry.get_mut() += 1, [INFO] [stderr] 30 | | _ => () [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ help: try this: `if let Occupied(ref mut entry) = counts[i % keysize].entry(c) { *entry.get_mut() += 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `counts` [INFO] [stderr] --> src/main.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | for x in 0..counts.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 67 | for (x, ) in counts.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match counts[i % keysize].entry(c) { [INFO] [stderr] 29 | | Occupied(ref mut entry) => *entry.get_mut() += 1, [INFO] [stderr] 30 | | _ => () [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ help: try this: `if let Occupied(ref mut entry) = counts[i % keysize].entry(c) { *entry.get_mut() += 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `counts` [INFO] [stderr] --> src/main.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | for x in 0..counts.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 67 | for (x, ) in counts.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.82s [INFO] running `"docker" "inspect" "dbf861c1dcd3b28528e45872337275f7804e6ed224951b9137caf9f85224c060"` [INFO] running `"docker" "rm" "-f" "dbf861c1dcd3b28528e45872337275f7804e6ed224951b9137caf9f85224c060"` [INFO] [stdout] dbf861c1dcd3b28528e45872337275f7804e6ed224951b9137caf9f85224c060