[INFO] updating cached repository cristicbz/diff-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cristicbz/diff-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cristicbz/diff-rs" "work/ex/clippy-test-run/sources/stable/gh/cristicbz/diff-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cristicbz/diff-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cristicbz/diff-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cristicbz/diff-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cristicbz/diff-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 829cf6e090d491424af45bc35de7dc673b68002f
[INFO] sha for GitHub repo cristicbz/diff-rs: 829cf6e090d491424af45bc35de7dc673b68002f
[INFO] validating manifest of cristicbz/diff-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cristicbz/diff-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cristicbz/diff-rs
[INFO] finished frobbing cristicbz/diff-rs
[INFO] frobbed toml for cristicbz/diff-rs written to work/ex/clippy-test-run/sources/stable/gh/cristicbz/diff-rs/Cargo.toml
[INFO] started frobbing cristicbz/diff-rs
[INFO] finished frobbing cristicbz/diff-rs
[INFO] frobbed toml for cristicbz/diff-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cristicbz/diff-rs/Cargo.toml
[INFO] crate cristicbz/diff-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cristicbz/diff-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cristicbz/diff-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4477e91073bbe382d5b60a7ae7e720e08fcddab356817f36662938dfc0c8f27e
[INFO] running `"docker" "start" "-a" "4477e91073bbe382d5b60a7ae7e720e08fcddab356817f36662938dfc0c8f27e"`
[INFO] [stderr]     Checking ordered-float v0.4.0
[INFO] [stderr]     Checking diff v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:580:17
[INFO] [stderr]     |
[INFO] [stderr] 580 |                 id: id,
[INFO] [stderr]     |                 ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:580:17
[INFO] [stderr]     |
[INFO] [stderr] 580 |                 id: id,
[INFO] [stderr]     |                 ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: floating-point types cannot be used in patterns
[INFO] [stderr]    --> src/main.rs:202:53
[INFO] [stderr]     |
[INFO] [stderr] 202 |                     (NodeDef::Constant(OrderedFloat(0.0)), rhs_def) => {
[INFO] [stderr]     |                                                     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(illegal_floating_point_literal_pattern)] on by default
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #41620 <https://github.com/rust-lang/rust/issues/41620>
[INFO] [stderr] 
[INFO] [stderr] warning: floating-point types cannot be used in patterns
[INFO] [stderr]    --> src/main.rs:210:53
[INFO] [stderr]     |
[INFO] [stderr] 210 |                     (NodeDef::Constant(OrderedFloat(1.0)), rhs_def) if op == Binary::Mul ||
[INFO] [stderr]     |                                                     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #41620 <https://github.com/rust-lang/rust/issues/41620>
[INFO] [stderr] 
[INFO] [stderr] warning: floating-point types cannot be used in patterns
[INFO] [stderr]    --> src/main.rs:218:54
[INFO] [stderr]     |
[INFO] [stderr] 218 |                     (NodeDef::Constant(OrderedFloat(-1.0)), _) if op == Binary::Mul ||
[INFO] [stderr]     |                                                      ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #41620 <https://github.com/rust-lang/rust/issues/41620>
[INFO] [stderr] 
[INFO] [stderr] warning: floating-point types cannot be used in patterns
[INFO] [stderr]    --> src/main.rs:234:62
[INFO] [stderr]     |
[INFO] [stderr] 234 |                     (lhs_def, NodeDef::Constant(OrderedFloat(0.0))) => {
[INFO] [stderr]     |                                                              ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #41620 <https://github.com/rust-lang/rust/issues/41620>
[INFO] [stderr] 
[INFO] [stderr] warning: floating-point types cannot be used in patterns
[INFO] [stderr]    --> src/main.rs:242:62
[INFO] [stderr]     |
[INFO] [stderr] 242 |                     (lhs_def, NodeDef::Constant(OrderedFloat(1.0))) if op == Binary::Mul ||
[INFO] [stderr]     |                                                              ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #41620 <https://github.com/rust-lang/rust/issues/41620>
[INFO] [stderr] 
[INFO] [stderr] warning: floating-point types cannot be used in patterns
[INFO] [stderr]    --> src/main.rs:245:57
[INFO] [stderr]     |
[INFO] [stderr] 245 |                     (_, NodeDef::Constant(OrderedFloat(-1.0))) if op == Binary::Mul ||
[INFO] [stderr]     |                                                         ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #41620 <https://github.com/rust-lang/rust/issues/41620>
[INFO] [stderr] 
[INFO] [stderr] warning: floating-point types cannot be used in patterns
[INFO] [stderr]    --> src/main.rs:202:53
[INFO] [stderr]     |
[INFO] [stderr] 202 |                     (NodeDef::Constant(OrderedFloat(0.0)), rhs_def) => {
[INFO] [stderr]     |                                                     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #41620 <https://github.com/rust-lang/rust/issues/41620>
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 29
[INFO] [stderr]    --> src/main.rs:92:5
[INFO] [stderr]     |
[INFO] [stderr] 92  | /     fn simplify(&self, def: NodeDef) -> NodeDef {
[INFO] [stderr] 93  | |         match def {
[INFO] [stderr] 94  | |             NodeDef::Unary(op, of) => {
[INFO] [stderr] 95  | |                 match self.node_by_id(of) {
[INFO] [stderr] ...   |
[INFO] [stderr] 296 | |         }
[INFO] [stderr] 297 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: floating-point types cannot be used in patterns
[INFO] [stderr]    --> src/main.rs:202:53
[INFO] [stderr]     |
[INFO] [stderr] 202 |                     (NodeDef::Constant(OrderedFloat(0.0)), rhs_def) => {
[INFO] [stderr]     |                                                     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(illegal_floating_point_literal_pattern)] on by default
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #41620 <https://github.com/rust-lang/rust/issues/41620>
[INFO] [stderr] 
[INFO] [stderr] warning: floating-point types cannot be used in patterns
[INFO] [stderr]    --> src/main.rs:210:53
[INFO] [stderr]     |
[INFO] [stderr] 210 |                     (NodeDef::Constant(OrderedFloat(1.0)), rhs_def) if op == Binary::Mul ||
[INFO] [stderr]     |                                                     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #41620 <https://github.com/rust-lang/rust/issues/41620>
[INFO] [stderr] 
[INFO] [stderr] warning: floating-point types cannot be used in patterns
[INFO] [stderr]    --> src/main.rs:218:54
[INFO] [stderr]     |
[INFO] [stderr] 218 |                     (NodeDef::Constant(OrderedFloat(-1.0)), _) if op == Binary::Mul ||
[INFO] [stderr]     |                                                      ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #41620 <https://github.com/rust-lang/rust/issues/41620>
[INFO] [stderr] 
[INFO] [stderr] warning: floating-point types cannot be used in patterns
[INFO] [stderr]    --> src/main.rs:234:62
[INFO] [stderr]     |
[INFO] [stderr] 234 |                     (lhs_def, NodeDef::Constant(OrderedFloat(0.0))) => {
[INFO] [stderr]     |                                                              ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #41620 <https://github.com/rust-lang/rust/issues/41620>
[INFO] [stderr] 
[INFO] [stderr] warning: floating-point types cannot be used in patterns
[INFO] [stderr]    --> src/main.rs:242:62
[INFO] [stderr]     |
[INFO] [stderr] 242 |                     (lhs_def, NodeDef::Constant(OrderedFloat(1.0))) if op == Binary::Mul ||
[INFO] [stderr]     |                                                              ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #41620 <https://github.com/rust-lang/rust/issues/41620>
[INFO] [stderr] 
[INFO] [stderr] warning: floating-point types cannot be used in patterns
[INFO] [stderr]    --> src/main.rs:245:57
[INFO] [stderr]     |
[INFO] [stderr] 245 |                     (_, NodeDef::Constant(OrderedFloat(-1.0))) if op == Binary::Mul ||
[INFO] [stderr]     |                                                         ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #41620 <https://github.com/rust-lang/rust/issues/41620>
[INFO] [stderr] 
[INFO] [stderr] warning: floating-point types cannot be used in patterns
[INFO] [stderr]    --> src/main.rs:202:53
[INFO] [stderr]     |
[INFO] [stderr] 202 |                     (NodeDef::Constant(OrderedFloat(0.0)), rhs_def) => {
[INFO] [stderr]     |                                                     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]     = note: for more information, see issue #41620 <https://github.com/rust-lang/rust/issues/41620>
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 29
[INFO] [stderr]    --> src/main.rs:92:5
[INFO] [stderr]     |
[INFO] [stderr] 92  | /     fn simplify(&self, def: NodeDef) -> NodeDef {
[INFO] [stderr] 93  | |         match def {
[INFO] [stderr] 94  | |             NodeDef::Unary(op, of) => {
[INFO] [stderr] 95  | |                 match self.node_by_id(of) {
[INFO] [stderr] ...   |
[INFO] [stderr] 296 | |         }
[INFO] [stderr] 297 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.92s
[INFO] running `"docker" "inspect" "4477e91073bbe382d5b60a7ae7e720e08fcddab356817f36662938dfc0c8f27e"`
[INFO] running `"docker" "rm" "-f" "4477e91073bbe382d5b60a7ae7e720e08fcddab356817f36662938dfc0c8f27e"`
[INFO] [stdout] 4477e91073bbe382d5b60a7ae7e720e08fcddab356817f36662938dfc0c8f27e