[INFO] updating cached repository cptchuckles/russian-flash-cards
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cptchuckles/russian-flash-cards
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cptchuckles/russian-flash-cards" "work/ex/clippy-test-run/sources/stable/gh/cptchuckles/russian-flash-cards"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cptchuckles/russian-flash-cards'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cptchuckles/russian-flash-cards" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cptchuckles/russian-flash-cards"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cptchuckles/russian-flash-cards'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 52a945d6f070d85d725c66de44f64245d897205d
[INFO] sha for GitHub repo cptchuckles/russian-flash-cards: 52a945d6f070d85d725c66de44f64245d897205d
[INFO] validating manifest of cptchuckles/russian-flash-cards on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cptchuckles/russian-flash-cards on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cptchuckles/russian-flash-cards
[INFO] finished frobbing cptchuckles/russian-flash-cards
[INFO] frobbed toml for cptchuckles/russian-flash-cards written to work/ex/clippy-test-run/sources/stable/gh/cptchuckles/russian-flash-cards/Cargo.toml
[INFO] started frobbing cptchuckles/russian-flash-cards
[INFO] finished frobbing cptchuckles/russian-flash-cards
[INFO] frobbed toml for cptchuckles/russian-flash-cards written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cptchuckles/russian-flash-cards/Cargo.toml
[INFO] crate cptchuckles/russian-flash-cards has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cptchuckles/russian-flash-cards against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cptchuckles/russian-flash-cards:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d7ef9195ca0397f4bca679ac64476b46e6d70f976a08635199a484930ba01aa1
[INFO] running `"docker" "start" "-a" "d7ef9195ca0397f4bca679ac64476b46e6d70f976a08635199a484930ba01aa1"`
[INFO] [stderr]     Checking Russian v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/flashcard.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |         d
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/flashcard.rs:22:17
[INFO] [stderr]    |
[INFO] [stderr] 22 |           let d = match load_deck_from_file(file) {
[INFO] [stderr]    |  _________________^
[INFO] [stderr] 23 | |             Ok(deck) => Some(deck),
[INFO] [stderr] 24 | |             Err(s) => {
[INFO] [stderr] 25 | |                 println!("Deck::new_from_file() failed:\n   {}", s);
[INFO] [stderr] 26 | |                 None
[INFO] [stderr] 27 | |             },
[INFO] [stderr] 28 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `rand::prelude::*`
[INFO] [stderr]  --> src/main.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | use rand::prelude::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/flashcard.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |         d
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/flashcard.rs:22:17
[INFO] [stderr]    |
[INFO] [stderr] 22 |           let d = match load_deck_from_file(file) {
[INFO] [stderr]    |  _________________^
[INFO] [stderr] 23 | |             Ok(deck) => Some(deck),
[INFO] [stderr] 24 | |             Err(s) => {
[INFO] [stderr] 25 | |                 println!("Deck::new_from_file() failed:\n   {}", s);
[INFO] [stderr] 26 | |                 None
[INFO] [stderr] 27 | |             },
[INFO] [stderr] 28 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `rand::prelude::*`
[INFO] [stderr]  --> src/main.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | use rand::prelude::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: crate `Russian` should have a snake case name such as `russian`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: crate `Russian` should have a snake case name such as `russian`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/flashcard.rs:75:36
[INFO] [stderr]    |
[INFO] [stderr] 75 |             _ => deck.content.push(line.into()),
[INFO] [stderr]    |                                    ^^^^^^^^^^^ help: consider removing `.into()`: `line`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: avoid using `collect()` when not needed
[INFO] [stderr]   --> src/flashcard.rs:81:32
[INFO] [stderr]    |
[INFO] [stderr] 81 |         let cols = s.split(':').collect::<Vec<&str>>().len() as u8;
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_collect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/flashcard.rs:75:36
[INFO] [stderr]    |
[INFO] [stderr] 75 |             _ => deck.content.push(line.into()),
[INFO] [stderr]    |                                    ^^^^^^^^^^^ help: consider removing `.into()`: `line`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: avoid using `collect()` when not needed
[INFO] [stderr]   --> src/flashcard.rs:81:32
[INFO] [stderr]    |
[INFO] [stderr] 81 |         let cols = s.split(':').collect::<Vec<&str>>().len() as u8;
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_collect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.47s
[INFO] running `"docker" "inspect" "d7ef9195ca0397f4bca679ac64476b46e6d70f976a08635199a484930ba01aa1"`
[INFO] running `"docker" "rm" "-f" "d7ef9195ca0397f4bca679ac64476b46e6d70f976a08635199a484930ba01aa1"`
[INFO] [stdout] d7ef9195ca0397f4bca679ac64476b46e6d70f976a08635199a484930ba01aa1