[INFO] updating cached repository cpetruta/simple-editor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cpetruta/simple-editor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cpetruta/simple-editor" "work/ex/clippy-test-run/sources/stable/gh/cpetruta/simple-editor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cpetruta/simple-editor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cpetruta/simple-editor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cpetruta/simple-editor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cpetruta/simple-editor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7ea602fcea8a3743f874f6f9d5e3252e79a47411 [INFO] sha for GitHub repo cpetruta/simple-editor: 7ea602fcea8a3743f874f6f9d5e3252e79a47411 [INFO] validating manifest of cpetruta/simple-editor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cpetruta/simple-editor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cpetruta/simple-editor [INFO] finished frobbing cpetruta/simple-editor [INFO] frobbed toml for cpetruta/simple-editor written to work/ex/clippy-test-run/sources/stable/gh/cpetruta/simple-editor/Cargo.toml [INFO] started frobbing cpetruta/simple-editor [INFO] finished frobbing cpetruta/simple-editor [INFO] frobbed toml for cpetruta/simple-editor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cpetruta/simple-editor/Cargo.toml [INFO] crate cpetruta/simple-editor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cpetruta/simple-editor against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cpetruta/simple-editor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cf7f895e1af70de327fb137f2cb286dd003296a4911b9c348dc8883deadd91e0 [INFO] running `"docker" "start" "-a" "cf7f895e1af70de327fb137f2cb286dd003296a4911b9c348dc8883deadd91e0"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking kilo_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | stdin: stdin, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stdin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:199:47 [INFO] [stderr] | [INFO] [stderr] 199 | write!(self.stdout, "{}", "\r\n").unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | stdin: stdin, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stdin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:199:47 [INFO] [stderr] | [INFO] [stderr] 199 | write!(self.stdout, "{}", "\r\n").unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | const RKILO_VERSION: &'static str = "0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:137:14 [INFO] [stderr] | [INFO] [stderr] 137 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 138 | | if self.rows_offset >= 1 { [INFO] [stderr] 139 | | self.rows_offset -= 1; [INFO] [stderr] 140 | | let line_len = self.current_line_size(); [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 137 | else if self.rows_offset >= 1 { [INFO] [stderr] 138 | self.rows_offset -= 1; [INFO] [stderr] 139 | let line_len = self.current_line_size(); [INFO] [stderr] 140 | if line_len < self.cx { [INFO] [stderr] 141 | self.cx = line_len; [INFO] [stderr] 142 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:156:14 [INFO] [stderr] | [INFO] [stderr] 156 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 157 | | if self.rows_offset + self.cy < self.file_rows() { [INFO] [stderr] 158 | | self.rows_offset += 1; [INFO] [stderr] 159 | | let line_len = self.current_line_size(); [INFO] [stderr] ... | [INFO] [stderr] 163 | | } [INFO] [stderr] 164 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 156 | else if self.rows_offset + self.cy < self.file_rows() { [INFO] [stderr] 157 | self.rows_offset += 1; [INFO] [stderr] 158 | let line_len = self.current_line_size(); [INFO] [stderr] 159 | if line_len < self.cx { [INFO] [stderr] 160 | self.cx = line_len + 1; [INFO] [stderr] 161 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | const RKILO_VERSION: &'static str = "0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:137:14 [INFO] [stderr] | [INFO] [stderr] 137 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 138 | | if self.rows_offset >= 1 { [INFO] [stderr] 139 | | self.rows_offset -= 1; [INFO] [stderr] 140 | | let line_len = self.current_line_size(); [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 137 | else if self.rows_offset >= 1 { [INFO] [stderr] 138 | self.rows_offset -= 1; [INFO] [stderr] 139 | let line_len = self.current_line_size(); [INFO] [stderr] 140 | if line_len < self.cx { [INFO] [stderr] 141 | self.cx = line_len; [INFO] [stderr] 142 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:156:14 [INFO] [stderr] | [INFO] [stderr] 156 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 157 | | if self.rows_offset + self.cy < self.file_rows() { [INFO] [stderr] 158 | | self.rows_offset += 1; [INFO] [stderr] 159 | | let line_len = self.current_line_size(); [INFO] [stderr] ... | [INFO] [stderr] 163 | | } [INFO] [stderr] 164 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 156 | else if self.rows_offset + self.cy < self.file_rows() { [INFO] [stderr] 157 | self.rows_offset += 1; [INFO] [stderr] 158 | let line_len = self.current_line_size(); [INFO] [stderr] 159 | if line_len < self.cx { [INFO] [stderr] 160 | self.cx = line_len + 1; [INFO] [stderr] 161 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: field is never used: `stdin` [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | stdin: R, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `stdin` [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | stdin: R, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.71s [INFO] running `"docker" "inspect" "cf7f895e1af70de327fb137f2cb286dd003296a4911b9c348dc8883deadd91e0"` [INFO] running `"docker" "rm" "-f" "cf7f895e1af70de327fb137f2cb286dd003296a4911b9c348dc8883deadd91e0"` [INFO] [stdout] cf7f895e1af70de327fb137f2cb286dd003296a4911b9c348dc8883deadd91e0