[INFO] updating cached repository cowang4/rusty_primes [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cowang4/rusty_primes [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cowang4/rusty_primes" "work/ex/clippy-test-run/sources/stable/gh/cowang4/rusty_primes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cowang4/rusty_primes'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cowang4/rusty_primes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cowang4/rusty_primes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cowang4/rusty_primes'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 46fb5675b79a855986e1a69094d78689c1557b62 [INFO] sha for GitHub repo cowang4/rusty_primes: 46fb5675b79a855986e1a69094d78689c1557b62 [INFO] validating manifest of cowang4/rusty_primes on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cowang4/rusty_primes on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cowang4/rusty_primes [INFO] finished frobbing cowang4/rusty_primes [INFO] frobbed toml for cowang4/rusty_primes written to work/ex/clippy-test-run/sources/stable/gh/cowang4/rusty_primes/Cargo.toml [INFO] started frobbing cowang4/rusty_primes [INFO] finished frobbing cowang4/rusty_primes [INFO] frobbed toml for cowang4/rusty_primes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cowang4/rusty_primes/Cargo.toml [INFO] crate cowang4/rusty_primes has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cowang4/rusty_primes against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cowang4/rusty_primes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 805c4e504ee49cb6d960acab414e272f2bf0dd20d214f56ba4eb93da166fc47c [INFO] running `"docker" "start" "-a" "805c4e504ee49cb6d960acab414e272f2bf0dd20d214f56ba4eb93da166fc47c"` [INFO] [stderr] Checking rusty_primes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `i` is used to index `primes` [INFO] [stderr] --> src/main.rs:9:14 [INFO] [stderr] | [INFO] [stderr] 9 | for i in 2usize..n { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 9 | for (i, ) in primes.iter().enumerate().take(n).skip(2usize) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:11:12 [INFO] [stderr] | [INFO] [stderr] 11 | if prime == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!prime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / ((i*i)..n) [INFO] [stderr] 15 | | .step_by(i) [INFO] [stderr] 16 | | .map(|i| primes[i] = false) [INFO] [stderr] 17 | | .collect::<()>(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / ((i*i)..n) [INFO] [stderr] 15 | | .step_by(i) [INFO] [stderr] 16 | | .map(|i| primes[i] = false) [INFO] [stderr] 17 | | .collect::<()>(); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / primes [INFO] [stderr] 31 | | .iter() [INFO] [stderr] 32 | | .map(|i| println!("{}", i)) [INFO] [stderr] 33 | | .collect::<()>(); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / primes [INFO] [stderr] 31 | | .iter() [INFO] [stderr] 32 | | .map(|i| println!("{}", i)) [INFO] [stderr] 33 | | .collect::<()>(); [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `primes` [INFO] [stderr] --> src/main.rs:9:14 [INFO] [stderr] | [INFO] [stderr] 9 | for i in 2usize..n { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 9 | for (i, ) in primes.iter().enumerate().take(n).skip(2usize) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:11:12 [INFO] [stderr] | [INFO] [stderr] 11 | if prime == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!prime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / ((i*i)..n) [INFO] [stderr] 15 | | .step_by(i) [INFO] [stderr] 16 | | .map(|i| primes[i] = false) [INFO] [stderr] 17 | | .collect::<()>(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / ((i*i)..n) [INFO] [stderr] 15 | | .step_by(i) [INFO] [stderr] 16 | | .map(|i| primes[i] = false) [INFO] [stderr] 17 | | .collect::<()>(); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / primes [INFO] [stderr] 31 | | .iter() [INFO] [stderr] 32 | | .map(|i| println!("{}", i)) [INFO] [stderr] 33 | | .collect::<()>(); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / primes [INFO] [stderr] 31 | | .iter() [INFO] [stderr] 32 | | .map(|i| println!("{}", i)) [INFO] [stderr] 33 | | .collect::<()>(); [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.30s [INFO] running `"docker" "inspect" "805c4e504ee49cb6d960acab414e272f2bf0dd20d214f56ba4eb93da166fc47c"` [INFO] running `"docker" "rm" "-f" "805c4e504ee49cb6d960acab414e272f2bf0dd20d214f56ba4eb93da166fc47c"` [INFO] [stdout] 805c4e504ee49cb6d960acab414e272f2bf0dd20d214f56ba4eb93da166fc47c