[INFO] updating cached repository corndog/pe1_10 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/corndog/pe1_10 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/corndog/pe1_10" "work/ex/clippy-test-run/sources/stable/gh/corndog/pe1_10"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/corndog/pe1_10'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/corndog/pe1_10" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/corndog/pe1_10"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/corndog/pe1_10'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9581240561301818265e516bcef790f69920ebd6 [INFO] sha for GitHub repo corndog/pe1_10: 9581240561301818265e516bcef790f69920ebd6 [INFO] validating manifest of corndog/pe1_10 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of corndog/pe1_10 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing corndog/pe1_10 [INFO] finished frobbing corndog/pe1_10 [INFO] frobbed toml for corndog/pe1_10 written to work/ex/clippy-test-run/sources/stable/gh/corndog/pe1_10/Cargo.toml [INFO] started frobbing corndog/pe1_10 [INFO] finished frobbing corndog/pe1_10 [INFO] frobbed toml for corndog/pe1_10 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/corndog/pe1_10/Cargo.toml [INFO] crate corndog/pe1_10 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting corndog/pe1_10 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/corndog/pe1_10:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d87b49eb6dff2095d5e1b977c6e22b51b207e09df3e0f6bc80225a429b722ae0 [INFO] running `"docker" "start" "-a" "d87b49eb6dff2095d5e1b977c6e22b51b207e09df3e0f6bc80225a429b722ae0"` [INFO] [stderr] Checking pe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:2:20 [INFO] [stderr] | [INFO] [stderr] 2 | assert_eq!(pe1(), 233168); [INFO] [stderr] | ^^^^^^ help: consider: `233_168` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | assert_eq!(pe2(4000000), 4613732); [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:3:27 [INFO] [stderr] | [INFO] [stderr] 3 | assert_eq!(pe2(4000000), 4613732); [INFO] [stderr] | ^^^^^^^ help: consider: `4_613_732` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:5:20 [INFO] [stderr] | [INFO] [stderr] 5 | assert_eq!(pe4(), 906609); [INFO] [stderr] | ^^^^^^ help: consider: `906_609` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:6:20 [INFO] [stderr] | [INFO] [stderr] 6 | assert_eq!(pe5(), 232792560); [INFO] [stderr] | ^^^^^^^^^ help: consider: `232_792_560` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | assert_eq!(pe6(), 25164150); [INFO] [stderr] | ^^^^^^^^ help: consider: `25_164_150` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:8:20 [INFO] [stderr] | [INFO] [stderr] 8 | assert_eq!(pe7(), 104743); [INFO] [stderr] | ^^^^^^ help: consider: `104_743` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | assert_eq!(pe8(), 23514624000); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `23_514_624_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | assert_eq!(pe9(), 31875000); [INFO] [stderr] | ^^^^^^^^ help: consider: `31_875_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:11:21 [INFO] [stderr] | [INFO] [stderr] 11 | assert_eq!(pe10(), 142913828922); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `142_913_828_922` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | let mut divide_me:u64 = 600851475143; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:209:15 [INFO] [stderr] | [INFO] [stderr] 209 | primes_below(2000000).iter().sum() [INFO] [stderr] | ^^^^^^^ help: consider: `2_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:2:20 [INFO] [stderr] | [INFO] [stderr] 2 | assert_eq!(pe1(), 233168); [INFO] [stderr] | ^^^^^^ help: consider: `233_168` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | assert_eq!(pe2(4000000), 4613732); [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:3:27 [INFO] [stderr] | [INFO] [stderr] 3 | assert_eq!(pe2(4000000), 4613732); [INFO] [stderr] | ^^^^^^^ help: consider: `4_613_732` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:5:20 [INFO] [stderr] | [INFO] [stderr] 5 | assert_eq!(pe4(), 906609); [INFO] [stderr] | ^^^^^^ help: consider: `906_609` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:6:20 [INFO] [stderr] | [INFO] [stderr] 6 | assert_eq!(pe5(), 232792560); [INFO] [stderr] | ^^^^^^^^^ help: consider: `232_792_560` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | assert_eq!(pe6(), 25164150); [INFO] [stderr] | ^^^^^^^^ help: consider: `25_164_150` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:8:20 [INFO] [stderr] | [INFO] [stderr] 8 | assert_eq!(pe7(), 104743); [INFO] [stderr] | ^^^^^^ help: consider: `104_743` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | assert_eq!(pe8(), 23514624000); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `23_514_624_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | assert_eq!(pe9(), 31875000); [INFO] [stderr] | ^^^^^^^^ help: consider: `31_875_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:11:21 [INFO] [stderr] | [INFO] [stderr] 11 | assert_eq!(pe10(), 142913828922); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `142_913_828_922` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | let mut divide_me:u64 = 600851475143; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:209:15 [INFO] [stderr] | [INFO] [stderr] 209 | primes_below(2000000).iter().sum() [INFO] [stderr] | ^^^^^^^ help: consider: `2_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:49:4 [INFO] [stderr] | [INFO] [stderr] 49 | divide_me = divide_me / next_prime; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `divide_me /= next_prime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | fn has_divisor(x: u64, xs: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:99:33 [INFO] [stderr] | [INFO] [stderr] 99 | fn divisible_by_all(x: u64, xs: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | prod = prod / nums[i] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prod /= nums[i] as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:19 [INFO] [stderr] | [INFO] [stderr] 177 | prod = prod / nums[i] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(nums[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:181:4 [INFO] [stderr] | [INFO] [stderr] 181 | prod = prod * next as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prod *= next as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:181:18 [INFO] [stderr] | [INFO] [stderr] 181 | prod = prod * next as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(next)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:49:4 [INFO] [stderr] | [INFO] [stderr] 49 | divide_me = divide_me / next_prime; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `divide_me /= next_prime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | fn has_divisor(x: u64, xs: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:99:33 [INFO] [stderr] | [INFO] [stderr] 99 | fn divisible_by_all(x: u64, xs: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | prod = prod / nums[i] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prod /= nums[i] as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:19 [INFO] [stderr] | [INFO] [stderr] 177 | prod = prod / nums[i] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(nums[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:181:4 [INFO] [stderr] | [INFO] [stderr] 181 | prod = prod * next as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prod *= next as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:181:18 [INFO] [stderr] | [INFO] [stderr] 181 | prod = prod * next as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(next)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.17s [INFO] running `"docker" "inspect" "d87b49eb6dff2095d5e1b977c6e22b51b207e09df3e0f6bc80225a429b722ae0"` [INFO] running `"docker" "rm" "-f" "d87b49eb6dff2095d5e1b977c6e22b51b207e09df3e0f6bc80225a429b722ae0"` [INFO] [stdout] d87b49eb6dff2095d5e1b977c6e22b51b207e09df3e0f6bc80225a429b722ae0