[INFO] updating cached repository corndog/pe11_20 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/corndog/pe11_20 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/corndog/pe11_20" "work/ex/clippy-test-run/sources/stable/gh/corndog/pe11_20"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/corndog/pe11_20'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/corndog/pe11_20" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/corndog/pe11_20"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/corndog/pe11_20'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4171255bdb0b927a544c9c82eb0b0a9db5e509d2 [INFO] sha for GitHub repo corndog/pe11_20: 4171255bdb0b927a544c9c82eb0b0a9db5e509d2 [INFO] validating manifest of corndog/pe11_20 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of corndog/pe11_20 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing corndog/pe11_20 [INFO] finished frobbing corndog/pe11_20 [INFO] frobbed toml for corndog/pe11_20 written to work/ex/clippy-test-run/sources/stable/gh/corndog/pe11_20/Cargo.toml [INFO] started frobbing corndog/pe11_20 [INFO] finished frobbing corndog/pe11_20 [INFO] frobbed toml for corndog/pe11_20 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/corndog/pe11_20/Cargo.toml [INFO] crate corndog/pe11_20 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting corndog/pe11_20 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/corndog/pe11_20:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3355c84961e90bc030a8399a91639d660010086a799f7368f236684ea9540278 [INFO] running `"docker" "start" "-a" "3355c84961e90bc030a8399a91639d660010086a799f7368f236684ea9540278"` [INFO] [stderr] Checking num-rational v0.1.39 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking stopwatch v0.0.7 [INFO] [stderr] Checking pe2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | assert_eq!(pe11(), 70600674); [INFO] [stderr] | ^^^^^^^^ help: consider: `70_600_674` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:18:24 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(pe12(), 76576500); [INFO] [stderr] | ^^^^^^^^ help: consider: `76_576_500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(pe14(), 837799); [INFO] [stderr] | ^^^^^^ help: consider: `837_799` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | assert_eq!(pe15(), 137846528820); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `137_846_528_820` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:280:17 [INFO] [stderr] | [INFO] [stderr] 280 | for i in 2..1000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | ans [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:360:15 [INFO] [stderr] | [INFO] [stderr] 360 | let ans = find_max(triangle); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | assert_eq!(pe11(), 70600674); [INFO] [stderr] | ^^^^^^^^ help: consider: `70_600_674` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:18:24 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(pe12(), 76576500); [INFO] [stderr] | ^^^^^^^^ help: consider: `76_576_500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(pe14(), 837799); [INFO] [stderr] | ^^^^^^ help: consider: `837_799` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | assert_eq!(pe15(), 137846528820); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `137_846_528_820` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:280:17 [INFO] [stderr] | [INFO] [stderr] 280 | for i in 2..1000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | ans [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:360:15 [INFO] [stderr] | [INFO] [stderr] 360 | let ans = find_max(triangle); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sw` [INFO] [stderr] --> src/main.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | let sw = Stopwatch::start_new(); [INFO] [stderr] | ^^ help: consider using `_sw` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sw` [INFO] [stderr] --> src/main.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | let sw = Stopwatch::start_new(); [INFO] [stderr] | ^^ help: consider using `_sw` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `grid` [INFO] [stderr] --> src/main.rs:61:14 [INFO] [stderr] | [INFO] [stderr] 61 | for i in 0..20 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 61 | for (i, ) in grid.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | for i in 0..20 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 69 | for in &grid { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | for k in j..j+4 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 82 | for in grid.iter().skip(j).take(4) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:266:21 [INFO] [stderr] | [INFO] [stderr] 266 | input.split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:376:22 [INFO] [stderr] | [INFO] [stderr] 376 | fn reduce_levels(r1: &Vec, r2: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:376:37 [INFO] [stderr] | [INFO] [stderr] 376 | fn reduce_levels(r1: &Vec, r2: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `month` is used to index `dims` [INFO] [stderr] --> src/main.rs:402:22 [INFO] [stderr] | [INFO] [stderr] 402 | for month in 0..12 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 402 | for (month, ) in dims.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `grid` [INFO] [stderr] --> src/main.rs:61:14 [INFO] [stderr] | [INFO] [stderr] 61 | for i in 0..20 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 61 | for (i, ) in grid.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | for i in 0..20 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 69 | for in &grid { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | for k in j..j+4 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 82 | for in grid.iter().skip(j).take(4) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:266:21 [INFO] [stderr] | [INFO] [stderr] 266 | input.split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:376:22 [INFO] [stderr] | [INFO] [stderr] 376 | fn reduce_levels(r1: &Vec, r2: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:376:37 [INFO] [stderr] | [INFO] [stderr] 376 | fn reduce_levels(r1: &Vec, r2: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `month` is used to index `dims` [INFO] [stderr] --> src/main.rs:402:22 [INFO] [stderr] | [INFO] [stderr] 402 | for month in 0..12 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 402 | for (month, ) in dims.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.84s [INFO] running `"docker" "inspect" "3355c84961e90bc030a8399a91639d660010086a799f7368f236684ea9540278"` [INFO] running `"docker" "rm" "-f" "3355c84961e90bc030a8399a91639d660010086a799f7368f236684ea9540278"` [INFO] [stdout] 3355c84961e90bc030a8399a91639d660010086a799f7368f236684ea9540278