[INFO] updating cached repository corbmr/tile-puzzle [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/corbmr/tile-puzzle [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/corbmr/tile-puzzle" "work/ex/clippy-test-run/sources/stable/gh/corbmr/tile-puzzle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/corbmr/tile-puzzle'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/corbmr/tile-puzzle" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/corbmr/tile-puzzle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/corbmr/tile-puzzle'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bebd9a7b8cc07b08318f1af4142b11141eeef7d1 [INFO] sha for GitHub repo corbmr/tile-puzzle: bebd9a7b8cc07b08318f1af4142b11141eeef7d1 [INFO] validating manifest of corbmr/tile-puzzle on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of corbmr/tile-puzzle on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing corbmr/tile-puzzle [INFO] finished frobbing corbmr/tile-puzzle [INFO] frobbed toml for corbmr/tile-puzzle written to work/ex/clippy-test-run/sources/stable/gh/corbmr/tile-puzzle/Cargo.toml [INFO] started frobbing corbmr/tile-puzzle [INFO] finished frobbing corbmr/tile-puzzle [INFO] frobbed toml for corbmr/tile-puzzle written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/corbmr/tile-puzzle/Cargo.toml [INFO] crate corbmr/tile-puzzle has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting corbmr/tile-puzzle against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/corbmr/tile-puzzle:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6c43cfde5fc6597d57fc3caf6507eb307d3c0ce4d2a48333ac5e59aa6d77a9de [INFO] running `"docker" "start" "-a" "6c43cfde5fc6597d57fc3caf6507eb307d3c0ce4d2a48333ac5e59aa6d77a9de"` [INFO] [stderr] Checking state-search v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/tile.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | let m = if mt > mi { mt - mi } else { mi - mt }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/tile.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | let m = if mt > mi { mt - mi } else { mi - mt }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tile.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | if bs == 0b11111111 { // all tiles are present [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tile.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | if bs == 0b11111111 { // all tiles are present [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tile.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | let t = t as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tile.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | let t = t as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tile.rs:224:22 [INFO] [stderr] | [INFO] [stderr] 224 | let mut up = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tile.rs:229:24 [INFO] [stderr] | [INFO] [stderr] 229 | let mut down = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tile.rs:234:24 [INFO] [stderr] | [INFO] [stderr] 234 | let mut left = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tile.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | let mut right = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/cube.rs:69:23 [INFO] [stderr] | [INFO] [stderr] 69 | #[derive(Clone, Copy, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tile.rs:224:22 [INFO] [stderr] | [INFO] [stderr] 224 | let mut up = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/cube.rs:180:1 [INFO] [stderr] | [INFO] [stderr] 180| / impl PartialEq for GameState { [INFO] [stderr] 181| | fn eq(&self, other: &Self) -> bool { [INFO] [stderr] 182| | for &p in &ORIENTATIONS { [INFO] [stderr] 183| | let g = self.permute(p); [INFO] [stderr] ... | [INFO] [stderr] 189| | } [INFO] [stderr] 190| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tile.rs:229:24 [INFO] [stderr] | [INFO] [stderr] 229 | let mut down = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tile.rs:234:24 [INFO] [stderr] | [INFO] [stderr] 234 | let mut left = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tile.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | let mut right = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/cube.rs:69:23 [INFO] [stderr] | [INFO] [stderr] 69 | #[derive(Clone, Copy, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/cube.rs:180:1 [INFO] [stderr] | [INFO] [stderr] 180| / impl PartialEq for GameState { [INFO] [stderr] 181| | fn eq(&self, other: &Self) -> bool { [INFO] [stderr] 182| | for &p in &ORIENTATIONS { [INFO] [stderr] 183| | let g = self.permute(p); [INFO] [stderr] ... | [INFO] [stderr] 189| | } [INFO] [stderr] 190| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] error: Could not compile `state-search`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] [INFO] [stderr] error: Could not compile `state-search`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6c43cfde5fc6597d57fc3caf6507eb307d3c0ce4d2a48333ac5e59aa6d77a9de"` [INFO] running `"docker" "rm" "-f" "6c43cfde5fc6597d57fc3caf6507eb307d3c0ce4d2a48333ac5e59aa6d77a9de"` [INFO] [stdout] 6c43cfde5fc6597d57fc3caf6507eb307d3c0ce4d2a48333ac5e59aa6d77a9de