[INFO] updating cached repository colinkingswood/rust_experiment [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/colinkingswood/rust_experiment [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/colinkingswood/rust_experiment" "work/ex/clippy-test-run/sources/stable/gh/colinkingswood/rust_experiment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/colinkingswood/rust_experiment'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/colinkingswood/rust_experiment" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/colinkingswood/rust_experiment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/colinkingswood/rust_experiment'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 57ef0f51ffe5d94f845e576c04017becdc0acf23 [INFO] sha for GitHub repo colinkingswood/rust_experiment: 57ef0f51ffe5d94f845e576c04017becdc0acf23 [INFO] validating manifest of colinkingswood/rust_experiment on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of colinkingswood/rust_experiment on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing colinkingswood/rust_experiment [INFO] finished frobbing colinkingswood/rust_experiment [INFO] frobbed toml for colinkingswood/rust_experiment written to work/ex/clippy-test-run/sources/stable/gh/colinkingswood/rust_experiment/Cargo.toml [INFO] started frobbing colinkingswood/rust_experiment [INFO] finished frobbing colinkingswood/rust_experiment [INFO] frobbed toml for colinkingswood/rust_experiment written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/colinkingswood/rust_experiment/Cargo.toml [INFO] crate colinkingswood/rust_experiment has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting colinkingswood/rust_experiment against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/colinkingswood/rust_experiment:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c6fe8396816a009987bb10277e335e01294209db709bc0866ebd693573376c6e [INFO] running `"docker" "start" "-a" "c6fe8396816a009987bb10277e335e01294209db709bc0866ebd693573376c6e"` [INFO] [stderr] Checking mulitplex_1 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return binvec [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `binvec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | return combined; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `combined` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | return next_list [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `next_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | return blah.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `blah.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | return wrapped; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `wrapped` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return binvec [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `binvec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | return combined; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `combined` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | return next_list [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `next_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | return blah.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `blah.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | return wrapped; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `wrapped` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `current_list` [INFO] [stderr] --> src/main.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | fn test(current_list:&[(u8,u8)])->usize{ [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_current_list` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `current_list` [INFO] [stderr] --> src/main.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | fn test(current_list:&[(u8,u8)])->usize{ [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_current_list` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_matrix` [INFO] [stderr] --> src/main.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | fn print_matrix(matrix:Vec>){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_next_list` [INFO] [stderr] --> src/main.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135 | fn get_next_list(current_list:&Vec>)->Vec<(u8,u8)>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test` [INFO] [stderr] --> src/main.rs:149:1 [INFO] [stderr] | [INFO] [stderr] 149 | fn test(current_list:&[(u8,u8)])->usize{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_matrix` [INFO] [stderr] --> src/main.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | fn print_matrix(matrix:Vec>){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_next_list` [INFO] [stderr] --> src/main.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135 | fn get_next_list(current_list:&Vec>)->Vec<(u8,u8)>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test` [INFO] [stderr] --> src/main.rs:149:1 [INFO] [stderr] | [INFO] [stderr] 149 | fn test(current_list:&[(u8,u8)])->usize{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:96:16 [INFO] [stderr] | [INFO] [stderr] 96 | if can_combine == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `can_combine` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:96:16 [INFO] [stderr] | [INFO] [stderr] 96 | if can_combine == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `can_combine` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:135:31 [INFO] [stderr] | [INFO] [stderr] 135 | fn get_next_list(current_list:&Vec>)->Vec<(u8,u8)>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(u8,u8)>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:135:31 [INFO] [stderr] | [INFO] [stderr] 135 | fn get_next_list(current_list:&Vec>)->Vec<(u8,u8)>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(u8,u8)>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.42s [INFO] running `"docker" "inspect" "c6fe8396816a009987bb10277e335e01294209db709bc0866ebd693573376c6e"` [INFO] running `"docker" "rm" "-f" "c6fe8396816a009987bb10277e335e01294209db709bc0866ebd693573376c6e"` [INFO] [stdout] c6fe8396816a009987bb10277e335e01294209db709bc0866ebd693573376c6e