[INFO] updating cached repository colelawrence/rust_dijkstra [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/colelawrence/rust_dijkstra [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/colelawrence/rust_dijkstra" "work/ex/clippy-test-run/sources/stable/gh/colelawrence/rust_dijkstra"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/colelawrence/rust_dijkstra'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/colelawrence/rust_dijkstra" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/colelawrence/rust_dijkstra"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/colelawrence/rust_dijkstra'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 736f7d3f19ab489e4a63298da0bba592c81c3fd4 [INFO] sha for GitHub repo colelawrence/rust_dijkstra: 736f7d3f19ab489e4a63298da0bba592c81c3fd4 [INFO] validating manifest of colelawrence/rust_dijkstra on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of colelawrence/rust_dijkstra on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing colelawrence/rust_dijkstra [INFO] finished frobbing colelawrence/rust_dijkstra [INFO] frobbed toml for colelawrence/rust_dijkstra written to work/ex/clippy-test-run/sources/stable/gh/colelawrence/rust_dijkstra/Cargo.toml [INFO] started frobbing colelawrence/rust_dijkstra [INFO] finished frobbing colelawrence/rust_dijkstra [INFO] frobbed toml for colelawrence/rust_dijkstra written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/colelawrence/rust_dijkstra/Cargo.toml [INFO] crate colelawrence/rust_dijkstra has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting colelawrence/rust_dijkstra against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/colelawrence/rust_dijkstra:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 246b5b0b41043e9ab1e377a719e948b8021aa29e7182d7c7e1f2c47ce059e743 [INFO] running `"docker" "start" "-a" "246b5b0b41043e9ab1e377a719e948b8021aa29e7182d7c7e1f2c47ce059e743"` [INFO] [stderr] Checking rust_dijkstra v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/graph.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | / if !path.seen.contains_key(&next_id) { [INFO] [stderr] 56 | | next.insert(next_id, walk(&choice_walk, next_id, next_id_distance)); [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________________________^ help: consider using: `path.seen.entry(next_id).or_insert(walk(&choice_walk, next_id, next_id_distance))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `graph::G` [INFO] [stderr] --> src/graph.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / pub fn new() -> G { [INFO] [stderr] 98 | | G { [INFO] [stderr] 99 | | vertices: Vec::new(), [INFO] [stderr] 100 | | edges: HashMap::new(), [INFO] [stderr] 101 | | } [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/graph.rs:85:41 [INFO] [stderr] | [INFO] [stderr] 85 | let es = self.edges.entry(from).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/graph.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | / if !path.seen.contains_key(&next_id) { [INFO] [stderr] 56 | | next.insert(next_id, walk(&choice_walk, next_id, next_id_distance)); [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________________________^ help: consider using: `path.seen.entry(next_id).or_insert(walk(&choice_walk, next_id, next_id_distance))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `graph::G` [INFO] [stderr] --> src/graph.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / pub fn new() -> G { [INFO] [stderr] 98 | | G { [INFO] [stderr] 99 | | vertices: Vec::new(), [INFO] [stderr] 100 | | edges: HashMap::new(), [INFO] [stderr] 101 | | } [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/graph.rs:85:41 [INFO] [stderr] | [INFO] [stderr] 85 | let es = self.edges.entry(from).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.34s [INFO] running `"docker" "inspect" "246b5b0b41043e9ab1e377a719e948b8021aa29e7182d7c7e1f2c47ce059e743"` [INFO] running `"docker" "rm" "-f" "246b5b0b41043e9ab1e377a719e948b8021aa29e7182d7c7e1f2c47ce059e743"` [INFO] [stdout] 246b5b0b41043e9ab1e377a719e948b8021aa29e7182d7c7e1f2c47ce059e743