[INFO] updating cached repository code0100fun/image_fft [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/code0100fun/image_fft [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/code0100fun/image_fft" "work/ex/clippy-test-run/sources/stable/gh/code0100fun/image_fft"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/code0100fun/image_fft'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/code0100fun/image_fft" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/code0100fun/image_fft"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/code0100fun/image_fft'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 04cbffd673ec83e33cf75440f75b4ae54af54220 [INFO] sha for GitHub repo code0100fun/image_fft: 04cbffd673ec83e33cf75440f75b4ae54af54220 [INFO] validating manifest of code0100fun/image_fft on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of code0100fun/image_fft on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing code0100fun/image_fft [INFO] finished frobbing code0100fun/image_fft [INFO] frobbed toml for code0100fun/image_fft written to work/ex/clippy-test-run/sources/stable/gh/code0100fun/image_fft/Cargo.toml [INFO] started frobbing code0100fun/image_fft [INFO] finished frobbing code0100fun/image_fft [INFO] frobbed toml for code0100fun/image_fft written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/code0100fun/image_fft/Cargo.toml [INFO] crate code0100fun/image_fft has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting code0100fun/image_fft against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/code0100fun/image_fft:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3f3f7d0bb45f7021e821df651d8b331be14b30c9e9e397ca36cb4dc2215ed729 [INFO] running `"docker" "start" "-a" "3f3f7d0bb45f7021e821df651d8b331be14b30c9e9e397ca36cb4dc2215ed729"` [INFO] [stderr] Checking gnuplot v0.0.23 [INFO] [stderr] Checking rustfft v2.0.0 [INFO] [stderr] Checking image_fft v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/sin_waves.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | return sig; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sig` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/sin_waves.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return real.iter().map(|&n| Complex{re: n, im: 0.0}).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `real.iter().map(|&n| Complex{re: n, im: 0.0}).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/sin_waves.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | return spectrum_fft; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `spectrum_fft` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/sin_waves.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return p1; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `p1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> examples/sin_waves.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | fn plot(x: &Vec, y: &Vec, name: &str, output_file: &str) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> examples/sin_waves.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | fn plot(x: &Vec, y: &Vec, name: &str, output_file: &str) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> examples/sin_waves.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | fn real_to_complex(real: &Vec) -> Vec> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> examples/sin_waves.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | fn compute_fft(signal: &Vec) -> Vec> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> examples/sin_waves.rs:45:42 [INFO] [stderr] | [INFO] [stderr] 45 | fn compute_amplitude_spectrum(transform: &Vec>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Complex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> examples/sin_waves.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | let mut p1 = p2[0..l/2 + 1].to_vec(); [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=l/2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> examples/sin_waves.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | p1[0] = p1[0] / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `p1[0] /= 2.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> examples/sin_waves.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | p1[end] = p1[end] / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `p1[end] /= 2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> examples/sin_waves.rs:70:37 [INFO] [stderr] | [INFO] [stderr] 70 | let mut freq_domain: Vec = (0..sample_size/2 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=sample_size/2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.00s [INFO] running `"docker" "inspect" "3f3f7d0bb45f7021e821df651d8b331be14b30c9e9e397ca36cb4dc2215ed729"` [INFO] running `"docker" "rm" "-f" "3f3f7d0bb45f7021e821df651d8b331be14b30c9e9e397ca36cb4dc2215ed729"` [INFO] [stdout] 3f3f7d0bb45f7021e821df651d8b331be14b30c9e9e397ca36cb4dc2215ed729