[INFO] updating cached repository cmr/one-hour-roguelike
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cmr/one-hour-roguelike
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cmr/one-hour-roguelike" "work/ex/clippy-test-run/sources/stable/gh/cmr/one-hour-roguelike"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cmr/one-hour-roguelike'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cmr/one-hour-roguelike" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmr/one-hour-roguelike"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmr/one-hour-roguelike'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 06d314a5750343c7da3e7688de2d99620e2d2f3e
[INFO] sha for GitHub repo cmr/one-hour-roguelike: 06d314a5750343c7da3e7688de2d99620e2d2f3e
[INFO] validating manifest of cmr/one-hour-roguelike on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cmr/one-hour-roguelike on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cmr/one-hour-roguelike
[INFO] finished frobbing cmr/one-hour-roguelike
[INFO] frobbed toml for cmr/one-hour-roguelike written to work/ex/clippy-test-run/sources/stable/gh/cmr/one-hour-roguelike/Cargo.toml
[INFO] started frobbing cmr/one-hour-roguelike
[INFO] finished frobbing cmr/one-hour-roguelike
[INFO] frobbed toml for cmr/one-hour-roguelike written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmr/one-hour-roguelike/Cargo.toml
[INFO] crate cmr/one-hour-roguelike has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cmr/one-hour-roguelike against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmr/one-hour-roguelike:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 347a7e03f526cb07bc5ac7364a2844a2b3d7a2bb0e57a69d4d473160907b4548
[INFO] running `"docker" "start" "-a" "347a7e03f526cb07bc5ac7364a2844a2b3d7a2bb0e57a69d4d473160907b4548"`
[INFO] [stderr]     Checking rogue v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:97:23
[INFO] [stderr]    |
[INFO] [stderr] 97 |     let mut m = Map { width: width, height: height, data: Vec::new() };
[INFO] [stderr]    |                       ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:97:37
[INFO] [stderr]    |
[INFO] [stderr] 97 |     let mut m = Map { width: width, height: height, data: Vec::new() };
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:134:52
[INFO] [stderr]     |
[INFO] [stderr] 134 |     return Game { map: m, player: player.unwrap(), emus: emus };
[INFO] [stderr]     |                                                    ^^^^^^^^^^ help: replace it with: `emus`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/main.rs:156:13
[INFO] [stderr]     |
[INFO] [stderr] 156 |             println!("");
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:97:23
[INFO] [stderr]    |
[INFO] [stderr] 97 |     let mut m = Map { width: width, height: height, data: Vec::new() };
[INFO] [stderr]    |                       ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:97:37
[INFO] [stderr]    |
[INFO] [stderr] 97 |     let mut m = Map { width: width, height: height, data: Vec::new() };
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:134:52
[INFO] [stderr]     |
[INFO] [stderr] 134 |     return Game { map: m, player: player.unwrap(), emus: emus };
[INFO] [stderr]     |                                                    ^^^^^^^^^^ help: replace it with: `emus`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/main.rs:156:13
[INFO] [stderr]     |
[INFO] [stderr] 156 |             println!("");
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/main.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 |     return Rc::new(RefCell::new(val));
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rc::new(RefCell::new(val))`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:134:5
[INFO] [stderr]     |
[INFO] [stderr] 134 |     return Game { map: m, player: player.unwrap(), emus: emus };
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Game { map: m, player: player.unwrap(), emus: emus }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/main.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 |     return Rc::new(RefCell::new(val));
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rc::new(RefCell::new(val))`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:134:5
[INFO] [stderr]     |
[INFO] [stderr] 134 |     return Game { map: m, player: player.unwrap(), emus: emus };
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Game { map: m, player: player.unwrap(), emus: emus }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:172:9
[INFO] [stderr]     |
[INFO] [stderr] 172 |     let mut stdin = std::io::stdin();
[INFO] [stderr]     |         ----^^^^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function `P` should have a snake case name such as `p`
[INFO] [stderr]  --> src/main.rs:6:1
[INFO] [stderr]   |
[INFO] [stderr] 6 | / fn P<T>(val: T) -> P<T> {
[INFO] [stderr] 7 | |     return Rc::new(RefCell::new(val));
[INFO] [stderr] 8 | | }
[INFO] [stderr]   | |_^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 | /         if let &Cell::Player(_) = self {
[INFO] [stderr] 23 | |             true
[INFO] [stderr] 24 | |         } else {
[INFO] [stderr] 25 | |             false
[INFO] [stderr] 26 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 22 |         if let Cell::Player(_) = *self {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:172:9
[INFO] [stderr]     |
[INFO] [stderr] 172 |     let mut stdin = std::io::stdin();
[INFO] [stderr]     |         ----^^^^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function `P` should have a snake case name such as `p`
[INFO] [stderr]  --> src/main.rs:6:1
[INFO] [stderr]   |
[INFO] [stderr] 6 | / fn P<T>(val: T) -> P<T> {
[INFO] [stderr] 7 | |     return Rc::new(RefCell::new(val));
[INFO] [stderr] 8 | | }
[INFO] [stderr]   | |_^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 | /         if let &Cell::Player(_) = self {
[INFO] [stderr] 23 | |             true
[INFO] [stderr] 24 | |         } else {
[INFO] [stderr] 25 | |             false
[INFO] [stderr] 26 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 22 |         if let Cell::Player(_) = *self {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:143:12
[INFO] [stderr]     |
[INFO] [stderr] 143 |     |cell| if let &Cell::Player(_) = cell { true } else { false }) {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 143 |     |cell| if let Cell::Player(_) = *cell { true } else { false }) {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:169:5
[INFO] [stderr]     |
[INFO] [stderr] 169 |     f.read_to_end(&mut loaded);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:178:9
[INFO] [stderr]     |
[INFO] [stderr] 178 |         stdin.read_line(&mut line);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:179:12
[INFO] [stderr]     |
[INFO] [stderr] 179 |         if line.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:143:12
[INFO] [stderr]     |
[INFO] [stderr] 143 |     |cell| if let &Cell::Player(_) = cell { true } else { false }) {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 143 |     |cell| if let Cell::Player(_) = *cell { true } else { false }) {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:169:5
[INFO] [stderr]     |
[INFO] [stderr] 169 |     f.read_to_end(&mut loaded);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:178:9
[INFO] [stderr]     |
[INFO] [stderr] 178 |         stdin.read_line(&mut line);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:179:12
[INFO] [stderr]     |
[INFO] [stderr] 179 |         if line.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.67s
[INFO] running `"docker" "inspect" "347a7e03f526cb07bc5ac7364a2844a2b3d7a2bb0e57a69d4d473160907b4548"`
[INFO] running `"docker" "rm" "-f" "347a7e03f526cb07bc5ac7364a2844a2b3d7a2bb0e57a69d4d473160907b4548"`
[INFO] [stdout] 347a7e03f526cb07bc5ac7364a2844a2b3d7a2bb0e57a69d4d473160907b4548