[INFO] updating cached repository cmoncrief/rust-morph [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cmoncrief/rust-morph [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cmoncrief/rust-morph" "work/ex/clippy-test-run/sources/stable/gh/cmoncrief/rust-morph"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cmoncrief/rust-morph'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cmoncrief/rust-morph" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmoncrief/rust-morph"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmoncrief/rust-morph'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 565131a850e7a85a871055ffd792d27959887c37 [INFO] sha for GitHub repo cmoncrief/rust-morph: 565131a850e7a85a871055ffd792d27959887c37 [INFO] validating manifest of cmoncrief/rust-morph on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cmoncrief/rust-morph on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cmoncrief/rust-morph [INFO] finished frobbing cmoncrief/rust-morph [INFO] frobbed toml for cmoncrief/rust-morph written to work/ex/clippy-test-run/sources/stable/gh/cmoncrief/rust-morph/Cargo.toml [INFO] started frobbing cmoncrief/rust-morph [INFO] finished frobbing cmoncrief/rust-morph [INFO] frobbed toml for cmoncrief/rust-morph written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmoncrief/rust-morph/Cargo.toml [INFO] crate cmoncrief/rust-morph has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cmoncrief/rust-morph against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmoncrief/rust-morph:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aa49284442186ae7439a146f14931ccddf9c5882671014a0d802ced5153528c4 [INFO] running `"docker" "start" "-a" "aa49284442186ae7439a146f14931ccddf9c5882671014a0d802ced5153528c4"` [INFO] [stderr] Checking string_morph v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/converter.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | / if index_char.0 > 1 && ONE_LETTER_WORDS.contains(&char_ref[index_char.0 - 1]) { [INFO] [stderr] 73 | | if index_char.0 > 3 && output.chars().nth(output.len() - 2).unwrap() == ' ' { [INFO] [stderr] 74 | | let c = output.pop().unwrap(); [INFO] [stderr] 75 | | output.push(c.to_ascii_lowercase()); [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 72 | if index_char.0 > 1 && ONE_LETTER_WORDS.contains(&char_ref[index_char.0 - 1]) && index_char.0 > 3 && output.chars().nth(output.len() - 2).unwrap() == ' ' { [INFO] [stderr] 73 | let c = output.pop().unwrap(); [INFO] [stderr] 74 | output.push(c.to_ascii_lowercase()); [INFO] [stderr] 75 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/converter.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | / if index_char.0 > 1 && ONE_LETTER_WORDS.contains(&char_ref[index_char.0 - 1]) { [INFO] [stderr] 73 | | if index_char.0 > 3 && output.chars().nth(output.len() - 2).unwrap() == ' ' { [INFO] [stderr] 74 | | let c = output.pop().unwrap(); [INFO] [stderr] 75 | | output.push(c.to_ascii_lowercase()); [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 72 | if index_char.0 > 1 && ONE_LETTER_WORDS.contains(&char_ref[index_char.0 - 1]) && index_char.0 > 3 && output.chars().nth(output.len() - 2).unwrap() == ' ' { [INFO] [stderr] 73 | let c = output.pop().unwrap(); [INFO] [stderr] 74 | output.push(c.to_ascii_lowercase()); [INFO] [stderr] 75 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii` [INFO] [stderr] --> src/converter.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/converter.rs:29:52 [INFO] [stderr] | [INFO] [stderr] 29 | input.chars().enumerate().fold("".to_string(), |mut output, index_char| { [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | cur_upper = index_char.1.is_uppercase(); [INFO] [stderr] 32 | | cur_sep = SEPARATORS.contains(&index_char.1); [INFO] [stderr] ... | [INFO] [stderr] 131 | | output [INFO] [stderr] 132 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/converter.rs:128:21 [INFO] [stderr] | [INFO] [stderr] 128 | last_char = if index_char.0 == (len - 2) {true} else {false}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `index_char.0 == (len - 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/converter.rs:129:20 [INFO] [stderr] | [INFO] [stderr] 129 | prev_sep = if cur_sep || is_post_boundary {true} else {false}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `cur_sep || is_post_boundary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii` [INFO] [stderr] --> src/converter.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/converter.rs:29:52 [INFO] [stderr] | [INFO] [stderr] 29 | input.chars().enumerate().fold("".to_string(), |mut output, index_char| { [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | cur_upper = index_char.1.is_uppercase(); [INFO] [stderr] 32 | | cur_sep = SEPARATORS.contains(&index_char.1); [INFO] [stderr] ... | [INFO] [stderr] 131 | | output [INFO] [stderr] 132 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/converter.rs:128:21 [INFO] [stderr] | [INFO] [stderr] 128 | last_char = if index_char.0 == (len - 2) {true} else {false}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `index_char.0 == (len - 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/converter.rs:129:20 [INFO] [stderr] | [INFO] [stderr] 129 | prev_sep = if cur_sep || is_post_boundary {true} else {false}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `cur_sep || is_post_boundary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `string_morph`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "aa49284442186ae7439a146f14931ccddf9c5882671014a0d802ced5153528c4"` [INFO] running `"docker" "rm" "-f" "aa49284442186ae7439a146f14931ccddf9c5882671014a0d802ced5153528c4"` [INFO] [stdout] aa49284442186ae7439a146f14931ccddf9c5882671014a0d802ced5153528c4