[INFO] updating cached repository clarkenciel/rox [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/clarkenciel/rox [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/clarkenciel/rox" "work/ex/clippy-test-run/sources/stable/gh/clarkenciel/rox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/clarkenciel/rox'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/clarkenciel/rox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clarkenciel/rox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clarkenciel/rox'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f206f92e5efb363b23021f657e70cdcd63501c5a [INFO] sha for GitHub repo clarkenciel/rox: f206f92e5efb363b23021f657e70cdcd63501c5a [INFO] validating manifest of clarkenciel/rox on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of clarkenciel/rox on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing clarkenciel/rox [INFO] finished frobbing clarkenciel/rox [INFO] frobbed toml for clarkenciel/rox written to work/ex/clippy-test-run/sources/stable/gh/clarkenciel/rox/Cargo.toml [INFO] started frobbing clarkenciel/rox [INFO] finished frobbing clarkenciel/rox [INFO] frobbed toml for clarkenciel/rox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clarkenciel/rox/Cargo.toml [INFO] crate clarkenciel/rox has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting clarkenciel/rox against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clarkenciel/rox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0c497e64620748084f48def954453a43ea76be29dce61e60ee4de1c52dfb7730 [INFO] running `"docker" "start" "-a" "0c497e64620748084f48def954453a43ea76be29dce61e60ee4de1c52dfb7730"` [INFO] [stderr] Checking rox v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:79:20 [INFO] [stderr] | [INFO] [stderr] 79 | RoxError { error: error } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:79:20 [INFO] [stderr] | [INFO] [stderr] 79 | RoxError { error: error } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `EOF` [INFO] [stderr] --> src/token_type.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | EOF, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse` [INFO] [stderr] --> src/literal.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn parse(s: String) -> ParseResult { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/literal.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | .map(|b| Literal::Boolean(b)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Literal::Boolean` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/literal.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | if !(s.starts_with("\"") && s.ends_with("\"")) { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/literal.rs:42:45 [INFO] [stderr] | [INFO] [stderr] 42 | if !(s.starts_with("\"") && s.ends_with("\"")) { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/literal.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | .map(|n| Literal::Number(n)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Literal::Number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/scanner.rs:164:18 [INFO] [stderr] | [INFO] [stderr] 164 | let tt = self.reserved_words [INFO] [stderr] | __________________^ [INFO] [stderr] 165 | | .get(&*self.current) [INFO] [stderr] 166 | | .map(|&tt| tt) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 164 | let tt = self.reserved_words [INFO] [stderr] 165 | .get(&*self.current).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scanner.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | / match self.source.clone().take(2).collect::>().get(0..2) { [INFO] [stderr] 175 | | Some(&[c1, c2]) => if is_dot(c1) && is_digit(c2) { [INFO] [stderr] 176 | | let dot = self.source.next().unwrap(); [INFO] [stderr] 177 | | self.consume(dot); [INFO] [stderr] ... | [INFO] [stderr] 180 | | _ => (), [INFO] [stderr] 181 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 174 | if let Some(&[c1, c2]) = self.source.clone().take(2).collect::>().get(0..2) { if is_dot(c1) && is_digit(c2) { [INFO] [stderr] 175 | let dot = self.source.next().unwrap(); [INFO] [stderr] 176 | self.consume(dot); [INFO] [stderr] 177 | self.slurp_while(&is_digit); [INFO] [stderr] 178 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `EOF` [INFO] [stderr] --> src/token_type.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | EOF, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse` [INFO] [stderr] --> src/literal.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn parse(s: String) -> ParseResult { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | fn run_file(path: &String) -> RoxResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:55:53 [INFO] [stderr] | [INFO] [stderr] 55 | Ok(_) => run(line).unwrap_or_else(|e| { e.report(); }), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/literal.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | .map(|b| Literal::Boolean(b)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Literal::Boolean` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/literal.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | if !(s.starts_with("\"") && s.ends_with("\"")) { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/literal.rs:42:45 [INFO] [stderr] | [INFO] [stderr] 42 | if !(s.starts_with("\"") && s.ends_with("\"")) { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/literal.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | .map(|n| Literal::Number(n)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Literal::Number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/scanner.rs:164:18 [INFO] [stderr] | [INFO] [stderr] 164 | let tt = self.reserved_words [INFO] [stderr] | __________________^ [INFO] [stderr] 165 | | .get(&*self.current) [INFO] [stderr] 166 | | .map(|&tt| tt) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 164 | let tt = self.reserved_words [INFO] [stderr] 165 | .get(&*self.current).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scanner.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | / match self.source.clone().take(2).collect::>().get(0..2) { [INFO] [stderr] 175 | | Some(&[c1, c2]) => if is_dot(c1) && is_digit(c2) { [INFO] [stderr] 176 | | let dot = self.source.next().unwrap(); [INFO] [stderr] 177 | | self.consume(dot); [INFO] [stderr] ... | [INFO] [stderr] 180 | | _ => (), [INFO] [stderr] 181 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 174 | if let Some(&[c1, c2]) = self.source.clone().take(2).collect::>().get(0..2) { if is_dot(c1) && is_digit(c2) { [INFO] [stderr] 175 | let dot = self.source.next().unwrap(); [INFO] [stderr] 176 | self.consume(dot); [INFO] [stderr] 177 | self.slurp_while(&is_digit); [INFO] [stderr] 178 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | fn run_file(path: &String) -> RoxResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:55:53 [INFO] [stderr] | [INFO] [stderr] 55 | Ok(_) => run(line).unwrap_or_else(|e| { e.report(); }), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.11s [INFO] running `"docker" "inspect" "0c497e64620748084f48def954453a43ea76be29dce61e60ee4de1c52dfb7730"` [INFO] running `"docker" "rm" "-f" "0c497e64620748084f48def954453a43ea76be29dce61e60ee4de1c52dfb7730"` [INFO] [stdout] 0c497e64620748084f48def954453a43ea76be29dce61e60ee4de1c52dfb7730