[INFO] updating cached repository christophertrml/rust8 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/christophertrml/rust8 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/christophertrml/rust8" "work/ex/clippy-test-run/sources/stable/gh/christophertrml/rust8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/christophertrml/rust8'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/christophertrml/rust8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/christophertrml/rust8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/christophertrml/rust8'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 51bf0901cf1fb4bd8e8620fd4399a06587979764 [INFO] sha for GitHub repo christophertrml/rust8: 51bf0901cf1fb4bd8e8620fd4399a06587979764 [INFO] validating manifest of christophertrml/rust8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of christophertrml/rust8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing christophertrml/rust8 [INFO] finished frobbing christophertrml/rust8 [INFO] frobbed toml for christophertrml/rust8 written to work/ex/clippy-test-run/sources/stable/gh/christophertrml/rust8/Cargo.toml [INFO] started frobbing christophertrml/rust8 [INFO] finished frobbing christophertrml/rust8 [INFO] frobbed toml for christophertrml/rust8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/christophertrml/rust8/Cargo.toml [INFO] crate christophertrml/rust8 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting christophertrml/rust8 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/christophertrml/rust8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a2ff6b0c6ac5637b5c2f4e87e492bd419aec7e13942b359a0b3832cf90a97405 [INFO] running `"docker" "start" "-a" "a2ff6b0c6ac5637b5c2f4e87e492bd419aec7e13942b359a0b3832cf90a97405"` [INFO] [stderr] Checking rust8 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip8.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | i: 0b00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip8.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | sp: 0b00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip8.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | i: 0b00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chip8.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | sp: 0b00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: field is never used: `delay_timer` [INFO] [stderr] --> src/chip8.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | delay_timer: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `sound_timer` [INFO] [stderr] --> src/chip8.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | sound_timer: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `gfx` [INFO] [stderr] --> src/chip8.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | gfx: [[bool; 32]; 64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `keys` [INFO] [stderr] --> src/chip8.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | keys: [bool; 16], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `left_shift` [INFO] [stderr] --> src/chip8.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | fn left_shift(&mut self, opcode: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | ((self.memory[self.pc as usize]) as u16) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((self.memory[self.pc as usize]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | (self.memory[(self.pc + 1) as usize]) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((self.memory[(self.pc + 1) as usize]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/chip8.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | / match opcode & 0xFFF { [INFO] [stderr] 56 | | 0x00EE => self.return_from_subroutine(), [INFO] [stderr] 57 | | _ => {} [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________________^ help: try this: `if let 0x00EE = opcode & 0xFFF { self.return_from_subroutine() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/chip8.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | / match opcode & 0x000F { [INFO] [stderr] 66 | | 0x0000 => self.skip_if_equals_v(opcode), [INFO] [stderr] 67 | | _ => {}, [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________________^ help: try this: `if let 0x0000 = opcode & 0x000F { self.skip_if_equals_v(opcode) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/chip8.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | / match opcode & 0x000F { [INFO] [stderr] 86 | | 0x0000 => self.skip_if_not_equals_v(opcode), [INFO] [stderr] 87 | | _ => {}, [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________________^ help: try this: `if let 0x0000 = opcode & 0x000F { self.skip_if_not_equals_v(opcode) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: field is never used: `delay_timer` [INFO] [stderr] --> src/chip8.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | delay_timer: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `sound_timer` [INFO] [stderr] --> src/chip8.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | sound_timer: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `gfx` [INFO] [stderr] --> src/chip8.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | gfx: [[bool; 32]; 64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `keys` [INFO] [stderr] --> src/chip8.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | keys: [bool; 16], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `left_shift` [INFO] [stderr] --> src/chip8.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | fn left_shift(&mut self, opcode: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | ((self.memory[self.pc as usize]) as u16) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((self.memory[self.pc as usize]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | (self.memory[(self.pc + 1) as usize]) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((self.memory[(self.pc + 1) as usize]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/chip8.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | / match opcode & 0xFFF { [INFO] [stderr] 56 | | 0x00EE => self.return_from_subroutine(), [INFO] [stderr] 57 | | _ => {} [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________________^ help: try this: `if let 0x00EE = opcode & 0xFFF { self.return_from_subroutine() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/chip8.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | / match opcode & 0x000F { [INFO] [stderr] 66 | | 0x0000 => self.skip_if_equals_v(opcode), [INFO] [stderr] 67 | | _ => {}, [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________________^ help: try this: `if let 0x0000 = opcode & 0x000F { self.skip_if_equals_v(opcode) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/chip8.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | / match opcode & 0x000F { [INFO] [stderr] 86 | | 0x0000 => self.skip_if_not_equals_v(opcode), [INFO] [stderr] 87 | | _ => {}, [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________________^ help: try this: `if let 0x0000 = opcode & 0x000F { self.skip_if_not_equals_v(opcode) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.43s [INFO] running `"docker" "inspect" "a2ff6b0c6ac5637b5c2f4e87e492bd419aec7e13942b359a0b3832cf90a97405"` [INFO] running `"docker" "rm" "-f" "a2ff6b0c6ac5637b5c2f4e87e492bd419aec7e13942b359a0b3832cf90a97405"` [INFO] [stdout] a2ff6b0c6ac5637b5c2f4e87e492bd419aec7e13942b359a0b3832cf90a97405