[INFO] updating cached repository christophertrml/rs-natural [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/christophertrml/rs-natural [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/christophertrml/rs-natural" "work/ex/clippy-test-run/sources/stable/gh/christophertrml/rs-natural"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/christophertrml/rs-natural'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/christophertrml/rs-natural" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/christophertrml/rs-natural"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/christophertrml/rs-natural'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f8f45f60caaf16c9d5865922d6ad9e6d67f55b31 [INFO] sha for GitHub repo christophertrml/rs-natural: f8f45f60caaf16c9d5865922d6ad9e6d67f55b31 [INFO] validating manifest of christophertrml/rs-natural on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of christophertrml/rs-natural on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing christophertrml/rs-natural [INFO] finished frobbing christophertrml/rs-natural [INFO] frobbed toml for christophertrml/rs-natural written to work/ex/clippy-test-run/sources/stable/gh/christophertrml/rs-natural/Cargo.toml [INFO] started frobbing christophertrml/rs-natural [INFO] finished frobbing christophertrml/rs-natural [INFO] frobbed toml for christophertrml/rs-natural written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/christophertrml/rs-natural/Cargo.toml [INFO] crate christophertrml/rs-natural has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting christophertrml/rs-natural against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/christophertrml/rs-natural:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4225043e73840512f46064746f2d4e0a77fcd94cef256e686864333e15758efe [INFO] running `"docker" "start" "-a" "4225043e73840512f46064746f2d4e0a77fcd94cef256e686864333e15758efe"` [INFO] [stderr] Checking natural v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stem.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stem.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | k: k, [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stem.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stem.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | k: k, [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::Ordering` [INFO] [stderr] --> src/tf_idf.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::cmp::Ordering; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/stem.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::Ordering` [INFO] [stderr] --> src/tf_idf.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::cmp::Ordering; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/stem.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/stem.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `normalized_prob` is never read [INFO] [stderr] --> src/classifier.rs:39:15 [INFO] [stderr] | [INFO] [stderr] 39 | let mut normalized_prob = 0.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/distance.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / let mut s = str2; [INFO] [stderr] 22 | | [INFO] [stderr] 23 | | if ordering { [INFO] [stderr] 24 | | f = str2; [INFO] [stderr] 25 | | s = str1; [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let s = if ordering { ..; str1 } else { str2 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/distance.rs:78:34 [INFO] [stderr] | [INFO] [stderr] 78 | let mut column: Vec = (0..n + 1).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: use: `(0..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/distance.rs:82:14 [INFO] [stderr] | [INFO] [stderr] 82 | for i in 1..m + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/distance.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | for j in 1..n + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `chars`. [INFO] [stderr] --> src/phonetics.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | for i in 1..chars.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for in chars.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `classifier::NaiveBayesClassifier` [INFO] [stderr] --> src/classifier.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> NaiveBayesClassifier { [INFO] [stderr] 12 | | NaiveBayesClassifier { [INFO] [stderr] 13 | | documents: HashMap::new(), [INFO] [stderr] 14 | | total_document_count: 0, [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/classifier.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | .or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/stem.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tf_idf::TfIdf` [INFO] [stderr] --> src/tf_idf.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn new() -> TfIdf { [INFO] [stderr] | _____^ [INFO] [stderr] 22 | | TfIdf { [INFO] [stderr] 23 | | doc_freqs: HashMap::new(), [INFO] [stderr] 24 | | term_freqs: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/tf_idf.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | for token in tokens_ref.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/tf_idf.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | for token in tokens_ref.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tf_idf.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | Some(freq) => freq.clone() as f32 / self.word_count as f32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*freq` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tf_idf.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | Some(freq) => freq.clone() as f32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/tf_idf.rs:87:30 [INFO] [stderr] | [INFO] [stderr] 87 | let score: f32 = token_ref.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: value assigned to `normalized_prob` is never read [INFO] [stderr] --> src/classifier.rs:39:15 [INFO] [stderr] | [INFO] [stderr] 39 | let mut normalized_prob = 0.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `s` [INFO] [stderr] --> src/stem.rs:122:18 [INFO] [stderr] | [INFO] [stderr] 122 | for i in 0..(len) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 122 | for (i, ) in s.iter().enumerate().take((len)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/stem.rs:268:41 [INFO] [stderr] | [INFO] [stderr] 268 | else if self.ends("ou") {} [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/stem.rs:267:80 [INFO] [stderr] | [INFO] [stderr] 267 | (self.b[self.j - 1] == b's' || self.b[self.j - 1] == b't') {} [INFO] [stderr] | ^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `natural`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/distance.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / let mut s = str2; [INFO] [stderr] 22 | | [INFO] [stderr] 23 | | if ordering { [INFO] [stderr] 24 | | f = str2; [INFO] [stderr] 25 | | s = str1; [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let s = if ordering { ..; str1 } else { str2 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/distance.rs:78:34 [INFO] [stderr] | [INFO] [stderr] 78 | let mut column: Vec = (0..n + 1).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: use: `(0..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/distance.rs:82:14 [INFO] [stderr] | [INFO] [stderr] 82 | for i in 1..m + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/distance.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | for j in 1..n + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `chars`. [INFO] [stderr] --> src/phonetics.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | for i in 1..chars.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for in chars.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `classifier::NaiveBayesClassifier` [INFO] [stderr] --> src/classifier.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> NaiveBayesClassifier { [INFO] [stderr] 12 | | NaiveBayesClassifier { [INFO] [stderr] 13 | | documents: HashMap::new(), [INFO] [stderr] 14 | | total_document_count: 0, [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/classifier.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | .or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tf_idf::TfIdf` [INFO] [stderr] --> src/tf_idf.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn new() -> TfIdf { [INFO] [stderr] | _____^ [INFO] [stderr] 22 | | TfIdf { [INFO] [stderr] 23 | | doc_freqs: HashMap::new(), [INFO] [stderr] 24 | | term_freqs: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/tf_idf.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | for token in tokens_ref.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/tf_idf.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | for token in tokens_ref.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tf_idf.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | Some(freq) => freq.clone() as f32 / self.word_count as f32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*freq` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tf_idf.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | Some(freq) => freq.clone() as f32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/tf_idf.rs:87:30 [INFO] [stderr] | [INFO] [stderr] 87 | let score: f32 = token_ref.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `s` [INFO] [stderr] --> src/stem.rs:122:18 [INFO] [stderr] | [INFO] [stderr] 122 | for i in 0..(len) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 122 | for (i, ) in s.iter().enumerate().take((len)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/stem.rs:268:41 [INFO] [stderr] | [INFO] [stderr] 268 | else if self.ends("ou") {} [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/stem.rs:267:80 [INFO] [stderr] | [INFO] [stderr] 267 | (self.b[self.j - 1] == b's' || self.b[self.j - 1] == b't') {} [INFO] [stderr] | ^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `natural`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4225043e73840512f46064746f2d4e0a77fcd94cef256e686864333e15758efe"` [INFO] running `"docker" "rm" "-f" "4225043e73840512f46064746f2d4e0a77fcd94cef256e686864333e15758efe"` [INFO] [stdout] 4225043e73840512f46064746f2d4e0a77fcd94cef256e686864333e15758efe